mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-06-03 14:19:01 +02:00
add metric for invalid hash and other sharejs errors
This commit is contained in:
@@ -48,6 +48,7 @@ module.exports = ShareJsUpdateManager =
|
||||
error = new Errors.DeleteMismatchError("Delete component does not match")
|
||||
return callback(error)
|
||||
else
|
||||
metrics.inc "sharejs.other-error"
|
||||
return callback(error)
|
||||
logger.log project_id: project_id, doc_id: doc_id, error: error, "applied update"
|
||||
model.getSnapshot doc_key, (error, data) =>
|
||||
@@ -55,7 +56,11 @@ module.exports = ShareJsUpdateManager =
|
||||
# only check hash when present and no other updates have been applied
|
||||
if update.hash? and incomingUpdateVersion == version
|
||||
ourHash = ShareJsUpdateManager._computeHash(data.snapshot)
|
||||
return callback(new Error("Invalid hash")) if ourHash != update.hash
|
||||
if ourHash != update.hash
|
||||
metrics.inc "sharejs.hash-fail"
|
||||
return callback(new Error("Invalid hash"))
|
||||
else
|
||||
metrics.inc "sharejs.hash-pass", 0.001
|
||||
docLines = data.snapshot.split(/\r\n|\n|\r/)
|
||||
callback(null, docLines, data.v, model.db.appliedOps[doc_key] or [])
|
||||
|
||||
|
||||
Reference in New Issue
Block a user