agw/overleaf-cep
1
0
Fork 0
mirror of https://github.com/yu-i-i/overleaf-cep.git synced 2026-05-23 17:19:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

[CE/SP] Fix default footer (#28947)

Browse Source 
* [CE/SP] Fix default footer

Fixes the default `right_footer`. Only 'text' should be defined when it contains HTML code.

* Remove font-awesome github icon

* Added acceptance test

GitOrigin-RevId: 1a1ba04673f35affcec4bb17bc7cd860d589b13f
This commit is contained in:
Miguel Serrano
2025-10-10 10:31:40 +02:00
committed by Copybot
parent 58094ebcd6
commit d54efe78f7
2 changed files with 32 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
server-ce/test/customization.spec.ts
View File

@@ -2,25 +2,39 @@ import { isExcludedBySharding, startWith } from './helpers/config'
describe('Customization', () => {
if (isExcludedBySharding('CE_CUSTOM_1')) return
startWith({
vars: {
OVERLEAF_APP_NAME: 'CUSTOM APP NAME',
OVERLEAF_LEFT_FOOTER: JSON.stringify([{ text: 'CUSTOM LEFT FOOTER' }]),
OVERLEAF_RIGHT_FOOTER: JSON.stringify([{ text: 'CUSTOM RIGHT FOOTER' }]),
},
describe('default settings', () => {
startWith({})
it('should display the default right footer', () => {
cy.visit('/')
cy.get('footer').findByRole('link', { name: 'Fork on GitHub!' })
})
})
it('should display custom name', () => {
cy.visit('/')
cy.get('nav').findByText('CUSTOM APP NAME')
})
describe('custom settings', () => {
startWith({
vars: {
OVERLEAF_APP_NAME: 'CUSTOM APP NAME',
OVERLEAF_LEFT_FOOTER: JSON.stringify([{ text: 'CUSTOM LEFT FOOTER' }]),
OVERLEAF_RIGHT_FOOTER: JSON.stringify([
{ text: 'CUSTOM RIGHT FOOTER' },
]),
},
})
it('should display custom left footer', () => {
cy.visit('/')
cy.get('footer').findByText('CUSTOM LEFT FOOTER')
})
it('should display custom right footer', () => {
cy.visit('/')
cy.get('footer').findByText('CUSTOM RIGHT FOOTER')
it('should display custom name', () => {
cy.visit('/')
cy.get('nav').findByText('CUSTOM APP NAME')
})
it('should display custom left footer', () => {
cy.visit('/')
cy.get('footer').findByText('CUSTOM LEFT FOOTER')
})
it('should display custom right footer', () => {
cy.visit('/')
cy.get('footer').findByText('CUSTOM RIGHT FOOTER')
})
})
})

3
services/web/config/settings.defaults.js
View File

@@ -778,8 +778,7 @@ module.exports = {
right_footer: [
{
text: "<i class='fa fa-github-square'></i> Fork on GitHub!",
url: 'https://github.com/overleaf/overleaf',
text: '<a href="https://github.com/overleaf/overleaf">Fork on GitHub!</a>',
},
],