Commit Graph

7863 Commits

Author SHA1 Message Date
Tim Alby 16db3a0806 gracefully handle subscriptions without currency 2018-10-11 10:38:48 +01:00
Alasdair Smith e91ab3bf83 Merge pull request #1017 from sharelatex/as-fix-autocompile-loop
Prevent autocompile loop
2018-10-11 10:30:39 +01:00
Alasdair Smith 96d7d83b90 Add guard against autocompile being disabled 2018-10-11 09:30:21 +01:00
Simon Detheridge e4a3f838de Merge pull request #1016 from sharelatex/spd-missing-translation
Fix missing string in modals.pug
2018-10-10 17:33:54 +01:00
Simon Detheridge e7506489d1 Fix missing string in modals.pug
Add escape to execute translate() server-side when handling error message for invalid filenames in project on copy.

Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-10 15:06:37 +01:00
Alasdair Smith 9dd965da3c Prevent autocompile loop
If an autocompile hits a rate limit, it would get into a bad state where
it would continuely loop making compile requests. This is because the
compile response resolving would disable auto compile (because the rate
limit was hit) but also trigger calculation of uncompiled changes, which
would not check if autocompile was disabled. The fix is to just check if
autocompile is disabled.
2018-10-10 15:04:18 +01:00
Simon Detheridge ea2782ff22 Merge pull request #1005 from sharelatex/spd-no-more-asterisks
Sanitize paths in all relevant ProjectEntityHandler methods
2018-10-10 10:44:13 +01:00
Alasdair Smith 250edf4670 Merge pull request #1010 from sharelatex/as-fix-no-sl
Switch dev env to use v2 port instead of SL
2018-10-10 10:11:16 +01:00
Ersun Warncke 1b50f0ced8 Merge pull request #1011 from sharelatex/ew-add-account-merge-error
add account merge error
2018-10-09 12:54:54 -04:00
Simon Detheridge 32149e652f Handle 'invalid element name' error in project list ui
When invalid filenames are found during project-copy, the somewhat obscure (and non-localised) 'invalid element name' error is returned. Add a special case to handle this particular error and display something more descriptive to the user.

Added a modal error handler for when this error is generated by clicking the 'copy' icon in the project list, instead of using the 'more' dropdown which opens a modal copy dialog

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-09 17:23:43 +01:00
Ersun Warncke 8719eff1d7 update error message 2018-10-09 11:44:59 -04:00
Ersun Warncke 7652e80800 add account merge error 2018-10-09 09:47:03 -04:00
Timothée Alby 914546d7d6 Merge pull request #983 from sharelatex/ta-user-ties
Add Group Managers Management Page
2018-10-09 14:00:59 +01:00
Brian Gough 4efc118b9c Merge pull request #1009 from sharelatex/bg-update-metrics-to-1.8.0
update to metrics v1.8.0 for metrics.globalGauge
2018-10-09 12:15:30 +01:00
Tim Alby 48e5c6b523 add UserMembership logic 2018-10-09 12:09:11 +01:00
Brian Gough 8c3b5acdd0 update to metrics v1.8.0 for metrics.globalGauge 2018-10-09 11:46:19 +01:00
Alasdair Smith 98d35b4e50 Use settings instead of hard-coding ports 2018-10-09 11:23:21 +01:00
Brian Gough a68bde819d Merge pull request #1004 from sharelatex/ta-test-mock-fix
Fix Test Mock
2018-10-09 10:35:50 +01:00
Jessica Lawshe 8f8765a412 Merge pull request #1008 from sharelatex/ta-fix-help-link
fix link to link sharing help page
2018-10-08 16:09:31 +01:00
Tim Alby cf47fc0b1c fix link to link sharing help page 2018-10-08 16:07:11 +01:00
Jessica Lawshe 6c5cf571da Merge pull request #1007 from sharelatex/jel-social-image
Add default Twitter and OG images
2018-10-08 16:04:13 +01:00
Simon Detheridge 56dcbefb5b Check for safe paths in all ProjectEntityHandler methods
Some import mechanisms (for example, Github project import) call methods such as 'upsert*' directly, bypassing existing filename checks.

Added checks to all methods in ProjectEntityHandler that can create or rename a file.

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-08 15:31:04 +01:00
Jessica Lawshe d9c98aa45e Add default Twitter and OG images 2018-10-08 15:18:18 +01:00
Simon Detheridge e66210d2af Add method to sanitize full paths
For convenience, add a method to SafePath to break a path into components and verify the status of each one.

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-08 14:48:17 +01:00
Simon Detheridge 50993f59c0 Merge pull request #926 from sharelatex/dcl-i850
Display password change form in Account Settings
2018-10-08 13:59:04 +01:00
Simon Detheridge 9c189303c1 Merge pull request #1002 from sharelatex/spd-email-cta-links
Add additional CTA link to emails
2018-10-08 13:56:21 +01:00
Simon Detheridge af9c9517f3 Merge pull request #999 from sharelatex/as-validate-password-length
Validate password length
2018-10-08 13:55:25 +01:00
Jessica Lawshe b78f362c53 Merge pull request #1000 from sharelatex/jel-meta-img-src
Handle image_src in metadata layout
2018-10-08 11:44:10 +01:00
Jessica Lawshe 97cf4886ee Merge pull request #994 from sharelatex/jel-templates-clickable-margins
Styling to increase margins for clickable items on templates pages
2018-10-08 11:43:54 +01:00
Jessica Lawshe f04212c96f Merge pull request #995 from sharelatex/ta-remove-confirmed-field
remove unused confirmed field from user model
2018-10-08 11:43:42 +01:00
Alasdair Smith e129172553 Fix ordering of boolean check to be more readable 2018-10-08 11:25:24 +01:00
Jessica Lawshe 8ef7f6c26d Adjust margins to separate clickable items on templates 2018-10-08 11:09:06 +01:00
Alasdair Smith f26f30e677 Fix spaces instead of tabs 2018-10-08 10:44:26 +01:00
Alasdair Smith 04572f61bb Fix copy/paste error 2018-10-08 10:44:26 +01:00
Alasdair Smith e37a54e254 Make error message match other styles 2018-10-08 10:44:26 +01:00
Alasdair Smith 8777b0f5f8 Style error message after moving it above inputs 2018-10-08 10:44:26 +01:00
Alasdair Smith af499e4539 Style error message on register form 2018-10-08 10:44:26 +01:00
Alasdair Smith 2edca417b1 Reduce padding 2018-10-08 10:44:25 +01:00
Alasdair Smith 1ef947b1fe Fix tests after refactoring register validation 2018-10-08 10:44:25 +01:00
Alasdair Smith 676557a051 Refactor to validate in AuthenticationManager 2018-10-08 10:44:25 +01:00
Alasdair Smith 44c86b3769 Refactor to use password strength options 2018-10-08 10:44:25 +01:00
Alasdair Smith 1fe8aebf5b Add error handling for 400 responses 2018-10-08 10:44:25 +01:00
Alasdair Smith bf60fe7f6c Add error handling for InvalidError 2018-10-08 10:44:25 +01:00
Alasdair Smith e99165b475 Validate password length when registering 2018-10-08 10:44:25 +01:00
Hugh O'Brien cc962c3e6f Merge pull request #978 from sharelatex/hb-use-exports-for-pdf-from-publish-modal
Generic Zip or Pdf Exports endpoint
2018-10-08 10:13:18 +01:00
Tim Alby c00a0a435d remove console.log in tests 2018-10-05 16:24:28 +01:00
Tim Alby 7b4b75b51a fix incorrect or missing test mocks 2018-10-05 16:24:05 +01:00
Simon Detheridge 286f25529a Remove secondary CTA link from account merge confirmation email
bug: sharelatex/web-sharelatex-internal#987
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-05 13:19:05 +01:00
Simon Detheridge d316a76106 Revert "add plain text link to email address confirmation emails"
This reverts commit 48cd7e604dcc5f3b7ae8eb699f14b44bc073f107.
2018-10-05 13:16:42 +01:00
Simon Detheridge a2ef0e1ae5 Add additional CTA link to emails
Some mail clients don't show the CTA button correctly, or at all. Add an additional, smaller link to the bottom of the email for people who can't see the button.

bug: sharelatex/web-sharelatex-internal#987
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-05 12:04:00 +01:00