Commit Graph

7840 Commits

Author SHA1 Message Date
Simon Detheridge 32149e652f Handle 'invalid element name' error in project list ui
When invalid filenames are found during project-copy, the somewhat obscure (and non-localised) 'invalid element name' error is returned. Add a special case to handle this particular error and display something more descriptive to the user.

Added a modal error handler for when this error is generated by clicking the 'copy' icon in the project list, instead of using the 'more' dropdown which opens a modal copy dialog

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-09 17:23:43 +01:00
Simon Detheridge 56dcbefb5b Check for safe paths in all ProjectEntityHandler methods
Some import mechanisms (for example, Github project import) call methods such as 'upsert*' directly, bypassing existing filename checks.

Added checks to all methods in ProjectEntityHandler that can create or rename a file.

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-08 15:31:04 +01:00
Simon Detheridge e66210d2af Add method to sanitize full paths
For convenience, add a method to SafePath to break a path into components and verify the status of each one.

bug: overleaf/sharelatex#908
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-08 14:48:17 +01:00
Simon Detheridge 50993f59c0 Merge pull request #926 from sharelatex/dcl-i850
Display password change form in Account Settings
2018-10-08 13:59:04 +01:00
Simon Detheridge 9c189303c1 Merge pull request #1002 from sharelatex/spd-email-cta-links
Add additional CTA link to emails
2018-10-08 13:56:21 +01:00
Simon Detheridge af9c9517f3 Merge pull request #999 from sharelatex/as-validate-password-length
Validate password length
2018-10-08 13:55:25 +01:00
Jessica Lawshe b78f362c53 Merge pull request #1000 from sharelatex/jel-meta-img-src
Handle image_src in metadata layout
2018-10-08 11:44:10 +01:00
Jessica Lawshe 97cf4886ee Merge pull request #994 from sharelatex/jel-templates-clickable-margins
Styling to increase margins for clickable items on templates pages
2018-10-08 11:43:54 +01:00
Jessica Lawshe f04212c96f Merge pull request #995 from sharelatex/ta-remove-confirmed-field
remove unused confirmed field from user model
2018-10-08 11:43:42 +01:00
Alasdair Smith e129172553 Fix ordering of boolean check to be more readable 2018-10-08 11:25:24 +01:00
Jessica Lawshe 8ef7f6c26d Adjust margins to separate clickable items on templates 2018-10-08 11:09:06 +01:00
Alasdair Smith f26f30e677 Fix spaces instead of tabs 2018-10-08 10:44:26 +01:00
Alasdair Smith 04572f61bb Fix copy/paste error 2018-10-08 10:44:26 +01:00
Alasdair Smith e37a54e254 Make error message match other styles 2018-10-08 10:44:26 +01:00
Alasdair Smith 8777b0f5f8 Style error message after moving it above inputs 2018-10-08 10:44:26 +01:00
Alasdair Smith af499e4539 Style error message on register form 2018-10-08 10:44:26 +01:00
Alasdair Smith 2edca417b1 Reduce padding 2018-10-08 10:44:25 +01:00
Alasdair Smith 1ef947b1fe Fix tests after refactoring register validation 2018-10-08 10:44:25 +01:00
Alasdair Smith 676557a051 Refactor to validate in AuthenticationManager 2018-10-08 10:44:25 +01:00
Alasdair Smith 44c86b3769 Refactor to use password strength options 2018-10-08 10:44:25 +01:00
Alasdair Smith 1fe8aebf5b Add error handling for 400 responses 2018-10-08 10:44:25 +01:00
Alasdair Smith bf60fe7f6c Add error handling for InvalidError 2018-10-08 10:44:25 +01:00
Alasdair Smith e99165b475 Validate password length when registering 2018-10-08 10:44:25 +01:00
Hugh O'Brien cc962c3e6f Merge pull request #978 from sharelatex/hb-use-exports-for-pdf-from-publish-modal
Generic Zip or Pdf Exports endpoint
2018-10-08 10:13:18 +01:00
Simon Detheridge 286f25529a Remove secondary CTA link from account merge confirmation email
bug: sharelatex/web-sharelatex-internal#987
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-05 13:19:05 +01:00
Simon Detheridge d316a76106 Revert "add plain text link to email address confirmation emails"
This reverts commit 48cd7e604dcc5f3b7ae8eb699f14b44bc073f107.
2018-10-05 13:16:42 +01:00
Simon Detheridge a2ef0e1ae5 Add additional CTA link to emails
Some mail clients don't show the CTA button correctly, or at all. Add an additional, smaller link to the bottom of the email for people who can't see the button.

bug: sharelatex/web-sharelatex-internal#987
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-05 12:04:00 +01:00
Jessica Lawshe 6692d06e5f Handle image_src in metadata layout
The CMS is already using `image`, which is an object based on data from the API.
2018-10-05 11:06:21 +01:00
Shane Kilkelly 4c2a90966a Merge pull request #918 from sharelatex/sk-enable-sudo-mode-in-v2
Enable sudo-mode for v2
2018-10-05 10:05:24 +01:00
Shane Kilkelly 453b5fbd71 Merge pull request #1001 from sharelatex/spd-v1-template-compiler
Lookup correct compiler when importing v1 templates
2018-10-05 10:05:13 +01:00
Simon Detheridge 2b8ce379f8 Lookup correct compiler when importing v1 templates
bug: overleaf/sharelatex#981
Signed-off-by: Simon Detheridge <s@sd.ai>
2018-10-04 16:42:03 +01:00
Shane Kilkelly 2c47da553b Add an error log if activating sudo-mode on login fails 2018-10-04 15:05:40 +01:00
Shane Kilkelly 778abaff6e Remove stray log 2018-10-04 15:05:40 +01:00
Shane Kilkelly 70b56d0362 Fix up acceptance tests 2018-10-04 15:05:40 +01:00
Shane Kilkelly 2ef23194df WIP: trying to get acceptance tests to pass 2018-10-04 15:05:40 +01:00
Shane Kilkelly f9ed367148 Move the auth mechanism for sudo-mode into SudoModeHandler 2018-10-04 15:05:40 +01:00
Shane Kilkelly 254d74899b WIP: enable sudo-mode for v2 2018-10-04 15:05:40 +01:00
Chrystal Maria Griffiths 6b8eb0ac23 Merge pull request #996 from sharelatex/jel-meta-img
Update default meta images
2018-10-04 15:01:19 +01:00
Chrystal Maria Griffiths e932eb074b Merge pull request #992 from sharelatex/as-fix-mathjax
Fix mathjax incorrectly loading config
2018-10-04 15:01:05 +01:00
Chrystal Maria Griffiths 5f5c9a1efc Merge pull request #997 from sharelatex/cmg-meta-title
Fix the meta title including 'ShareLaTeX'
2018-10-04 15:00:30 +01:00
Chrystal Griffiths 2f41e84f9a Merge branch 'cmg-meta-title' of github.com:sharelatex/web-sharelatex-internal into cmg-meta-title 2018-10-04 09:58:28 +01:00
Chrystal Griffiths 13843f82a0 Use settings appName 2018-10-04 09:57:51 +01:00
Jessica Lawshe bbe847c16d Update default meta images
Favicons are not picked up by social sites.
2018-10-03 17:34:40 +01:00
Chrystal Griffiths a979202a7c Use settings appName 2018-10-03 16:40:32 +01:00
Tim Alby 5ff66187a0 remove unused confirmed field from user model 2018-10-03 16:01:30 +01:00
Ersun Warncke 752658f773 Merge pull request #990 from sharelatex/ew-use-v1-doc-info-api
Use v1 Doc Info API for Token Access
2018-10-03 09:22:41 -04:00
Timothée Alby e3cfa36b56 Merge pull request #984 from sharelatex/ta-email-cta-link
add plain text link to email address confirmation emails
2018-10-03 14:20:05 +01:00
Timothée Alby c74c782cee Merge pull request #961 from sharelatex/ta-account-sync-affiliations
Add getInstitutionsPlan Function
2018-10-03 14:19:56 +01:00
Alasdair Smith fb8ed890f9 Correctly load Safe mathjax extention using provided config 2018-10-03 11:52:33 +01:00
Brian Gough ecdd00ecb9 Merge pull request #980 from sharelatex/jel-viewport-metatag
Add viewport metatag
2018-10-03 10:10:22 +01:00