roo hutton
46db29897c
[web] Pending invite prevents Viewer being changed to Editor ( #19214 )
...
* only count editor invites when disabling editor in dropdown
GitOrigin-RevId: 400215d4817c0146da4f8397fe2007699da0e92b
2024-07-02 08:04:36 +00:00
Thomas
55e75edc58
Merge pull request #19194 from overleaf/rh-read-only-invite-limit
...
[web] Allow read-only invite when over collaborator limit
GitOrigin-RevId: 96783910b63aca3f282d7c26a412b56336246c64
2024-07-02 08:04:31 +00:00
Thomas
f8bfefc340
Merge pull request #19206 from overleaf/tm-link-sharing-changes-events
...
Implement link sharing warning events by reusing the StartFreeTrial paywall button component from the original modal
GitOrigin-RevId: 9c16407ad8a7b5afc9b5b13be1491ef903ae74a3
2024-07-02 08:04:25 +00:00
CloudBuild
82d6591eda
auto update translation
...
GitOrigin-RevId: 203a406f8c9ae57dfbad182869f8551579865133
2024-07-01 08:04:33 +00:00
CloudBuild
c4b9c5bcbb
auto update translation
...
GitOrigin-RevId: dad4976c9f542cf7a9546355e7d85c3e19503676
2024-07-01 08:04:29 +00:00
Eric Mc Sween
86508f78b2
Fix history diffs when deleting over many tracked deletes ( #19193 )
...
* Fix history diffs when deleting over many tracked deletes
As we are looping through tracked deletes, the offset between the result
positions and the source positions must be kept constant. Otherwise, the
tracked deletes are translated as we delete text and move the source
cursor.
GitOrigin-RevId: b2417a75219aaa16bf5c61e0ebcb0586cae6aef2
2024-07-01 08:04:25 +00:00
Thomas
f430f1392f
Merge pull request #19185 from overleaf/tm-validate-can-invite-editor-2
...
Update inviteToProject to check if editor slots are available
GitOrigin-RevId: bb67ae6329130573ba43e9524a3084bf5551ebde
2024-07-01 08:04:21 +00:00
Thomas
60fce4207b
Add serverside checks for changing the user access level after link sharing changes ( #19168 )
...
* Add getEditInviteCount to count only edit collaborators
* Add getInvitedEditCollaboratorCount to count joined editors
* Add canAddXEditCollaborators to determine if owner can add more editors
* Update setCollaboratorInfo to check if editor slots are available
GitOrigin-RevId: a88707f102dfbde39322f5a7bbc79d47b6e810d5
2024-07-01 08:04:16 +00:00
Thomas
99f06f1aab
Async/awaitify LimitationsManager for link sharing changes ( #19110 )
...
* Move functions to top level
* Async/awaitify LimitationsManager methods
* Promisify LimitationsManagerTests
GitOrigin-RevId: ece7d2ea5160aa95924840044e2f225e1f2848e7
2024-07-01 08:04:12 +00:00
ilkin-overleaf
0977718624
Merge pull request #19141 from overleaf/ii-add-email-account-settings
...
[web] Reset recaptcha every time
GitOrigin-RevId: 6db3571ad6dad3611c748a2d92dce47002a16a77
2024-07-01 08:04:07 +00:00
roo hutton
8818047d44
Merge pull request #19181 from overleaf/rh-share-modal-collab-view
...
[web] Styling tweaks in new share modal
GitOrigin-RevId: 2b69612aff518ae0cb4f08851adc73971e5ac983
2024-06-28 08:05:13 +00:00
roo hutton
8b92667717
Merge pull request #18891 from overleaf/rh-share-modal-when-over-limit
...
[web]: Show share modal when over collaborator limit
GitOrigin-RevId: 6f5594310f21e481d5837ff8d7f098668ecd2957
2024-06-28 08:05:09 +00:00
Eric Mc Sween
8c8565fbb8
Merge pull request #19192 from overleaf/em-project-history-avoid-crash
...
Prevent project-history crashes when generating a diff
GitOrigin-RevId: 513fb846f0884a68d4550783497ae436e1cba00f
2024-06-28 08:05:05 +00:00
Jimmy Domagala-Tang
17a116683a
Merge pull request #19108 from overleaf/jdt-ai-rm-alpha-reqs
...
Remove Alpha bypass for AI Error Correction
GitOrigin-RevId: d6b93bc2071dbeeb3d67d48197e61abf4d920944
2024-06-28 08:04:57 +00:00
roo hutton
e0f9beafcf
Merge pull request #18910 from overleaf/rh-editor-warning-over-limit
...
[web] Show warning modal to editors opening a project over collaborator limit
GitOrigin-RevId: d9868c021d0aaf04bffd8afbd8c1c96fbf548755
2024-06-28 08:04:53 +00:00
Domagoj Kriskovic
95063712c0
[web] Rename "Revert file" to "Restore this version" ( #19069 )
...
* rename revert file to restore file
* rename file/function name
* rename split test
* fix formatting
* do not rename split test name
* fix typo
GitOrigin-RevId: e4e2eae622a270b3b6483348f441ddd424623f81
2024-06-28 08:04:49 +00:00
Domagoj Kriskovic
2a90764ac8
[web] return file type in revertFile ( #18995 )
...
* [web] return file type in revertFile
* fix revertFile unit test
* fix formatting
GitOrigin-RevId: e4ac0500ff6c72c7f7fa23a5f61b09ed31a28da0
2024-06-28 08:04:45 +00:00
Miguel Serrano
3a40400385
Merge pull request #19178 from overleaf/msm-frog-test-reliability
...
[CE] make JPG rendering test more robust
GitOrigin-RevId: f0f6b0119ed59e7f3fa8af70d69915a4d9ccda3f
2024-06-28 08:04:41 +00:00
Jakob Ackermann
6453867083
Merge pull request #19170 from overleaf/jpa-server-ce-re-run-before
...
[server-ce] make tests more robust
GitOrigin-RevId: f070b8bbbf87842a69d88ca56cecf5dd0f3a286c
2024-06-28 08:04:33 +00:00
Antoine Clausse
3a488e39d5
Add waitForDb in scripts/resync_subscriptions.js ( #19154 )
...
GitOrigin-RevId: 608bce2654d2b6dbeb662ad0da8bb5c5ce3d68f3
2024-06-28 08:04:29 +00:00
Antoine Clausse and Jakob Ackermann
8e7830f380
Add some JSDoc types to @overleaf/logger ( #19153 )
...
* Add some JSDoc types to `@overleaf/logger`
* Update `logger.error` calls
* Fixup `logger.err` JSDoc
* Update `logger.err` calls
* Fix `args` type
* Remove "Error message" description
* Replace `arguments` by actual arguments of the method
* Fix: "ESLint: Unnecessary '.apply()'.(no-useless-call)"
* Add JSDoc params to `debug` `info` `warn`
* Remove extra `args` param in JSDoc so developers aren't invited to use it
Not sure if this is the best thing to do because it creates a warning in the IDE: "Parameter args is not described in JSDoc"
* Add comment about serialization of `err` `req` `res`
* Allow strings as first param in `debug` `info` `warn`
* Fix syntax for optional parameters in JSDoc
* Add 2 signatures, to avoid "string, string" params
* Fix `@signature` names copy-pastes
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Revert the double `@param attributes`. It doesn't work
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
GitOrigin-RevId: 086dee8bbf30d577c5e1f844a9df5e518c46aca7
2024-06-28 08:04:25 +00:00
Antoine Clausse
cadbfeefee
[web] Promisify TemplatesController ( #18849 )
...
* Promisify TemplatesController
* Update TemplatesControllerTests
* Fix `templateVersionId` in `getV1Template` (!!)
GitOrigin-RevId: bdaa59ed3cff81d919a8b3d19d5be555a2790f55
2024-06-28 08:04:17 +00:00
Jakob Ackermann
3682a8e1b7
Merge pull request #19165 from overleaf/jpa-test-history-download
...
[server-ce] add tests for downloading a project zip from the history
GitOrigin-RevId: 95b0047e7d4cce7f6708d116bf2065d634a76ae4
2024-06-27 08:05:01 +00:00
Jessica Lawshe
207fd5ea66
Merge pull request #19085 from overleaf/jel-light-touch-table-updates
...
[web] Update background color CSS for light touch redesign
GitOrigin-RevId: 574f813a9964a272742507817732c1b45bbdc2fe
2024-06-27 08:04:56 +00:00
Jessica Lawshe
3da3f2ed7b
Merge pull request #19084 from overleaf/jel-light-touch-rename-css
...
[web] Rename CSS variables for light touch redesign
GitOrigin-RevId: c84eb75a45af8270895795ceffef944696037881
2024-06-27 08:04:52 +00:00
Jessica Lawshe
20b7f96518
Merge pull request #18961 from overleaf/jel-new-plans-spacing
...
[web] Update main container spacing for new plans page
GitOrigin-RevId: b6c8fa852ba2025c78f6daa22146854fc6a13789
2024-06-27 08:04:48 +00:00
Jessica Lawshe
7305be4df3
Merge pull request #18959 from overleaf/jel-faq-tabs
...
[web] New tab and accordion more reusable
GitOrigin-RevId: ed8340bc4b6312c4270edf1edf53c74a067aaccf
2024-06-27 08:04:44 +00:00
Jimmy Domagala-Tang
bc184535fe
Merge pull request #19162 from overleaf/jpa-flaky-admin-test
...
[web] refresh system message cache after creating/deleting message
GitOrigin-RevId: f7155e94a8bf08b527e7ae69d9d6a41e54c01282
2024-06-27 08:04:39 +00:00
Jimmy Domagala-Tang
b33cb2ccf3
Merge pull request #19128 from overleaf/jdt-latex-2024-release
...
updating to remove alpha only and release 2024 latex
GitOrigin-RevId: 4333b5d4331213206d273a6cbb0cb790ad2778f6
2024-06-27 08:04:35 +00:00
Mathias Jakobsen
f4a93557d4
Merge pull request #19158 from overleaf/mj-commands-autocomplete-optional-args
...
[web] Avoid double counting optional arguments for autocomplete
GitOrigin-RevId: 7abdc73657791b945bd5a7a9e29f5cd127c7882b
2024-06-27 08:04:31 +00:00
David
a1127fa0c0
Merge pull request #19124 from overleaf/dp-light-hover-bug
...
Refactor pdf toolbar button styles to fix bug with hovering over active logs button
GitOrigin-RevId: f8034c9daade32cda7c4f08ccd292c86ef6b8454
2024-06-27 08:04:27 +00:00
David
d4369e8f51
Merge pull request #19064 from overleaf/dp-create-project-dropdown-ui
...
Add spacing above create-new-project-dropdown and make thinner
GitOrigin-RevId: a1f3a27512e04ec6e4383493d5ceaf39e5ad9eee
2024-06-27 08:04:22 +00:00
Jakob Ackermann
54b828c09b
Merge pull request #19160 from overleaf/jpa-jammy-1-0-4
...
[server-ce] bump base image to jammy-1.0.4
GitOrigin-RevId: 79cc27e4c628e50fb226a32278be1768001f343b
2024-06-26 11:12:47 +00:00
Thomas
f9edf0c546
Add new interstitial 'Join project' consent page for existing link sharing editors when opening a project ( #19066 )
...
* Add helpers for checking and removing user readwrite token membership
* Add sharing-updates page and handlers
* Redirect read write token members to sharing-updates on project load
GitOrigin-RevId: d552a2cd74a9843c6103923b03f137131a48877a
2024-06-26 11:12:42 +00:00
Thomas
36ffa91698
Add read write token join interstitial variation for link sharing changes ( #19060 )
...
* Add read write join interstitial variation for link sharing changes
GitOrigin-RevId: 41661f43f4ab0f18f6ada5bec0b6af2407f65f07
2024-06-26 11:12:37 +00:00
Thomas
d323f21972
Merge pull request #19109 from overleaf/tm-project-joined-add-project-id
...
Add projectId to project-joined event
GitOrigin-RevId: 222e0acc8764592344e384d1a6a5a2327d4161f5
2024-06-26 11:12:33 +00:00
Mathias Jakobsen
5fba4d60f8
Merge pull request #19157 from overleaf/mj-separate-unknowncommands
...
[lezer] Separate unknown commands for definition fragments
GitOrigin-RevId: 21ce8d03e68f4af13c3937b4b5fd6f7ed0e50995
2024-06-26 11:11:53 +00:00
Mathias Jakobsen
5bcd6c0075
Merge pull request #19119 from overleaf/mj-lezer-definition-unknown-commands
...
[lezer] Parse unknown commands in definitions
GitOrigin-RevId: 586bf9e0de8e1d9e7903dd2fad8638cb2624ed9e
2024-06-26 11:11:48 +00:00
Alf Eaton
6a15a40999
Updates to the AI error assistant ( #19107 )
...
GitOrigin-RevId: 7ffc1e32d331fa8bab1ea25919e706bf8b59800f
2024-06-26 11:11:44 +00:00
Alf Eaton
f1a05933cb
Replace symbol palette tabs with a custom tablist ( #19034 )
...
GitOrigin-RevId: 69d8a8dd8980e287b484b915b1f92e57af5324cb
2024-06-26 11:11:35 +00:00
Antoine Clausse and Jakob Ackermann
52ad6dbddd
Fix institution metrics sendAll cron ( #19127 )
...
* Don't send status 200 in the beginning: we may throw later
This was causing `Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client`
https://cloudlogging.app.goo.gl/Bchegw2iCYLxhPNk8
* Continue when failing to send one email, but log the error
* Revert "Don't send status 200...", log error instead
This reverts commit 3e13559704f822e330a18a68567f46491649f222.
* Fix `logger.error` params
* Fixup: good syntax for `logger.error`
* Remove useless `OError` import
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Update services/web/scripts/recurly/collect_paypal_past_due_invoice.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
GitOrigin-RevId: c68bc677326729fc6c39b7c2f027e35ebb776bd2
2024-06-26 08:05:11 +00:00
Antoine Clausse
0522268e96
[web] Promisify two-factor-authentication ( #19004 )
...
* Fixup typos
* Promisify `getPendingUser`
* Promisify `getPendingUserWithExpectations`
* Add promises to `AccessTokenEncryptor`
* Promisify `TwoFactorAuthenticationHandler`
* Promisify/Expressify `TwoFactorAuthenticationController`
* Centralise `unprocessableEntity` error handling into a function
* Fixup: entralise `unprocessableEntity` error handling into a function
Avoid "responding to the query twice"
* Remove unnecessary try/catch
* Fixup: Add `async` to AccessTokenEncryptor promises
* Add tests on `AccessTokenEncryptor.promises`
* Revert "Fixup: entralise `unprocessableEntity` error handling into a function"
This reverts commit 23bd9d73260733062908b98961846733c61171e9.
* Revert "Centralise `unprocessableEntity` error handling into a function"
This reverts commit 197ca3da02412d5224d411b29df1d7b9e5327d01.
GitOrigin-RevId: 1a2864d28e87fd5e48cd3723a3da8047b79a1596
2024-06-26 08:05:06 +00:00
CloudBuild
a3379e8c27
auto update translation
...
GitOrigin-RevId: c597b7ebda7a250220e7227211d7f3cd64816b90
2024-06-26 08:05:02 +00:00
Jimmy Domagala-Tang
5e75289cd4
Merge pull request #18850 from overleaf/ac-promisify-resync-subscriptions
...
Promisify resync_subscriptions
GitOrigin-RevId: c23a99683a22104815525b179d4e46d3ad568f94
2024-06-26 08:04:57 +00:00
Jimmy Domagala-Tang
81beeb3ff6
Merge pull request #19106 from overleaf/jdt-center-labels
...
vertically align text within spans
GitOrigin-RevId: 820313b179751a1a7c538712cf9dfd6b9ce0ff3d
2024-06-26 08:04:52 +00:00
Jimmy Domagala-Tang
42a5a3def4
Merge pull request #19132 from overleaf/jdt-ai-policy-migration
...
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
2024-06-26 08:04:48 +00:00
roo hutton
dd9df6d7d3
Merge pull request #19120 from overleaf/rh-link-share-styles
...
[web] Fix share modal styling regressions
GitOrigin-RevId: efeffa3d6451ed47137106e0ad296c518a5c0608
2024-06-26 08:04:43 +00:00
roo hutton
95eacb21b5
Merge pull request #18936 from overleaf/rh-viewer-no-comment
...
[web] Remove access to commenting/chat for collaborators with Viewer permission
GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
2024-06-26 08:04:38 +00:00
Jakob Ackermann
5cabb3fa74
Merge pull request #19098 from overleaf/jpa-graceful-shutdown-tests
...
[server-ce] add test for graceful shutdown
GitOrigin-RevId: 5e72e0073169009d2e3ece5a79cbd62051f6ad5b
2024-06-25 11:12:43 +00:00
Tim Down
c11219150b
Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag
...
Create new feature flag for BS5 project dashboard page
GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
2024-06-25 11:12:35 +00:00