062b2d57f8
Merge pull request #24137 from overleaf/mj-ide-permissions-utils
...
[web] Add switcher for editor redesign
GitOrigin-RevId: 806a1f567027df53f879b564a50aaae9166c8480
2025-03-18 09:05:40 +00:00
3a98940324
[web] switch query for hard-deleting users and add index ( #22920 )
...
* [web] switch query for hard-deleting users and add index
Co-authored-by: Dr. Sasha Göbbels <sasha.goebbels@overleaf.com >
* [web] fix unit tests
---------
Co-authored-by: Dr. Sasha Göbbels <sasha.goebbels@overleaf.com >
GitOrigin-RevId: a7fd2a590351d2e0d60c0032ca78d457ef815e41
2025-03-11 09:05:04 +00:00
85958774dc
[web] Use 6-digits code to confirm existing email in Account Settings ( #23931 )
...
* Rename `checkSecondaryEmailConfirmationCode` to `checkAddSecondaryEmailConfirmationCode`
* Create function `sendCodeAndStoreInSession`
* Create function `sendExistingSecondaryEmailConfirmationCode`
* Create function `_checkConfirmationCode`
* Create function `checkExistingEmailConfirmationCode`
* Rename `resendSecondaryEmailConfirmationCode` to `resendAddSecondaryEmailConfirmationCode`
* Create function `_resendConfirmationCode`
* Create function `resendExistingSecondaryEmailConfirmationCode`
* Add `ResendConfirmationCodeModal`
* Remove `ResendConfirmationEmailButton`
* `bin/run web npm run extract-translations`
* Update frontend test
* Fix: don't throw on render when send-confirmation-code fails!
* Update phrasing in the UI
Per https://docs.google.com/document/d/1PE1vlZWQN--PjmXpyHR9rV2YPd7OIPIsUbnZaHj0cDI/edit?usp=sharing
* Add unit test
* Don't share the "send-confirmation" and "resend-confirmation" rate-limits
* Update frontend test after copy change
* Rename `checkAddSecondaryEmailConfirmationCode` to `checkNewSecondaryEmailConfirmationCode` and `resendAddSecondaryEmailConfirmationCode` to `resendNewSecondaryEmailConfirmationCode`
* Rename `cb` to `beforeConfirmEmail`
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Return `422` on missing session data
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Add `userId` to log
* Replace `isSecondary` param by `welcomeUser`
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Rename `resend-confirm-email-code`'s `existingEmail` to `email`
* Remove "secondary" from rate-limiters
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
* Remove unnecessary `userId` check behind `AuthenticationController.requireLogin()`
* Only open the modal if the code was sent successfully
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com >
GitOrigin-RevId: df892064641d9f722785699777383b2d863124e1
2025-03-07 09:06:50 +00:00
57603c09b6
Merge pull request #23690 from overleaf/jel-test
...
[web] Remove test skip
GitOrigin-RevId: bd5a35bcb62227a7bc282bb0813ac0482b04ada2
2025-02-27 09:05:51 +00:00
747609c5d7
Merge pull request #23299 from overleaf/jel-admin-saml-ids
...
[web] Show SAML IDs in user audit logs and user info page
GitOrigin-RevId: b8baa44c3110764e466d92ad2b0dc54ddc8f7819
2025-02-27 09:05:47 +00:00
d562c56e07
Merge pull request #23890 from overleaf/jel-reconfirm-date
...
[web] If v1 date doesn't show as reconfirmed, ensure v2 does not as well
GitOrigin-RevId: dc2850221a2d9176023380b38508311ea98abe43
2025-02-27 09:05:27 +00:00
0d05cef327
[web] When switching primary email, delete the old primary if it's unconfirmed ( #23688 )
...
* Add note to ConfirmModal: unconfirmed primary will be deleted
* Change confirm button copy
* Promisify `UserEmailsController.setDefault`
* Update tests after promisification
* Delete unconfirmed primary when swapped
* Fixup apostrophe in translation
* `npm run extract-translations`
* Add unit tests
* Add acceptance tests
* Fix frontend tests
* Make email address bold
* Add "We removed the previous primary..." to the email
GitOrigin-RevId: c971e219e36e509f9963e1720acdd44f562a05b5
2025-02-21 09:05:44 +00:00
76301e0cc8
[web] Send security alert email when secondary is added ( #23657 )
...
* [web] Send security alert email when secondary is added
* [web] Add test: checkSecondaryEmailConfirmationCode - sends a security alert email
* Move `_sendSecurityAlertEmail` before `addEmailAddress`
GitOrigin-RevId: 8d9c496fffd953871e03d8c7f011c42459eeb0bc
2025-02-18 09:05:14 +00:00
5dca40eea2
Merge pull request #22646 from overleaf/ar-address-mongo-count-deprecation-warning
...
[web] Switch from find.count to countDocuments
GitOrigin-RevId: cc607868334d54b3d5c375c06fec97a482a16cc5
2025-02-17 09:04:58 +00:00
804bc72957
Skip "should not flag affiliations outside of notification period" test ( #23619 )
...
GitOrigin-RevId: 060158f5b3958577c3c1ebde8490cad2c763da88
2025-02-17 09:04:53 +00:00
9e811eefc5
Merge pull request #22613 from overleaf/mf-migrate-primary-email-check-bs5
...
[web] Migrate "Primary email check" page to bootstrap 5 and website-redesign styling
GitOrigin-RevId: e233edafb8c5033c8fbd97088fa1ac840e2e572e
2025-01-28 09:05:43 +00:00
580ad4bdca
Merge pull request #23026 from overleaf/mj-wc-settings-second-try
...
[web] Move write and cite setting storage
GitOrigin-RevId: 88a234c15b4dd2a9b451170e3b474d88bb6d45f7
2025-01-24 09:05:22 +00:00
01fb8ba69f
[web] Promisify ensureAffiliationMiddleware and refactor InstitutionHubsController ( #22242 feedback) ( #22261 )
...
* Promisify `ensureAffiliationMiddleware`
* In `ensureAffiliationMiddleware`, throw when UserNotFoundError
* Unnest object `_InstitutionHubsController`
* Format fix
GitOrigin-RevId: 5b3c6c24724520353540b8d8dd05005b6fa749ff
2025-01-21 09:04:57 +00:00
5ba9a7238d
[web] Remove promises exports from Controller modules ( #22242 )
...
* Remove promises object from CollaboratorsInviteController.mjs
* Define functions at root
* Remove mentions of undefined `revokeInviteForUser`
* Remove unused `doLogout`
* Remove promises object from UserController.js
* Remove unused `makeChangePreview`
* Remove promises object from SubscriptionController.js (`getRecommendedCurrency` and `getLatamCountryBannerDetails`)
* Remove promises object from CollabratecController.mjs
* Remove promises object from SSOController.mjs
* Remove promises object from ReferencesApiController.mjs
* Remove promises object from MetricsEmailController.mjs
* Remove promises object from InstitutionHubsController.mjs
* Remove promises object from DocumentUpdaterController.mjs
* Remove promises object from SubscriptionAdminController.mjs
* Fixup unit tests
* Add expects that controllers don't error
* Promisify `ensureAffiliationMiddleware`
GitOrigin-RevId: 311c8afa7d5c8e4f051408d305b6b4147a020edc
2025-01-17 09:05:36 +00:00
e6ceb314cb
Merge pull request #22321 from overleaf/msm-force-flag-delete-user
...
[web] Fix user deletion in CE/SP when email does not exist
GitOrigin-RevId: 051f822318d63c8a9f50d5e9aeca095f3b37efb4
2025-01-10 09:05:48 +00:00
3f6aa2369d
Merge pull request #21031 from overleaf/msm-clean-collabratec-tokens
...
[web] cleanup collabratec tokens
GitOrigin-RevId: 0ad73ca5d4c4c82d79e2ec7119c5b77a83b7086f
2025-01-09 09:05:15 +00:00
c74a3b3437
Merge pull request #22433 from overleaf/tm-suspend-users-script
...
Add script for bulk account suspension
GitOrigin-RevId: 434ac819c12a2a33c26baf963d8d8874b1864928
2024-12-11 09:04:40 +00:00
cd160132c2
Merge pull request #22204 from overleaf/mj-papers-linking
...
[web+third-party-references] Add linking to papers account
GitOrigin-RevId: dbf6a01b16ae661558da01549922294278dbda70
2024-12-04 09:04:47 +00:00
46e22c2021
Update tests
...
GitOrigin-RevId: 9272720e0f6865c54257c43bd98d8e6003251aa2
2024-10-17 08:06:17 +00:00
7c7f60d7a6
Merge pull request #20756 from overleaf/jpa-clear-admin-sessions
...
[web] add script for clearing admin sessions
GitOrigin-RevId: c5103b233073db62276698067b2262d7a785592b
2024-10-14 10:58:12 +00:00
25cd0354f7
[web] Expose metric for active users in SP ( #20130 )
...
* [web] Expose metric for active users in SP
* Removed redundant UserHandler.setupLoginData()
In the past this method was also calling
a now deleted notifyDomainLicence(), but now
this is just an alias for populateTeamInvites()
* Added migration for `lastActive`
* Added secondary read precedence to count active users
GitOrigin-RevId: 86d6db31e1ae74ae40c6599e6acb731d8c4a04bd
2024-10-14 10:57:28 +00:00
b00d1336d4
Switch to mongodb-legacy
...
GitOrigin-RevId: 11e09528c153de6b7766d18c3c90d94962190371
2024-08-21 08:04:24 +00:00
e2888cd2bb
Merge pull request #19861 from overleaf/ab-overleaf-integration-delete-flow
...
[web] Remove /user/delete override from overleaf-integration
GitOrigin-RevId: 4f679f6835522c2325fe7b0368f58e7a952ee73d
2024-08-14 08:05:30 +00:00
62e1177800
[web] Remove overleaf-integration overrides for /user/emails/delete & /user/emails/resend_confirmation ( #19438 )
...
* Use hooks to call `clearSamlSession`
* Promisify `UserEmailsController.remove`
* Use hook for `userDeleteEmailMiddleware`
* Remove `/user/emails/delete` override
* Remove "removeRoute of `/user/emails/resend-secondary-confirmation`"
That route isn't defined elsewhere
* Promisify `UserEmailsController.resendConfirmation`
* Promisify `UserEmailsController.sendReconfirmation`
* Use hook for `resendConfirmationEmailMiddleware`
* Remove `/user/emails/resend_confirmation` override
* Promisify `tryDeleteUser`
* Proxy `clearSamlSession` through `SAMLHelper`
* Revert "Use hook for `resendConfirmationEmailMiddleware`"
This reverts commit f028d9c8
* Inject `SAMLMiddleware.resendConfirmationEmailMiddleware` in `/user/emails/resend_confirmation`
* Update `middleware` syntax and grammar
* Update tests
* Use Module middleware instead of hook for `userDeleteEmailMiddleware`
* Remove "promises" export of tryDeleteUser
GitOrigin-RevId: 211e194fc1ef82dc452ee4e837dcddd9b23690a0
2024-07-29 08:04:24 +00:00
90388a4e5b
Merge pull request #19105 from overleaf/bg-cookie-session-fix-user-deleter-unit-tests
...
fix UserDeleteTests to restore time operations
GitOrigin-RevId: 85c91697e05b6a12aa66a6524a74848ff281527b
2024-07-04 08:05:43 +00:00
9efae1f958
Merge pull request #18320 from overleaf/dp-add-secondary-prompt-ui
...
Add secondary email form V2 (with Captcha this time)
GitOrigin-RevId: b06216a2c9cb5b3b09305a17992eca506a0047f5
2024-05-27 10:22:40 +00:00
01e2a29766
Merge pull request #18225 from overleaf/em-typescript-eslint
...
Add typescript-eslint rule: no-floating-promises
GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
93f3f52c31
[web] Simplify removeSessionsFromRedis signature ( #18440 )
...
* Simplify `removeSessionsFromRedis` signature
* Update usage of `removeSessionsFromRedis`
* Fix tests around `removeSessionsFromRedis`
* Add comments "remove all sessions except the current session"
GitOrigin-RevId: 03bf99c14faf2c8e403bc4bcc16463a70e031284
2024-05-27 10:21:30 +00:00
7fae1cbb2c
[web] Update revokeAllUserSessions and rename it to removeSessionsFromRedis ( #18360 )
...
* Fix `revokeAllUserSessions` call in `_cleanupUser`
The user object should be passed, not the _id
* Change `revokeAllUserSessions` signature, take `req` and `stayLoggedIn` arguments
* Update uses of `revokeAllUserSessions`
* Fix promisified `revokeAllUserSessions` args
* Update tests
* Destroy or Regenerate the session in the end of `revokeAllUserSessions`
Per https://github.com/overleaf/internal/issues/17036#issuecomment-1938398570
* Revert "Destroy or Regenerate the session in the end of `revokeAllUserSessions`"
This reverts commit fe30734dbe45b27d2931d2e43a711d591bb85787.
* Rename `revokeAllUserSessions` to `removeSessionsFromRedis`
* Fixup tests
* Fix: add optional chaining in `req.sessionID` (!!)
GitOrigin-RevId: d41676bf00f463230af495e09c65fb9ee521f49f
2024-05-20 08:04:12 +00:00
d8055e6749
Merge pull request #18294 from overleaf/jpa-td-invite-details
...
[web] avoid content reflection via query parameter on register page
GitOrigin-RevId: 43e7ba6069e0d9f3f12e5e9e680b5960b0673782
2024-05-16 08:05:09 +00:00
0d08fc1df2
Merge pull request #18318 from overleaf/dp-revert-secondary-email
...
Revert "Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui"
GitOrigin-RevId: d8af37a5c332ac21ddd4c85679553df0bda326f9
2024-05-14 08:04:11 +00:00
7e48f4e38a
Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui
...
Add UI for secondary email prompt
GitOrigin-RevId: 887b2c7f0047f19b605f03745f7dda83926ec70b
2024-05-14 08:04:01 +00:00
8f9577da5c
Merge pull request #17947 from overleaf/dp-secondary-email-confirmation-code
...
Add endpoints for secondary email confirmation by code
GitOrigin-RevId: c2829672fd9aeca457f76958d4922b9c95086f26
2024-04-26 08:04:00 +00:00
14c33ed3aa
Merge pull request #18045 from overleaf/jel-user-settings-sso-groups
...
[web] Use `getUserGroupsSSOEnrollmentStatus` helper
GitOrigin-RevId: 4846d513964a63afb620ee2dbb5b810dd0aa4e60
2024-04-25 08:05:22 +00:00
1f6afacce5
Merge pull request #18011 from overleaf/dp-make-_getRedirectFromSession-public
...
Make _getRedirectFromSession a public method
GitOrigin-RevId: 6538e4ec25e607d32beb944370d151d4f1a3709c
2024-04-24 08:04:13 +00:00
5446d2ca56
Merge pull request #17946 from overleaf/rh-promisify-third-party-identity-
...
[web] Promisify ThirdPartyIdentityManager and ThirdPartyIdentityManagerTests
GitOrigin-RevId: f7d24f73213fb0a43eb453aa21749b21ba60b83d
2024-04-22 08:04:28 +00:00
07bd66438b
Merge pull request #17810 from overleaf/dp-compormised-password-prompt
...
Add compromised password prompt
GitOrigin-RevId: 7910a220943fcb3aa191da6d514d5bc3ae20f5a3
2024-04-19 08:03:58 +00:00
696dae6371
Merge pull request #17799 from overleaf/ab-account-deletion-audit-log
...
[web] Add audit log when user account is deleted or recovered
GitOrigin-RevId: 3d5f99705fbd6192ccae430e040be4b7fcb3f740
2024-04-15 08:04:42 +00:00
7edf46add4
Merge pull request #17856 from overleaf/rh-deletion-email-update
...
[web] Use securityAlert template for user deletion email
GitOrigin-RevId: 60dfef18946710f5d5df17daca1a0bdc9800519b
2024-04-12 08:06:40 +00:00
3f0ae41f80
Merge pull request #17730 from overleaf/rh-acct-delete-email
...
[web] Send email notification on account deletion
GitOrigin-RevId: 03c0effba0ee3b829f5b4fe377fe67d05776ba3f
2024-04-10 08:04:12 +00:00
207bb852f7
Merge pull request #17572 from overleaf/tm-email-confirmation-require-login
...
Prevent email confirmation unless logged in to the requesting account
GitOrigin-RevId: 28af875b2887b8bbef8327097635aa01345c682c
2024-03-22 09:03:10 +00:00
c689dbfffa
Merge pull request #17315 from overleaf/ab-accounts-settings-sso-status
...
[web] Show Group SSO linking status on the account settings page
GitOrigin-RevId: ae45e1bd7a90a672c5fb023e7f3e603a00e364e5
2024-03-12 09:03:43 +00:00
0769329734
Merge pull request #17268 from overleaf/dp-remove-old-mongo-metrics
...
Remove timeAsyncMethod mongo metrics
GitOrigin-RevId: 1ba3a1fd51b9d0766355c31791ae9836d832afe8
2024-02-29 09:04:19 +00:00
481e012ef0
Merge pull request #17155 from overleaf/dp-mongoose-callback-user-registration-handler
...
Promisify UserRegistrationHandler and UserRegistrationHandlerTests
GitOrigin-RevId: b561f5574883b016824077e971aa4613b44a42dd
2024-02-29 09:04:03 +00:00
4b82bcf48c
Merge pull request #16991 from overleaf/ab-sso-login-url
...
[web] Change /institutional-login URL to /sso-login
GitOrigin-RevId: 0856f3f63e3bba3431dd554b4b65fe913d8a50fe
2024-02-14 09:05:15 +00:00
003182b1da
Merge pull request #16859 from overleaf/jpa-sharelatex-cleanup
...
[misc] ShareLaTeX cleanup - high impact
GitOrigin-RevId: 6dcce9b0f15e30f7afcf6d69c3df36a369f38120
2024-02-09 09:04:11 +00:00
d39a6c3182
Merge pull request #16854 from overleaf/jpa-overleaf-integration-core-tests
...
[web] enable overleaf-integration module when running SaaS tests
GitOrigin-RevId: 36eda6ef448604a55f8dc8daac5ce29af23b6b0b
2024-02-05 09:04:05 +00:00
61fa1d656f
Merge pull request #16835 from overleaf/bg-google-spam-temporarily-disable-emails
...
Temporarily disable onboarding emails
GitOrigin-RevId: a1967bc793fcd7b3b90f812fb8c9b9d83f704093
2024-02-01 09:03:30 +00:00
2a78b68c78
Merge pull request #16186 from overleaf/mj-mongo-object-id
...
[web] Use constructor for ObjectId
GitOrigin-RevId: 9eb8b377ea599605b72af237d1ab12f4d8287162
2023-12-19 09:04:02 +00:00
4c134f3a28
Merge pull request #16202 from overleaf/msm-passport-upgrade-2
...
[web] passport + passport-saml updates (post revert)
GitOrigin-RevId: e1fa5757e15b3ac733511570637d39297247e050
2023-12-14 09:03:24 +00:00
David