Commit Graph

2252 Commits

Author SHA1 Message Date
Antoine Clausse 90b16e4c8e [web] DS-Nav footer tweaks (#22482)
* Footer tweaks (add border, main-content 100vh)

* Update color to be the same as the sidebar `<hr>`

* Move the border to the larger div so it also separates with the navbar

* Update border color to be the same as the background

* Fixup lint

* Fixup main content padding on mobile view

See https://github.com/overleaf/internal/pull/22186#discussion_r1876087478

* Change the border color to neutral-20

* Use `--border-divider` which is the same color as --neutral-20 (`#e7e9ee`)

* Replace `@media (width >= 768px)` by `@include media-breakpoint-up(md)`

* Replace `min-height: 100dvh` by `min-height: 100%`

GitOrigin-RevId: 426869e9b96a1ee8245c487bb80ff01856521a34
2024-12-16 09:05:14 +00:00
Antoine Clausse f2d6c73f75 [web] Update project-list Navbar for mobile (#22478)
* Control if nav items are shown with CSS instead of JS

* Fix navbar style for mobile view

* Update navbar toggle icon to close

* Hide "Projects" nav item from the navbar

* Add separator above the Help menuitem in the mobile navbar

* Adjust sidebar padding: 24px from the logo

GitOrigin-RevId: ba587645f56febc0da798269bd6aa8c2e1639c27
2024-12-16 09:05:02 +00:00
Domagoj Kriskovic db45323b93 Hide reviewer option from edit-member (#22499)
GitOrigin-RevId: 16f2b51a4856ef0f651b8b7973c34a7529d826cc
2024-12-16 09:04:53 +00:00
Antoine Clausse e5c97f1963 [web] Add box shadows to scrollable part of sidebar (#22400)
* Add box shadows to scrollable part of sidebar

* Fix lint

* Fix `isAtBottom` boolean on Firefox

* Throttle the `scroll` event

* Remove wrong and unnecessary comment

GitOrigin-RevId: 7bcbb7fc860ab32f44203b3ae9ff37a3fed069a8
2024-12-16 09:04:49 +00:00
Tim Down b2b398ba0d Merge pull request #22495 from overleaf/revert-22468-td-bs5-ieee-overall-theme
Revert "Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag"

GitOrigin-RevId: 223b4816b02ba96212ea7e779e16770cd4f16949
2024-12-13 09:05:33 +00:00
Tim Down 4cd624e6a5 Merge pull request #22468 from overleaf/td-bs5-ieee-overall-theme
Always apply overall dark theme with IEEE-branded editor and tear down ieee-stylesheet feature flag

GitOrigin-RevId: 80d10a911f3a188867db9b825f3ae8413f555b64
2024-12-13 09:05:24 +00:00
ilkin-overleaf 09bbbfbb28 Merge pull request #22479 from overleaf/ii-manage-members-add-more-users-link
[web] Members management flexible licensing

GitOrigin-RevId: 8b0283db95c83c2ae1c0dd4e1e756980c168f152
2024-12-13 09:05:08 +00:00
Antoine Clausse b165e71ba9 [web] Update footer responsiveness with container queries (#22346)
* Remove padding around the footer

* Use CSS container queries instead of media queries on the full window

Container queries are supported by 92.76%	of web users, which can be an issue.
https://caniuse.com/css-container-queries

Though we do use them in other places

* Use `@supports` to check if `@container` can be used and use mixins

* Add the max sidebar width the fallback media query

* Update the footer responsiveness so we don't affect the default variant

GitOrigin-RevId: bed3e4244f1a97fd84740dcf87fb27c760be91ad
2024-12-12 09:06:09 +00:00
Antoine Clausse 62cfb68c1b [web] Add icon menus in the Sidebar (#22318)
* Add sidebar icons and menus (Help, Account)

* Place the account dropdown menu above the tooltip

* Hide tooltip when dropdown menu is shown

* Fixup tooltip position

* Add Digital Science link

* Add aria-labels on the dropdown toggles

* Update sidebar items spacings

- Add space between notification and DS icons
- Balance margin/padding in the scrollable part

* Revert changing the side of .dev-tool-bar-open-button

* Remove `!important` in link color

* Add Help tooltip

* Revert dropdown-menu z-index change

* Move `AccountMenuItems` to its own file

* Revert "Remove `!important` in link color"

This reverts commit b2de83f815d05cd1e224604d4ca355986ba76b99.

GitOrigin-RevId: 286266ea5348384f2592f748d3ae32c452558988
2024-12-12 09:06:05 +00:00
Antoine Clausse 27792199f6 [web] Update project list page main content to DS-nav-bar design (#22307)
* Move some SCSS to project-list-default.scss

* Update project-list-ds-nav.tsx to match design and simplify the SCSS

* Fix survey-notification style: light on the sidebar, dark on the main content

* Replace `withHr` by `useSplitTestContext` hook

* Override the `navbar-btn-padding-h` override.

* Fixup main content padding

Co-authored-by: Tim Down <tim.down@overleaf.com>

* Add padding-top to the logo

* Fixup merges

Add changes from https://github.com/overleaf/internal/pull/22272

---------

Co-authored-by: Tim Down <tim.down@overleaf.com>
GitOrigin-RevId: 8dbc449afbf70388bcf3185413b35234acaad349
2024-12-12 09:05:23 +00:00
Antoine Clausse 629579b840 [web] Update project list page layout and sidebar to new design (#22186)
* PoC DS nav project page shell

* Rename files: use `ds-nav` as a suffix

(really just moving code without changes)

* Update NavBar to the new design

* Small updates to project-list-ds-nav.tsx so it gets its basic shape

* Nest `.survey-notification` and `.project-list-sidebar-survey-wrapper` in the default classes to avoid interferences

* Create `SidebarDsNav`

* Add props to sidebar components so they work in both versions

* Update the SCSS code for the sidebar redesign

* Update subheader to "Organize Tags"

* Mute add affiliation font

* Remove `<aside className="project-list-sidebar-react">` and add sidebar max/min widths

* Fixup buttons padding

* Fix tests: add SplitTestProvider

* Fixup sidebar scroll div: add `flex: 1 1 auto`

* Make "Uncategorized" italic

* Update logo to SVG

* Optimize the svg
https://jakearchibald.github.io/svgomg/
9.12k → 4.92k 53.91%

---------

Co-authored-by: Tim Down <158919+timdown@users.noreply.github.com>
GitOrigin-RevId: 3d08b4b80291d9465fae87ffdf0c6a9f6deda554
2024-12-12 09:05:18 +00:00
David f8a1e7c43b Merge pull request #22398 from overleaf/dp-change-edit-mode-ui-part-2
Add ReviewModeSwitcher

GitOrigin-RevId: bfbbdac30530d859da0e8b5673357ba805b100ab
2024-12-12 09:05:06 +00:00
Domagoj Kriskovic f1c3ddb7c2 Use isReviewerRoleEnabled meta tag (#22437)
GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
2024-12-12 09:04:51 +00:00
Domagoj Kriskovic 71a0b48a68 Set track changes state permissions for reviewer role (#22345) (#22436)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 88ec39f2b760b5d1ca6dc3a363df31c087268972
2024-12-12 09:04:46 +00:00
Jimmy Domagala-Tang a8724ff7a0 Merge pull request #22330 from overleaf/jdt-split-preview-charges
feat: splitting immediate charges into pre and post tax
GitOrigin-RevId: 67c96e7dbc4dbf0d73f62242b9710532f633dbef
2024-12-11 09:04:52 +00:00
Domagoj Kriskovic a038f451d4 Revert "Set track changes state permissions for reviewer role (#22345)" (#22431)
This reverts commit 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc.

GitOrigin-RevId: 4e962bd9a547a9d6205460c9a8e9a0e835442be4
2024-12-10 13:09:42 +00:00
David f1893fa03a Show coloured squares next to collaborator names (#22406)
* Change font to content-primary

* Add user colour blocks to comments/track changes

* Format

GitOrigin-RevId: a9186e9c7c95dfe134bee2f756245275cfa9ea24
2024-12-10 13:09:37 +00:00
David 97cdc290c3 Adapt review panel header with new reviewer role (#22291)
* Adapt review panel header with new reviewer role

* Remove duplicate css property

* Update position-items

GitOrigin-RevId: a2e8dac0c1d90e6d5b3f13769909cddd69b5db14
2024-12-10 13:09:33 +00:00
David 524d743d6c Double the max lenght of a comment before truncating (#22409)
GitOrigin-RevId: 8c4314d0b3567e7c4bd963dadf2eb698d3df3565
2024-12-10 13:09:24 +00:00
Domagoj Kriskovic 53dc5fbafe Set track changes state permissions for reviewer role (#22345)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

* Add reviewer in change privilege level handler

GitOrigin-RevId: 6a03d2355b3fb7d7b755ed1d3ab1a080126cd2dc
2024-12-10 13:09:14 +00:00
Domagoj Kriskovic f39ca200b9 Support for adding reviewer role (#22314)
* Support for adding reviewer role

* added collaboratorsGetter tests

* emit toggle-track-changes when reviewer is added

GitOrigin-RevId: 5b831102d561f5dbc4b23ab9f6dc63e3a87ea103
2024-12-10 09:04:47 +00:00
David 9ed3861c70 Merge pull request #22287 from overleaf/dp-review-safari
Allow review panel entry buttons to be focused in safari

GitOrigin-RevId: 1f9854534394d2561b673857fde186058e4acf49
2024-12-10 09:04:43 +00:00
David e72a3cbc28 Merge pull request #22297 from overleaf/dp-bs5-dropdown-description-icon
Fix display of leading icons in dropdown items with a description

GitOrigin-RevId: bdb7bca62abef9d599a23364656b32599a909a90
2024-12-10 09:04:39 +00:00
Brian Gough a08d1b18dc Merge pull request #22378 from overleaf/bg-issue22368
Fix frontend to handle missing hashes for image preview

GitOrigin-RevId: e67300d9b08b02b1670cb3a7bbd4483cf4486f51
2024-12-10 09:04:29 +00:00
Domagoj Kriskovic 6a6ef776d5 Revert "Update review entries in overview panel on collaborator changes (#22098)" (#22369)
This reverts commit e2d837efe889170dc055df69eae6b4e8f86cb5fc.

GitOrigin-RevId: e2c8637ffd64fc52f1a9cb36801f8688d42d4e0c
2024-12-09 09:05:00 +00:00
Domagoj Kriskovic e83963eefc Update review entries in overview panel on collaborator changes (#22098)
* remove unused "total" property

* add missing key

* added socket listeners

* remove accept-changes listener

* not using ranges context in overview

* fix lint error

* added comment

* add accept-changes listener

* rename to removeThreadHandler

* simplify docRanges useEffect

* refactor removeThreadHandler

* refactor accept-changes handler

* delete unnecessery event handlers

* remove edit-message listener

GitOrigin-RevId: e2d837efe889170dc055df69eae6b4e8f86cb5fc
2024-12-09 09:04:56 +00:00
Domagoj Kriskovic 174d62e4cc Improve positioning of "Add comment" tooltip when selecting entire line(s) (#22277)
* Avoid obscuring text with "Add comment" tooltip when selecting entire line

* tooltip position change on direction of selection

GitOrigin-RevId: d8cd301091104dae2422e34e14f90afd4c0927c4
2024-12-09 09:04:52 +00:00
Jimmy Domagala-Tang 2dcd1afcc5 Merge pull request #22360 from overleaf/jdt-fix-admin-panel-tests-ai
feat: updating test defaults
GitOrigin-RevId: 2be457097dcdebe13dd211f2ea24b45573b7744a
2024-12-06 09:06:58 +00:00
Jimmy Domagala-Tang ab5a539c62 Merge pull request #22110 from overleaf/jdt-remove-assistant-from-labs
[Web] End Error Assist Labs Experiment

GitOrigin-RevId: 2570c07aea3d6b71dc59792cd2248cb890b415d3
2024-12-06 09:06:32 +00:00
Rebeka Dekany 1363045db2 Merge pull request #22272 from overleaf/rd-tag-dropdown-fix
[web] Tag dropdown menu should not be dismissed when hovering outside of it

GitOrigin-RevId: 0f0f903e07d657752e3476b9abea643bae65eb9e
2024-12-06 09:05:51 +00:00
Liangjun Song 932f395932 Merge pull request #22184 from overleaf/ls-group-plan-upgrade-page
Group plan upgrade page

GitOrigin-RevId: 6c99173c013d84943276dbd43f468026c4d44558
2024-12-06 09:05:38 +00:00
Liangjun Song 5ad9ac439c Merge pull request #22336 from overleaf/ii-upgrade-my-plan-link
[web] Upgrade plan link fix

GitOrigin-RevId: 943475bfb06d70bfa472459353b4f7def7b17932
2024-12-06 09:05:34 +00:00
ilkin-overleaf ab4d8fe168 Merge pull request #21841 from overleaf/ii-flexible-group-licensing-add-seats
[web] Add seats to a group plan

GitOrigin-RevId: 53497d2cb7aa7d1e7dc8291e391b24f7a32eeece
2024-12-06 09:05:13 +00:00
Jimmy Domagala-Tang c68d252508 Merge pull request #22259 from overleaf/jdt-assist-wording
Add unlimited to assist plan wording

GitOrigin-RevId: a15f10e618ab11f36f55c091d36dc4e61bff49d6
2024-12-05 09:05:10 +00:00
Domagoj Kriskovic 511fe60a9c Revert "Support for adding reviewer role (#22137)" (#22293)
This reverts commit 54064a7f961fe06f188ab449cd469cdaaf01b20a.

GitOrigin-RevId: 1dabc635756aff465d2fe9aa0d18121b081df3b0
2024-12-04 09:05:12 +00:00
Domagoj Kriskovic f676eca2b8 Support for adding reviewer role (#22137)
* Support for adding reviewer role

* show reviewer in track changes user list

* added "review" in assertClientCanViewProject

* test if reviewer can read project

* added collaboratorsGetter tests

* eit toggle-track-changes when track changes changes

* Support for changing privilege to reviewers for invited users (#22159)

* Add reviewer in change privilege level handler

* added reviewer translation

* added acceptance tests

* fix tests

* Set track changes state permissions for reviewer role (#22167)

* Add reviewer in change privilege level handler

* added reviewer translation

* added acceptance tests

* fix tests

* Set track changes state permissions for reviewer role

* added authorization helper tests

* added ensureUserCanReviewProjectContent middleware

* allow changing track changes only with write permissions

* removed canUserReviewProjectContent

* List projects where user is added as a reviewer (#22249)

* List projects where user is added as reviewer

* list projects in /user/projects

* fix tests

GitOrigin-RevId: 54064a7f961fe06f188ab449cd469cdaaf01b20a
2024-12-04 09:05:00 +00:00
Tim Down b3edd2b6c6 Merge pull request #22288 from overleaf/td-history-dropdown-layout-fix
Fix history dropdown layout issue in Bootstrap 3

GitOrigin-RevId: 85709eaa45fd496128afb95738841894c5d211dd
2024-12-04 09:04:51 +00:00
Antoine Clausse bde4da8aab [web] Reduce pre line height (#22182)
* Remove bad prop "divider" in DropdownDivider

* Reduce line height in log-entry-content-raw

Per https://digital-science.slack.com/archives/C05JM5NTHUP/p1732704056729519

* Decrease `pre` line-height to `--line-height-01` (body-xs)

GitOrigin-RevId: 584ba587d1fc3b8964b96722a6e72efc9fea1059
2024-12-03 09:04:47 +00:00
Alf Eaton a82952f9df Show deprecated browser message to Safari 14 (#22124)
GitOrigin-RevId: 92ba1a900f990eb8ab20870f0909816a07a5af9c
2024-12-02 09:05:13 +00:00
Eric Mc Sween 9e1ac94ebf Merge pull request #22163 from overleaf/em-subscription-page-ai-add-on
Adapt the Your plan entry on the subscription page to groups and Commons

GitOrigin-RevId: 7352a90d2489de48d2711f2b8a364cdd5bb54eeb
2024-11-29 09:04:59 +00:00
Jakob Ackermann faff4f1d7e Merge pull request #22178 from overleaf/jpa-file-view-hash-2
[web] migrate file-view to download from history-v1 (via web) 2/2

GitOrigin-RevId: 93172cbbd2d19a55bb27f5b0ca0b494f815a3632
2024-11-28 09:06:37 +00:00
Eric Mc Sween 8096cd2408 Merge pull request #21897 from overleaf/jdt-assistant-events
Ai Error assistant events

GitOrigin-RevId: c70e5cecbc220fdfc63512680a76616dbd631c86
2024-11-28 09:06:15 +00:00
Tim Down 967c3e597c Merge pull request #21971 from overleaf/td-ds-nav-split-test
Add split test for DS unified nav

GitOrigin-RevId: d649661568f9c1de9d2fe47f4491540e80830ab3
2024-11-28 09:05:39 +00:00
Tim Down 68867d63b4 Merge pull request #21955 from overleaf/rd-bs5-loading-button
Buttons should not be interactive when they are disabled

GitOrigin-RevId: 2b8b1e8b317dc3b62200b48dac66df7eff8a7268
2024-11-28 09:05:35 +00:00
Mathias Jakobsen 0bec88cb2b Merge pull request #22168 from overleaf/mj-rm-events
[web] Add events when refreshing linked file and importing RM entry

GitOrigin-RevId: b9efcd1893f0a78a33ec325b306eccbaa44a77fe
2024-11-28 09:05:26 +00:00
Domagoj Kriskovic a51126fb06 Fix history label timestamp used in restore file (#22068)
GitOrigin-RevId: 24e3b005664cecc017b610812cb4c666dfb55290
2024-11-28 09:05:18 +00:00
Alf Eaton 078a3b8d05 Use --font-sans in the Visual Editor widgets (#22085)
GitOrigin-RevId: 64a480562b3e7d2fda7d41ed402511290f800f14
2024-11-28 09:04:54 +00:00
Tim Down 065464f722 Merge pull request #22147 from overleaf/td-bs5-beta-badge-special-cases
Alpha/beta badge fixes and change warning badge colours in Bootstrap 5

GitOrigin-RevId: f60610572c62607db7e5cf349c5791c3519c74ed
2024-11-27 09:05:04 +00:00
Tim Down ef72402df6 Merge pull request #22089 from overleaf/td-bs5-menu-item-reduce-height
Reduce the height of menu items in BS5 to 36px

GitOrigin-RevId: 0d6294f1713618bc97562c92ea877aaeac8b9698
2024-11-26 09:05:25 +00:00
Mathias Jakobsen 592e484098 Merge pull request #22087 from overleaf/mj-index-on-wc-rm-entry
[web] Re-index references after adding a RM entry with Write and Cite

GitOrigin-RevId: 6b2a93143486079dfc82af393e2c5621fed7a4ee
2024-11-26 09:05:08 +00:00