mirror of
https://github.com/yu-i-i/overleaf-cep.git
synced 2026-05-27 02:51:57 +02:00
Use isReviewerRoleEnabled meta tag (#22437)
GitOrigin-RevId: e2f2529f09936a53087393d8f02968bdb5ea1acc
This commit is contained in:
committed by
Copybot
parent
71a0b48a68
commit
f1c3ddb7c2
@@ -6,7 +6,9 @@ import MaterialIcon from '@/shared/components/material-icon'
|
||||
import { useLayoutContext } from '@/shared/context/layout-context'
|
||||
import SplitTestBadge from '@/shared/components/split-test-badge'
|
||||
import { useTranslation } from 'react-i18next'
|
||||
import { useFeatureFlag } from '@/shared/context/split-test-context'
|
||||
import getMeta from '@/utils/meta'
|
||||
|
||||
const isReviewerRoleEnabled = getMeta('ol-isReviewerRoleEnabled')
|
||||
|
||||
const ReviewPanelHeader: FC = () => {
|
||||
const [trackChangesMenuExpanded, setTrackChangesMenuExpanded] =
|
||||
@@ -14,8 +16,6 @@ const ReviewPanelHeader: FC = () => {
|
||||
const { setReviewPanelOpen } = useLayoutContext()
|
||||
const { t } = useTranslation()
|
||||
|
||||
const enableReviewerRole = useFeatureFlag('reviewer-role')
|
||||
|
||||
return (
|
||||
<div className="review-panel-header">
|
||||
<div className="review-panel-heading">
|
||||
@@ -28,7 +28,7 @@ const ReviewPanelHeader: FC = () => {
|
||||
/>
|
||||
</span>
|
||||
</div>
|
||||
{enableReviewerRole && <ReviewPanelResolvedThreadsButton />}
|
||||
{isReviewerRoleEnabled && <ReviewPanelResolvedThreadsButton />}
|
||||
<button
|
||||
type="button"
|
||||
className="btn review-panel-close-button"
|
||||
@@ -37,7 +37,7 @@ const ReviewPanelHeader: FC = () => {
|
||||
<MaterialIcon type="close" />
|
||||
</button>
|
||||
</div>
|
||||
{!enableReviewerRole && (
|
||||
{!isReviewerRoleEnabled && (
|
||||
<div className="review-panel-tools">
|
||||
<ReviewPanelResolvedThreadsButton />
|
||||
<ReviewPanelTrackChangesMenuButton
|
||||
|
||||
@@ -7,15 +7,13 @@ import { ReviewPanelResolvedThreadsMenu } from './review-panel-resolved-threads-
|
||||
import { useTranslation } from 'react-i18next'
|
||||
import BootstrapVersionSwitcher from '@/features/ui/components/bootstrap-5/bootstrap-version-switcher'
|
||||
import MaterialIcon from '@/shared/components/material-icon'
|
||||
import { useFeatureFlag } from '@/shared/context/split-test-context'
|
||||
import getMeta from '@/utils/meta'
|
||||
|
||||
export const ReviewPanelResolvedThreadsButton: FC = () => {
|
||||
const [expanded, setExpanded] = useState(false)
|
||||
const buttonRef = useRef<HTMLButtonElement>(null)
|
||||
const { t } = useTranslation()
|
||||
|
||||
const enableReviewerRole = useFeatureFlag('reviewer-role')
|
||||
|
||||
return (
|
||||
<>
|
||||
<OLTooltip
|
||||
@@ -25,7 +23,7 @@ export const ReviewPanelResolvedThreadsButton: FC = () => {
|
||||
>
|
||||
<button
|
||||
className={
|
||||
enableReviewerRole
|
||||
getMeta('ol-isReviewerRoleEnabled')
|
||||
? 'review-panel-resolved-comments-toggle-reviewer-role'
|
||||
: 'review-panel-resolved-comments-toggle'
|
||||
}
|
||||
|
||||
@@ -1,13 +1,14 @@
|
||||
import { CSSProperties, useCallback, useEffect, useState } from 'react'
|
||||
import { useCodeMirrorViewContext } from '@/features/source-editor/components/codemirror-context'
|
||||
import { useFeatureFlag } from '@/shared/context/split-test-context'
|
||||
import getMeta from '@/utils/meta'
|
||||
|
||||
export const useReviewPanelStyles = (mini: boolean) => {
|
||||
const view = useCodeMirrorViewContext()
|
||||
const enableReviewerRole = useFeatureFlag('reviewer-role')
|
||||
|
||||
const [styles, setStyles] = useState<CSSProperties>({
|
||||
'--review-panel-header-height': enableReviewerRole ? '36px' : '69px',
|
||||
'--review-panel-header-height': getMeta('ol-isReviewerRoleEnabled')
|
||||
? '36px'
|
||||
: '69px',
|
||||
} as CSSProperties)
|
||||
|
||||
const updateScrollDomVariables = useCallback((element: HTMLDivElement) => {
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { isSplitTestEnabled } from '@/utils/splitTestUtils'
|
||||
import getMeta from '@/utils/meta'
|
||||
import { debounce } from 'lodash'
|
||||
|
||||
const COLLAPSED_HEADER_HEIGHT = isSplitTestEnabled('reviewer-role') ? 42 : 75
|
||||
const COLLAPSED_HEADER_HEIGHT = getMeta('ol-isReviewerRoleEnabled') ? 42 : 75
|
||||
const OFFSET_FOR_ENTRIES_ABOVE = 70
|
||||
const GAP_BETWEEN_ENTRIES = 4
|
||||
|
||||
|
||||
@@ -14,7 +14,7 @@ import OLForm from '@/features/ui/components/ol/ol-form'
|
||||
import OLFormGroup from '@/features/ui/components/ol/ol-form-group'
|
||||
import OLFormSelect from '@/features/ui/components/ol/ol-form-select'
|
||||
import OLButton from '@/features/ui/components/ol/ol-button'
|
||||
import { isSplitTestEnabled } from '@/utils/splitTestUtils'
|
||||
import getMeta from '@/utils/meta'
|
||||
|
||||
export default function AddCollaborators({ readOnly }) {
|
||||
const [privileges, setPrivileges] = useState('readAndWrite')
|
||||
@@ -174,7 +174,7 @@ export default function AddCollaborators({ readOnly }) {
|
||||
{t('can_edit')}
|
||||
</option>
|
||||
<option value="readOnly">{t('can_view')}</option>
|
||||
{isSplitTestEnabled('reviewer-role') && (
|
||||
{getMeta('ol-isReviewerRoleEnabled') && (
|
||||
<option value="review">{t('can_review')}</option>
|
||||
)}
|
||||
</OLFormSelect>
|
||||
|
||||
Reference in New Issue
Block a user