Commit Graph

26199 Commits

Author SHA1 Message Date
David
7337ee7a8b Merge pull request #28123 from overleaf/dp-file-outline-hover
Use themed variables to fix hover color in dark mode for file outline header

GitOrigin-RevId: e6045ab74d0afe6429c2e1b3caf04ae0eb0b857b
2025-08-28 08:06:14 +00:00
David
e94ef818b8 Merge pull request #28114 from overleaf/dp-spell-check-link
Fix spell check link in right click menu to always open settings modal in the right place

GitOrigin-RevId: dc5172211e2ed7db52f1f0d51503187aa3d7c178
2025-08-28 08:06:09 +00:00
David
657f3a36ba Merge pull request #28120 from overleaf/dp-more-error-states
Add remaining pdf error states

GitOrigin-RevId: 4c0dd3fa105273eda5c9a010051a2cb60c0056c4
2025-08-28 08:06:04 +00:00
Miguel Serrano
8948e40b22 Revert "Merge pull request #27679 from overleaf/msm-aws-sdk-upgrade" (#28151)
This reverts commit 4989ae920d8b7fd9e79623947b7c40bcc2e56d92.

GitOrigin-RevId: 541d95bfeaa7ce820e8af67f646f013fe4fe5d21
2025-08-28 08:05:52 +00:00
Miguel Serrano
39381d808a Merge pull request #27679 from overleaf/msm-aws-sdk-upgrade
Upgrade `aws-sdk` to v3

GitOrigin-RevId: 4989ae920d8b7fd9e79623947b7c40bcc2e56d92
2025-08-28 08:05:36 +00:00
Antoine Clausse
ed4a863cd3 [web] Update UserMembershipMiddleware with flexible requireEntityAccess (#28018)
* Update `requireGroupSettingsReadAccess` to be available to all admins when adminRolesEnabled is true

* Update `UserMembershipMiddleware` with a flexible `requireEntityAccess` method

* Update `UserMembershipMiddleware` further

Update endpoints permissions when admin roles are enabled:

`GET /manage/groups/:id/audit-logs` -> view-audit-log
`GET /manage/groups/:id/audit-logs/zip` -> view-audit-log
`GET /manage/groups/:id/settings` -> all admins
`GET /subscription/:id/sso_configuration_test` -> all admins
`GET /manage/groups/:id/members` -> all admins
`DELETE /manage/groups/:id/user/:user_id` -> `modify-group-member`/`modify-managed-group-member`
`GET /manage/groups/:id/members/export` -> all admins

* Update `requireEntityAccess` to parameters to an object

* Rename `hasAdminAccess` to `hasAnyAdminRole`

GitOrigin-RevId: 740ea5148edc50987fbc86607b1aaa7b7523ffcb
2025-08-28 08:05:31 +00:00
Antoine Clausse
6a53fedb36 [web] Add modify-user-account-status admin permission check on critical user operations (#27976)
* Require `modify-login-status` on `DELETE /admin/user/:user_id`

* Require `modify-login-status` on `DELETE /admin/user/:user_id/overleaf` (V1)

* Require `modify-login-status` on `DELETE /admin/user/:user_id/generate_password_reset_url`

* Require `modify-login-status` on `DELETE /admin/deleted-user/recover/:user_id`

* Update tests

* Add `ol-adminCapabilities` to deleted-user-show.pug

* Remove user-list checkboxes for admins without `modify-login-status`

* Update tests

* Rename 'modify-login-status' to 'modify-user-account-status'

GitOrigin-RevId: d3c2d0d96b79150f32cb58bfdf65042d7d447636
2025-08-28 08:05:26 +00:00
Brian Gough
f3671586e7 Merge pull request #28124 from overleaf/bg-fix-form-data-dependabot-alert
fix form-data dependabot alert

GitOrigin-RevId: a68aebb88fbabdaf1983f067c70c7459e1ddb2a6
2025-08-28 08:05:17 +00:00
Alf Eaton
cfcb9f32ab Update the word count modal (#27068)
GitOrigin-RevId: c4d11bda020e435bcf8b6daec253cedb37df0252
2025-08-27 08:06:27 +00:00
Alf Eaton
d6f6cbe189 Remove visual paste and history restore feedback surveys (#27891)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
GitOrigin-RevId: ee0a215dfc5ed6aa589b8012d2e930d9c3b0824f
2025-08-27 08:06:23 +00:00
Alf Eaton
52ca103f46 Improve handling of undefined root doc id in settings (#28108)
GitOrigin-RevId: ba0c5b468b11c53440506f05af0550e55e0f3a23
2025-08-27 08:06:18 +00:00
David
c18d2935df Merge pull request #28067 from overleaf/dp-integration-text
Update text for integration cards

GitOrigin-RevId: ca0a28dd874712748650520cb056da06a113520e
2025-08-27 08:05:52 +00:00
David
43fccf60b9 Merge pull request #28117 from overleaf/dp-tab-headings
Align rail panel headers to use the same font-weight and line-height

GitOrigin-RevId: e982f6d816e2f1b0e8f4a0af603222262d58bab0
2025-08-27 08:05:47 +00:00
Domagoj Kriskovic
e915003a61 Handle undefined rootDoc when restoring a file (#28118)
GitOrigin-RevId: f3aa32d2443f3fffbda8a10cc35d5dec3db71143
2025-08-27 08:05:43 +00:00
Domagoj Kriskovic
979059f74a [dsmp] Add resolve and reopen comment endpoints (#28093)
* [dsmp] Add resolve and reopen comment endpoints

* remove try/catch

GitOrigin-RevId: b2982de064e81a8fd7c19edbe114ae397e5f51d5
2025-08-27 08:05:35 +00:00
Domagoj Kriskovic
cffad44264 Add support for handling deleted root document in RestoreManager (#28008)
* Skip opening root document if delete originated from a file-restore

* handle project-restore origin

* Refactor isFileRestore logic

* Add support for handling deleted root document in RestoreManager

GitOrigin-RevId: 837144aa6e269cbffebf82624f58e8219fe654c4
2025-08-27 08:05:30 +00:00
Domagoj Kriskovic
dff92f1e6b Skip opening root document if delete originated from a file-restore (#27992)
* Skip opening root document if delete originated from a file-restore

* handle project-restore origin

* Refactor isFileRestore logic

GitOrigin-RevId: f2a34189140deb4e614d93e8d197b8a6a90c8f65
2025-08-27 08:05:25 +00:00
Eric Mc Sween
fa9cea9f1d Merge pull request #28098 from overleaf/em-dsmp-chat-event
Send a DSMP event when a chat message is sent

GitOrigin-RevId: 062476676c91a4edf3d6f837d60ad16c7f912771
2025-08-26 08:05:36 +00:00
Eric Mc Sween
e14d56ddb2 Merge pull request #28089 from overleaf/dk-dsmp-post-chat-message
Add support for posting chat messages

GitOrigin-RevId: 817d723abf6309716c4cfa61e2c260cb7ace0bda
2025-08-26 08:05:32 +00:00
Eric Mc Sween
91c15cb94c Merge pull request #28086 from overleaf/ac-incread-mobile-nav-z-index
[web] Increase the z-index of the navbar on small screens

GitOrigin-RevId: 528260507937d0a1691eb41ebc69cb4926ac89c4
2025-08-26 08:05:27 +00:00
Eric Mc Sween
201e5c49aa Merge pull request #28019 from overleaf/em-dsmp-comment-event
DS mobile notification for comment added/replied to

GitOrigin-RevId: 602983c679ed415bf8dd8fbf83b328e5ee832e2b
2025-08-26 08:05:20 +00:00
Domagoj Kriskovic
8c3fe3bd31 [web] change the order when creating a memebers list in permissions checks (#28063)
GitOrigin-RevId: 73fd9218841d189dc95edec86f09d451005e6189
2025-08-26 08:05:13 +00:00
Rebeka Dekany
74533fc401 Replace placeholders with labels (#26811)
* Replace placeholders for labels

* Remove redundant aria-label and update labels with `.visually-hidden`

* Change "Invite more members" to a label

* Fix helper text for group members and fix responsiveness

* Change error message to an error notification

* Use label and helper text instead of a placeholder

* Remove redundant label and use the placeholder text instead for the admin user searchbar

* Extract translations

GitOrigin-RevId: a504fda9779da82920b57c7b8aad38a8b027d09a
2025-08-26 08:05:02 +00:00
Eric Mc Sween
bae0a88dcb Merge pull request #28077 from overleaf/em-promisify-chat-controller
Promisify ChatController

GitOrigin-RevId: c2af5f7bc24b1e6c682bb1dfd1146c3dcc90ae25
2025-08-25 08:05:42 +00:00
roo hutton
31bfb82d72 Merge pull request #27849 from overleaf/rh-day-one-churn-extract
Extract users who churned after first day

GitOrigin-RevId: 2bcbee177926c262e8c0d71f1861945842b35db6
2025-08-25 08:05:33 +00:00
Domagoj Kriskovic
f65f567380 Add getThread in Chat service and use it in AuthorizationMiddleware (#28041)
* Add getThread in Chat service and use it in AuthorizationMiddleware

* ensure user_id is a string, not ObjectId

* fix tests

GitOrigin-RevId: 42d63366b9b9350d7cdbcbc3b9f4761d9f55b49a
2025-08-25 08:05:25 +00:00
Eric Mc Sween
8f0913fafe Merge pull request #27936 from overleaf/em-unit-tests-mongo
Make Mongo available to unit tests in all services

GitOrigin-RevId: b65bbb69883d5bba31d09802b89f35bdc523fe4d
2025-08-25 08:05:19 +00:00
renovate[bot]
7dc7b322a8 [Platform] Update dependency isomorphic-git to ^1.33.0 from ^1.25.10 (#28073)
* [Platform] Update dependency isomorphic-git to ^1.33.0 from ^1.25.10

* Override sha.js version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>
GitOrigin-RevId: 56bf1ef4b6fa7043ea3609e46a21c36a651905b0
2025-08-22 08:06:11 +00:00
Jakob Ackermann
f9c011473b [web] print mongo logs on acceptance/unit test failure (#28034)
* [web] print mongo logs on acceptance/unit test failure

* [web] turn on logging for mongo again

* [monorepo] improve printing of mongo logs

Co-authored-by: Gernot Schulz <gernot.schulz@overleaf.com>

* [monorepo] fix waiting for mongo startup

---------

Co-authored-by: Gernot Schulz <gernot.schulz@overleaf.com>
GitOrigin-RevId: 713ffacd1f80b134ef3cb84a8f281660ef54e5d6
2025-08-22 08:06:06 +00:00
Mathias Jakobsen
63a92b53f1 Merge pull request #28017 from overleaf/revert-28016-revert-27953-mj-editor-color-scheme
Reinstate "[web] Specify CSS color-scheme based on editor theme"

GitOrigin-RevId: a6ac8e5a352c3c795725290584a2edfa236e2baa
2025-08-22 08:05:31 +00:00
David
02d3e920c4 Merge pull request #28044 from overleaf/d-settings-spacing
Increase padding on settings modal so that it is more obvious that it scrolls

GitOrigin-RevId: cfc11f69dea9cdb6ca540aedb0bd8b14ebd82014
2025-08-22 08:05:26 +00:00
David
76e23434ed Merge pull request #28037 from overleaf/dp-additional-error-states
Add additional pdf error states in new editor

GitOrigin-RevId: a7e08652cb5ff23d2139106629f13aad20bd32a0
2025-08-22 08:05:22 +00:00
Andrew Rumble
6190005f9b [monorepo] Upgrade to node 22.18.0 (#27977)
* Upgrade to node 22.18.0

* Switch projects-data fixture to strip-types compatible form

GitOrigin-RevId: 4a7ec56f4a82395d2be8870526df0c679de38ab5
2025-08-22 08:05:17 +00:00
Jessica Lawshe
8212483da7 Merge pull request #27859 from overleaf/jel-domain-capture-create-new-user
[web] Create new group user via domain capture

GitOrigin-RevId: 2b8740edcfde05cf065564e87f50a9f84d14950a
2025-08-21 08:06:00 +00:00
David
975d1ee250 Merge pull request #27316 from overleaf/dp-file-menu-options
Add copy and submit project options to new editor file menu

GitOrigin-RevId: 7f402d96f278f2b084375441089b286adaa731b8
2025-08-21 08:05:37 +00:00
David
c1471567ce Merge pull request #28010 from overleaf/dp-histroy-sidebar
Always show history sidebar when opening history view

GitOrigin-RevId: c630b4483b11527741280ad1aaaae1b30db6e472
2025-08-21 08:05:33 +00:00
roo hutton
e0ba8a8f1a Merge pull request #27895 from overleaf/rh-b2c-js-tsx-canceled
Migrate B2C jsx to tsx: algolia-search and subscriptions

GitOrigin-RevId: 917036ce6baf8130d2b10b46efa649f015b84576
2025-08-21 08:05:28 +00:00
Rebeka Dekany
996c0a2b31 Update Notification story with the offer type (#27966)
* Update notification story with the `offer` type

* Remove `.btn-sm` as buttons should be medium sized

GitOrigin-RevId: ec0cd09fda0126bce185265fdf1f05ca7ae414c9
2025-08-21 08:05:20 +00:00
Antoine Clausse
af44f478b9 [web] Add admin permission modify-group-manager (#27642)
* Add capacity `modify-group-manager`

* Check `modify-group-manager` (backend)

* Check `modify-group-manager` (frontend)

* Update tests

* Rename AdminPermissions to mjs

* Add `ol-adminCapabilities` in frontend tests

* Allow modifying group managers if `adminRolesEnabled` is false

* Add `adminPrivilegeAvailable` check

* Update: set `ol-canModify` boolean instead of `ol-adminCapabilities`

* Mock `hasAnyAccess`

* Use `hasAdminCapability` helper

* Add `ol-canModify` to types

* Remove `isAdminMiddleware` as we don't want to relax the permissions for now

* Fix: pass `res` to `hasAnyAccess` (!!)

* * Check `hasWriteAccess` (`hasAdminCapability('modify-group-manager')` or `staffAccess.groupManagement`) in the Pug file
* Fix: Check `hasWriteAccess` in the publisher and institution pug files (!)
* Revert `hasAnyAccess` changes
* Rename `ol-canModify` to `ol-hasWriteAccess` for consistency with other variables

* Remove redundant file AdminPermissions.mjs

* Update unit test

* Revert changes to UserMembershipController.test.mjs

* Rename to `requireGroupManagersWriteAccess`

GitOrigin-RevId: f3f0b1b17abd1d2f0c363688e87d9063de886e3c
2025-08-21 08:05:07 +00:00
M Fahru
aab4b06f03 Merge pull request #27998 from overleaf/mf-improve-plan-not-found-error-stripe
[web] Return user-readable error message if user visits stripe-based payment page with invalid plan code

GitOrigin-RevId: ad88a7d6698227867874fa0a724142e563d1377c
2025-08-20 08:06:29 +00:00
Jessica Lawshe
2389674cca Merge pull request #27894 from overleaf/ii-domain-capture-join-button
[web] Domain capture join button

GitOrigin-RevId: aec6033f6776e9384c77fe0ef609c65b13a90f87
2025-08-20 08:06:21 +00:00
Jessica Lawshe
1aef3acca9 Merge pull request #27834 from overleaf/ii-domain-capture-not-in-group-redirect
[web] Redirect to domain capture page

GitOrigin-RevId: 15d2b8046beb5a40fc4937c337ee9655abaed8fd
2025-08-20 08:06:16 +00:00
Mathias Jakobsen
9b90b5e823 Merge pull request #28016 from overleaf/revert-27953-mj-editor-color-scheme
Revert "[web] Specify CSS color-scheme based on editor theme"

GitOrigin-RevId: b83fee057d40cb6c58c4e96f5ffdab2019965146
2025-08-20 08:06:11 +00:00
Mathias Jakobsen
33dbfe4c6f Merge pull request #27953 from overleaf/mj-editor-color-scheme
[web] Specify CSS color-scheme based on editor theme

GitOrigin-RevId: dda4039b7fcc4aecc7ed3f96efe15518599c9226
2025-08-20 08:06:06 +00:00
MoxAmber
fc5ae92be1 Merge pull request #27677 from overleaf/as-compile-timeout-enforcement
[web] 10s Compile Timeout - Enforcement Phase

GitOrigin-RevId: 3930eb376cc1293409259e073032218e09d5270e
2025-08-20 08:06:01 +00:00
MoxAmber
86a1be9739 Merge pull request #27848 from overleaf/as-compile-warning-teardown
[web] Tear down 10s-timeout-warning split test

GitOrigin-RevId: ca8faf77bc73073e9fc126d9d722fe568921c1c3
2025-08-20 08:05:57 +00:00
Antoine Clausse
5373c84d9f [web] Add requireAdminRoles param to hasAdminCapability (#28006)
* Add `requireAdminRoles` param to `hasAdminCapability`

https://github.com/overleaf/internal/pull/27965#discussion_r2284808889

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>

* Update test

---------

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>
GitOrigin-RevId: 83f8af84debc70c7a2e294638747369c786be22f
2025-08-20 08:05:52 +00:00
Simon Gardner
ae15f78f9c Merge pull request #27995 from overleaf/slg-license-allocated-text-2
[web] change text for 1 license

GitOrigin-RevId: 4bb7527c39b587830aa40018f28c60abb3238ff0
2025-08-20 08:05:47 +00:00
David
0b76174936 Merge pull request #27989 from overleaf/dp-pdf-caching-transport
Re-convert pdf-caching-transport to typescript

GitOrigin-RevId: f0033afd5d46bc1da00a0d815b946225a804ca19
2025-08-20 08:05:38 +00:00
Brian Gough
f5dbbadf79 add option to disable link sharing (#27626)
* add option to remove link-sharing from backend

* restrict make link-sharing in the frontend based on capability

* extend e2e project-sharing tests to cover OVERLEAF_DISABLE_LINK_SHARING=true

* throw an error when link sharing is disabled in TokenAccessHandler

* throw errors when attempting to add users to projects with link sharing disabled

* Update server-ce/test/project-sharing.spec.ts

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* add tests for existing access when link sharing is disabled

* update tests to specify access restrictions for read-only and read-write link shared projects

* [web] block access to legacy public project with link-sharing disabled

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 5f194dbcb790e973e427c58a3a4a738a5dd74cb4
2025-08-20 08:05:33 +00:00