Commit Graph
26044 Commits
Author SHA1 Message Date
Andrew Rumble df68be700d Move hasAdminCapability middleware into helpers
This is so that we can test it more easily than embedding it would allow

GitOrigin-RevId: be23d945bc7c816d32b18b4990ecd9e0a6592eb5
2025-08-08 08:05:42 +00:00
Andrew Rumble 73427c1bfc Add hasAdminCapabilities function to ExpressLocals
This will be available in pug to allow admin capabilities to be used.

GitOrigin-RevId: 6bc4e38385b421aa44ee9385e28f3c59b09e3ade
2025-08-08 08:05:37 +00:00
Rebeka Dekany 10fad9c8b7 Remove sso-login-bs5 feature flag (#27683)
GitOrigin-RevId: e1b8ce0a6d1916aa69e6235e927dc29689536362
2025-08-07 08:06:15 +00:00
Alf Eaton 4e30374961 Fix material icon in hydrate form message (#27511)
GitOrigin-RevId: 5775f89ee625a7346ccbce8c1103dfa650ff94e3
2025-08-07 08:05:42 +00:00
Alf Eaton a59eeaaf2c Ensure variables are defined when handling message from lint worker (#27561)
GitOrigin-RevId: 69e18c41707be360eb30657780915efb0d1c9aa7
2025-08-07 08:05:37 +00:00
Alf Eaton 161808b2e6 Remove the "track changes have moved" notification (#27593)
GitOrigin-RevId: 0ae1ee54c3a2d552705c5f17d2d54dc9cbe1d457
2025-08-07 08:05:32 +00:00
Alf Eaton cda7e80d7d Only decorate itemize end line when no other text on line (#27601)
GitOrigin-RevId: 6c6b3cfe99cfec4b09476e15adc2f0758b033865
2025-08-07 08:05:28 +00:00
Mathias Jakobsen 10fc0d42e8 Merge pull request #27611 from overleaf/mj-visual-editor-feedback-badges
[web] Remove unused visual editor feedback badges

GitOrigin-RevId: adb92cc66cff5f3d48ea33e53e132605270b8f25
2025-08-07 08:05:16 +00:00
Brian Gough 0c2595ddae Merge pull request #27652 from overleaf/jpa-latest-to-main
[server-pro] run-e2e-tests: tag local images as "main"

GitOrigin-RevId: b32522bd278a44a551898cab32b8a698b04ab8a6
2025-08-07 08:05:11 +00:00
Rebeka Dekany 23fc3ff0fb Remove LESS stylesheets and dependencies (#27409)
* Remove components, core and modules LESS stylesheets

* Remove variables LESS stylesheets

* Remove app LESS stylesheets

* Remove github-sync, onboarding LESS stylesheets

* Remove main-light and IEEE LESS stylesheets

* Remove Less loader configuration

* Remove bootstrap-3 entrypoint

* Rename bootstrap-5 entrypoint to bootstrap

* Remove bootstrap-5 CSS folder and move stylesheets

* Update CSS variables

* Restore and update github-sync.scss path

* Fix try-premium.scss path and fix undefined mixin error

* Restore entrypoints

* Simplify buildCssPath to always use main-style.css

* Remove less from prettier formatting scripts

* Remove less from addHook extension

* Source format

* Remove nvd3 file reference from prettierignore (equivalent of nvd3.scss)

* Remove less and less-loader

* Add SCSS files to pirates require hook

GitOrigin-RevId: bd83c79f4d6ef7305d75993959a4dc5e7714ef9c
2025-08-06 08:05:38 +00:00
Jimmy Domagala-Tang 43c640ed59 Add event when the connection lost modal is shown for users who have internet, but doc saves aren't successful (#25960)
* adding naive event send for case where realtime is disconnected, but user has internet connection for events

* using reportError and moving ops length summation to getUnsavedOpsSize

GitOrigin-RevId: 7c1c8e31ddbaa21fbc299703c69cf07ab46df925
2025-08-06 08:05:34 +00:00
Jimmy Domagala-Tang d6d99eff53 removing split test and enforcing WF account creation as winning variant (#26920)
GitOrigin-RevId: 49d801004a6fced936214e5c08b82284ab771e72
2025-08-06 08:05:30 +00:00
David 5602a60c24 Merge pull request #27644 from overleaf/dp-default-error-text
Update text in default pdf error state in new editor

GitOrigin-RevId: 4908628aab4e7ee0e2ad2c41713ebd381395dec5
2025-08-06 08:05:13 +00:00
David 5423fb52d7 Merge pull request #27384 from overleaf/dp-drag-file-tree-outline
Allow file tree and outline to be expandable and collapsible by dragging

GitOrigin-RevId: e25f0d263b1446537cdb42ef52fe1c486e855773
2025-08-06 08:05:09 +00:00
Simon Gardner 4c2c00eeb0 Merge pull request #27464 from overleaf/slg-filter-group-member-list
add user filter to group member list

GitOrigin-RevId: 0a65ca377979de706e2e43ee024d2cee9261a121
2025-08-06 08:05:05 +00:00
roo hutton bcbdd0100d Merge pull request #27215 from overleaf/rh-stripe-pause-status
Update features and subscription state when Stripe pause starts and ends

GitOrigin-RevId: 368f5d9b046cfe26e996be336189081b96926713
2025-08-06 08:04:57 +00:00
Jakob Ackermann 4b5fe08891 [web] add audit log for changing admin access in Server Pro via SSO (#27631)
* [web] add missing await statement in admin-panel tests

* [web] add audit log for changing admin access in Server Pro via SSO

GitOrigin-RevId: 69e994d0b2e0f0e0281ade80acbdf7fb30bd2e89
2025-08-06 08:04:53 +00:00
Jakob Ackermann 68df3dec1a [server-ce] tests: optimize sharding (#27635)
* [server-ce] tests: optimize sharding

* [server-ce] tests: remove shard CE_CUSTOM_2

* [server-ce] tests: move project sharing tests onto a new shard

Previously they were on their own CE_CUSTOM_1 shard.

GitOrigin-RevId: de256e04f5956b4651a5dc4ab47cdb5972723c5d
2025-08-06 08:04:46 +00:00
roo hutton b070fb88ae Merge pull request #27413 from overleaf/rh-sp-remove-geoip
Only make GeoIP lookup for premium nudge experiment in SaaS environment

GitOrigin-RevId: a0df9186dc957cd5ead6e798266874aebedabee5
2025-08-06 08:04:41 +00:00
Jakob Ackermann 15b4d5d396 [server-ce] tests: debug failing mongo startup (#27634)
GitOrigin-RevId: 5b1c272a7e0059d448347d20999eef7ad368bfd5
2025-08-05 08:06:39 +00:00
Jakob Ackermann 89b613a359 [monorepo] fail fast when parallel build steps fail in Jenkins (#27632)
GitOrigin-RevId: 6362139cc1cd72e00f3eb5900ba94c810c476d82
2025-08-05 08:06:34 +00:00
M Fahru 0c298a7ee5 Merge pull request #27498 from overleaf/mf-fix-subscriptionX-segmentation-stripe
[web] Only send one subscriptionId data in event segmentation for Stripe subscription to follow recurly

GitOrigin-RevId: 9e514d2991df768ea7e77bd5fa5f9d851c4ee8f0
2025-08-05 08:06:26 +00:00
Simon Gardner df2e4e7d7e Merge pull request #27506 from overleaf/slg-improve-add-manager-error
Improve error message when attempting to add non-registered manager

GitOrigin-RevId: d098b3640940c6299c279b86c9c7e2631cc73191
2025-08-05 08:06:21 +00:00
Simon Gardner 3d09f34767 Merge pull request #27445 from overleaf/slg-improve-domain-matcher-error
Improve domain matcher error message

GitOrigin-RevId: 8f07a8e27854637cb931f852e6c59d4960caa33b
2025-08-05 08:06:16 +00:00
Thomas 20c30f6b94 Use AsyncLocalStorage to cache userFullEmails on the request, avoiding duplicated calls to the affiliations endpoint (#27542)
* Use AsyncLocalStorage to cache userFullEmails

* Rename temporary fakeUser override to avoid conflicts

GitOrigin-RevId: 3a74816f677c1357293b0d46f245b4cfc499f2fa
2025-08-05 08:06:04 +00:00
Jakob Ackermann a168909c6c [server-ce] tests: add jenkins integration (#27600)
* [server-ce] remove unused CE_CUSTOM_3 shard

* [server-ce] tests: add jenkins integration

* [server-ce] tests: log failed host-admin requests in CI

* [server-ce] tests: attempt at reducing flakiness in Cloud Build

GitOrigin-RevId: 8d999efe1ccf041dca148bc8710dddb8561614ab
2025-08-05 08:05:55 +00:00
Jakob Ackermann b1c876745f [saas-e2e] add jenkins integration (#27587)
GitOrigin-RevId: a07b33b748964487a066d308577cad9debaa92b2
2025-08-05 08:05:50 +00:00
Simon Gardner b80b7f6afe Merge pull request #27516 from overleaf/slg-hide-enrolment_ad_html
hide enrolment_ad_html field from v1 admin form and remove unused usage in web

GitOrigin-RevId: 7cf8eed1a68bbaf2ebbb77069bfd421cd26ef01d
2025-08-05 08:05:41 +00:00
Jakob Ackermann e04b6ac8dc Merge pull request #27599 from overleaf/jpa-flaky-test
[server-ce] tests: work around overflow of OVERLEAF_APP_NAME

GitOrigin-RevId: da12b8874273319d2b624f10b257b123a3ea44cc
2025-08-05 08:05:29 +00:00
Mathias Jakobsen 491b626b64 Merge pull request #27584 from overleaf/mj-reuse-indentation-marker-theme
[web] Update indentation markers extension

GitOrigin-RevId: 8ae6a877533423bbfa37a9bb2a1610cef7ed0e87
2025-08-05 08:05:24 +00:00
Mathias Jakobsen 8fd7d2f69e Merge pull request #27567 from overleaf/mj-ensure-theme-exists
[web] Ensure editor theme exists before loading it

GitOrigin-RevId: 771aafeda2d7dd3aae9656cdfbad75996a523ac8
2025-08-05 08:05:19 +00:00
Mathias Jakobsen 0c76afff76 Merge pull request #27099 from overleaf/mj-no-duplicate-themes
[web] Avoid creating duplicate CM6 themes

GitOrigin-RevId: f6132d6cdd94ef353e047ce229d89147acc89603
2025-08-05 08:05:14 +00:00
Brian Gough 86e3fd468e Merge pull request #27592 from overleaf/bg-update-check-mongo-script-to-use-docs
update mongodb permission error message to include documentation link

GitOrigin-RevId: 89dc1ef8388f83531f9875e034d145a6de6a075b
2025-08-04 08:05:59 +00:00
Brian Gough a280a07f4b Merge pull request #25168 from overleaf/bg-history-redis-add-tls-to-sp-ce
add SP/CE redis TLS configuration options for history-v1 for future use

GitOrigin-RevId: 08d51b604f900559f999457d0c57d5e31021a27b
2025-08-04 08:05:54 +00:00
Brian Gough 13f45d23ee Merge pull request #27519 from overleaf/bg-upgrade-form-data-in-monorepo
security update for form-data

GitOrigin-RevId: f25f74b9ca51e978c0a1d0aba70ec7f09d8b1c66
2025-08-04 08:05:20 +00:00
Jakob Ackermann 6fde6c7982 Merge pull request #27522 from overleaf/jpa-reenable-tests
[server-ce] tests: enable disabled tests again

GitOrigin-RevId: 447b95bfc6b369f574a518ea46a264445efc5985
2025-08-04 08:05:13 +00:00
Jakob Ackermann 6a490bfc68 Merge pull request #27579 from overleaf/jpa-saas-e2e-split
[saas-e2e] prepare for running in Jenkins

GitOrigin-RevId: 4d87d8a548849c193c5263a3b4f01202876f43a3
2025-08-04 08:05:08 +00:00
Jakob Ackermann cba0e1562e Merge pull request #27578 from overleaf/jpa-fix-saas-e2e
[saas-e2e] fix all the broken tests

GitOrigin-RevId: 38e16abc5e2c9392b0d9e585b6bef27a51c386f5
2025-08-04 08:05:04 +00:00
Jakob Ackermann 1c5c60eb7e [packer] rework jenkins worker image (#27573)
- Use Makefile for coordinating all the independent tasks
- Pull down lots of other docker images, notably all the images for
  running Server Pro E2E tests
- Run copybara to populate it's caches
- Build Server CE and Server Pro images to populate npm caches
- Build all the monorepo images for SaaS E2E tests
- Restore the latest database backup into the CI local dev-env

GitOrigin-RevId: 821b036d1afaf2f00372dc6d0f82a51b4c3b7cc4
2025-08-04 08:04:59 +00:00
M Fahru a0f6359f60 Merge pull request #27551 from overleaf/kh-fix-failing-webhook-event
[web] prefer metadata over email for invoice.paid events

GitOrigin-RevId: cfb06333b62dfb5018bcdee0f153a812d19ff328
2025-08-01 08:07:10 +00:00
M Fahru 6f2c026aac Merge pull request #27533 from overleaf/mf-change-billing-mode-to-flexible-stripe
[web] Use flexible billing_mode for every new Stripe subscription

GitOrigin-RevId: 827b6e4802ff1d1dd92519bc949717c7d42c59cb
2025-08-01 08:07:06 +00:00
Jakob Ackermann d09f94d1b4 [server-ce] tests: split prefetching (#27566)
GitOrigin-RevId: de0bfb0d3923749b8844a8812d0a45d71ae4fa0e
2025-08-01 08:07:01 +00:00
Antoine Clausse 235823e889 [web] Prevent 6-digits verification on SSO-emails (#27496)
* Rename token -> code

* Add test: don't verify SSO emails through the 6-digits verification

* Add a test on `/user/emails/resend-confirmation-code`

* Rename to `confirmationEmailMiddleware`

* Add `Modules.middleware('confirmationEmailMiddleware')` to `/user/emails/send-confirmation-code`

* Log attempted verifications of SAML emails

GitOrigin-RevId: ccc11831c860b219711cd57bba1a76ac975e71fb
2025-08-01 08:06:47 +00:00
Antoine Clausse 2e8c7e02c9 [web] Add admin permission view-audit-log (#27402)
* Add capability `view-audit-log`

* Fix: Don't fetch `user.auditLog` twice

* Check `view-audit-log` (frontend)

* Check `view-audit-log` (backend)

* Update tests

GitOrigin-RevId: 7e20f2bdc6387144503490f6aba234d967f84913
2025-08-01 08:06:43 +00:00
Antoine ClausseandAndrew Rumble 54d5aaf9f9 [web] Add admin permission modify-feature-override (#27395)
* Add capability `modify-feature-overrides`

* Check `modify-feature-overrides` for create endpoint (frontend)

* Check `modify-feature-overrides` for create endpoint (backend)

* Update tests

* Check `modify-feature-override` for delete endpoint (frontend)

* Check `modify-feature-override` for delete endpoint (backend)

* Update tests

* Fixup test name

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>

---------

Co-authored-by: Andrew Rumble <andrew.rumble@overleaf.com>
GitOrigin-RevId: ebf37e48fed1dd6fda23ca8c7a5baf55af1cde38
2025-08-01 08:06:39 +00:00
Antoine Clausse f4517d9992 [web] Add admin permission create-recurly-account (#27376)
* Add capability `create-recurly-account`

* Check `create-recurly-account` (frontend)

* Check `create-recurly-account` (backend)

* Update tests

GitOrigin-RevId: f4a66937333fbd101cbf0562d768f185f41c88cf
2025-08-01 08:06:31 +00:00
Antoine Clausse 7c12389367 [web] Add admin permission view-user-additional-info (#27335)
* Add capability `view-user-additional-info`

* Check `view-user-additional-info` (frontend)

* Check `view-user-additional-info` (backend)

* Update tests

* Fix prop type

* Add missing `view-user-additional-info` in `product` role

GitOrigin-RevId: b912b98eac1325b74d42079feaf94d0ec99825c1
2025-08-01 08:06:27 +00:00
ilkin-overleaf 239a416f38 Merge pull request #27479 from overleaf/ii-domain-capture-recovery-email
[web] Domain capture recovery email

GitOrigin-RevId: bcff750aff23f8d8f06e4e19dbda1b7be1623035
2025-08-01 08:06:06 +00:00
Alf Eaton 26923c4eb5 Use "*:placeholder" as placeholder label (#27520)
GitOrigin-RevId: eb6566e8cab401675df21a54d0b1035fd6e8a8df
2025-08-01 08:05:58 +00:00
Alf Eaton 42b30b1cb2 Display an error message when the synctex request fails (#27523)
GitOrigin-RevId: 4a57058386ba8b11dee90ef13e374411db54e2cc
2025-08-01 08:05:54 +00:00