Commit Graph

24697 Commits

Author SHA1 Message Date
Tim Down
e080d39e50 Merge pull request #17378 from overleaf/td-stream-buffer-consolidation
Stream and buffer consolidation

GitOrigin-RevId: 284f411e6403e190d2dda3d9ebf806b1935b3949
2025-02-25 09:05:26 +00:00
Brian Gough
58a098c67a Merge pull request #23837 from overleaf/bg-redis-redact-config
sanitise password in redis config output

GitOrigin-RevId: 45d8bd13f01c3c4f138549c8a9f47dc0db29d0b0
2025-02-25 09:05:22 +00:00
Brian Gough
6d92519992 Merge pull request #23836 from overleaf/bg-backup-extend-debugging-script
add support for fetching chunks in backup debugging script

GitOrigin-RevId: 641298088d62148693525259748dcddf4d67d14b
2025-02-25 09:05:18 +00:00
Brian Gough
01c7a42787 Merge pull request #23835 from overleaf/bg-backup-show-errors
add error cause logging for missing chunks and blobs in backup comparison

GitOrigin-RevId: 9a1bf84b64621add71fb1d1e0cb013598b226bc8
2025-02-25 09:05:14 +00:00
Brian Gough
7f2f7a769d Merge pull request #23834 from overleaf/bg-backup-graceful-shutdown
add graceful shutdown handling to backup script

GitOrigin-RevId: f0fb9a3867b26c7800edefab126fd05fbabdae02
2025-02-25 09:05:10 +00:00
Jakob Ackermann
a7e96b6bb6 [server-pro] tests: wait for editor to finish loading before interacting (#23841)
GitOrigin-RevId: bef74f336c3a240da43cd5f9563629b96bc1d7ca
2025-02-25 09:05:06 +00:00
Jakob Ackermann
fd83d1a1cb [web] restrict external heartbeat/server ping to websocket transport (#23830)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: c03a78e2c05cd380b705bd14652060980682cb39
2025-02-25 09:05:02 +00:00
Jakob Ackermann
d05669f551 [web] editor connection fixes (#23807)
* [haproxy] add support for xhr-polling in real-time

* [web] try 3 WebSockets then fallback to xhr-polling when (re-)connecting

* [web] ensure old socket.io transport has been closed when reconnecting

* [web] close xhr-polling transport before leaving the page

This will de-register the client, leave the project and clean up the
connected clients tracking ASAP.

* [web] rename constant to avoid confusion

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 55e500c341145947e5589875438fc796394b6ae4
2025-02-25 09:04:58 +00:00
Antoine Clausse
462c2d7bd3 [web] Show DS Navigation for all SAAS users regardless of feature flag (with fix!) (#23821)
* Reapply "[web] Show DS Navigation for all SAAS users regardless of feature fla…"

This reverts commit 8d4096a7e4b6a7894b1bef14290548225deebd57.

* Fix: `hasDsNav` should check `isOverleaf` !!!

* Change `hasDsNav` from a boolean to a function call for dynamic evaluation

GitOrigin-RevId: 17463ac113a4278ed344622552d83da93b208b4d
2025-02-25 09:04:54 +00:00
Antoine Clausse
78d48dbdac Fix prefetch_custom_texlive command (#23813)
Previous attempt failed with `sh: gcr.io/overleaf-ops/texlive-full:2023.1: No such file or directory`.

 Now tested with `make prefetch_custom_texlive`

GitOrigin-RevId: 09a5e1d3c270bdb58c761c8be3c665155879290f
2025-02-25 09:04:50 +00:00
Jakob Ackermann
85d4aecbcf [server-ce] precompile pug files concurrent to npm-i-dev/webpack build (#23824)
GitOrigin-RevId: 7fd153dd0fa89ca4bc12efc1e26276844ff9431a
2025-02-25 09:04:43 +00:00
CloudBuild
eaf20ed0be auto update translation
GitOrigin-RevId: 9948881e46548a02c38202ac0408c609c2c6f82b
2025-02-24 09:06:23 +00:00
CloudBuild
393e37ba57 auto update translation
GitOrigin-RevId: 2d057c8c8816407403ee26baebacbddf5f7d8946
2025-02-24 09:06:19 +00:00
Andrew Rumble
427191e33b Merge pull request #23812 from overleaf/ar-allow-debugging-for-remove-backup-blobs-script-errors
[history-v1] Minor improvements to AWS cleanup script

GitOrigin-RevId: bd01a72169b9cbc018612173294cfbf8649a9fbd
2025-02-24 09:06:15 +00:00
Antoine Clausse
0452be58f0 Merge pull request #23811 from overleaf/revert-23801-ac-remove-ds-nav-code-3
Revert "[web] Show DS Navigation for all SAAS users regardless of feature flag"

GitOrigin-RevId: 3a5b5603718da2fddabc9f1460151efd9cbf6178
2025-02-24 09:06:11 +00:00
Antoine Clausse
0adc30738f [web] Show DS Navigation for all SAAS users regardless of feature flag (#23801)
* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* Replace `useIsDsNav()` by `isOverleaf`

* Rename former `hideDsSurvey` to `hideDsSurvey`, and set `hasDsNav = isOverleaf` variable

so the intent is clearer.

* Update frontend tests

GitOrigin-RevId: 2be9f88a10da430c0429de15d777d98104327f9f
2025-02-24 09:06:04 +00:00
Antoine Clausse
9bb220506a Replace xargs -d, by tr ',' '\0' | xargs -0 (#23800)
`xargs -d` doesn't work on Mac OS: `xargs: illegal option -- d`

There's a workaround using `tr`

See: https://stackoverflow.com/a/71409498/4823861
GitOrigin-RevId: 109c7e1e035b829122d96fd41824f18bdf81468a
2025-02-24 09:06:00 +00:00
Andrew Rumble
bae38f1be7 Merge pull request #23742 from overleaf/ar-script-for-removing-blobs-in-wrong-place
[history-v1] Script for deleting blobs backed up to wrong location

GitOrigin-RevId: 6abe1dba5164f8fa7d41c4ee3e4a07764e73b7e1
2025-02-24 09:05:53 +00:00
Alf Eaton
36bef65d8c Revert "Use fixed width for project list checkbox cell (#23778)" (#23808)
This reverts commit 4d3f443f99f366a43a1b59a7556c0341c06d7af9.

GitOrigin-RevId: 1b111d9b4826ecdba1d40334f9c8e25e2b8561b1
2025-02-24 09:05:49 +00:00
Alf Eaton
5a1ed7f962 Upgrade dompurify (#23748)
GitOrigin-RevId: a2aa1c40a454f8ff487b5de15da39de577c6ff16
2025-02-24 09:05:44 +00:00
Alf Eaton
653db9b561 Update AI feedback form text (#23754)
GitOrigin-RevId: 29ca72963e912ee0e121dece9821bb90efa8eff3
2025-02-24 09:05:40 +00:00
Alf Eaton
7927a05487 Avoid selecting word when opening spell check context menu (#23756)
GitOrigin-RevId: 0276979d18583f5813476b2ac01a8eb33b352fcb
2025-02-24 09:05:36 +00:00
Alf Eaton
f00610eb15 Remove aria-hidden from theme menu divider option (#23704)
GitOrigin-RevId: c6df23ad5869aaff41beb767ecd5d1d86910a267
2025-02-24 09:05:31 +00:00
Alf Eaton
88d1f4757a Block Safari 14, deprecate Safari 15 (#23740)
GitOrigin-RevId: ef1506bc58982c4fb8286d48137ca9c8557ee1a0
2025-02-24 09:05:27 +00:00
Alf Eaton
cce1406e1c Upgrade PDF.js to 4.10.38 (#23745)
GitOrigin-RevId: d7264acd7c1a8e64042be799efa4c7ca133e64f8
2025-02-24 09:05:23 +00:00
Alf Eaton
7af7d9474f Remove link from DS in side nav (#23759)
GitOrigin-RevId: 0724fecd45ce3686be25d394aaea9c2c2b97f669
2025-02-24 09:05:18 +00:00
Alf Eaton
ffb86df5b1 Show reviewers in the admin list of collaborators for a project (#23777)
GitOrigin-RevId: 6d7e5debc5619dab5b696ab8aab26496931e38b1
2025-02-24 09:05:11 +00:00
Alf Eaton
549080df1e Use fixed width for project list checkbox cell (#23778)
* Use fixed width for project list checkbox
* Set word-break: break-word for project owner name (#23783)

GitOrigin-RevId: 4d3f443f99f366a43a1b59a7556c0341c06d7af9
2025-02-24 09:05:06 +00:00
Alf Eaton
717454dbbc Only dispatch doc:changed event for insert or delete operations (#23779)
GitOrigin-RevId: b3425d4edffb045b2a15e5fc5cb69210d9e97203
2025-02-24 09:05:02 +00:00
Alf Eaton
e81c1bd06c Ensure that the Chat pane is disabled for read-only link collaborators (#23785)
GitOrigin-RevId: 56e1b1d6b08ec7537386cab0b251e325d681e117
2025-02-24 09:04:58 +00:00
Rebeka Dekany
f22cf244f4 Remove bootstrap-5 feature flag from the Account Settings page (#23693)
GitOrigin-RevId: 0fc29f2cb904f9133fd26ad119909edba1518cbf
2025-02-24 09:04:54 +00:00
Eric Mc Sween
35a0c55027 Merge pull request #23784 from overleaf/em-find-dangling-comments-modified-since
Add --project-modified-since option to find_dangling_comments script

GitOrigin-RevId: 69483611dbfa71eeb16206387771b2b9d837f978
2025-02-24 09:04:49 +00:00
Domagoj Kriskovic
f46b7d4fd1 Allow selecting comment text without changing scroll position (#23628)
* Allow selecting comment text without changing scroll position

* cursor:default on review content

* check text selection on mouseup

* update comment

GitOrigin-RevId: f867613f5b4d08c3b960abfa061b14b404f411a8
2025-02-24 09:04:45 +00:00
Domagoj Kriskovic
db4728d292 Convert track changes to proper format when reviewer role is enabled (#23683)
GitOrigin-RevId: 2ac696804491f61e52b4645dff7f64339c47afc5
2025-02-24 09:04:41 +00:00
Antoine Clausse
aaeeb160d9 Merge pull request #23798 from overleaf/revert-23767-ac-remove-ds-nav-code-small
Revert "[web] Show DS Navigation for all users regardless of feature flag "

GitOrigin-RevId: 569800d75e1ef3ed6af666325213f1615c8f3a43
2025-02-24 09:04:37 +00:00
Brian Gough
bfa5d956a0 Merge pull request #21763 from overleaf/bg-backup-script
initial script for running backups

GitOrigin-RevId: d22c373de30738d8080d40dce10790f0bdcb9f51
2025-02-24 09:04:32 +00:00
Jakob Ackermann
562ec23ec6 [real-time] ignore error from duplicate send action on socket.io socket (#23787)
GitOrigin-RevId: 992a39a5cff04bcc0814ac6a620ad350d6e1da14
2025-02-21 09:05:52 +00:00
Antoine Clausse
1b70036034 [web] Show DS Navigation for all users regardless of feature flag (#23767)
* Remove uses of `useIsDsNav`

* Remove `sidebar-navigation-ui-update` as true from analytics events

* Hide "ds-nav" survey for users who have the feature flag

* `make cleanup_unused_locales` & `bin/run web npm run extract-translations`

* Update frontend tests

GitOrigin-RevId: 83f429d81ca1b46e9eab4fc667a921026a85912f
2025-02-21 09:05:48 +00:00
Antoine Clausse
0d05cef327 [web] When switching primary email, delete the old primary if it's unconfirmed (#23688)
* Add note to ConfirmModal: unconfirmed primary will be deleted

* Change confirm button copy

* Promisify `UserEmailsController.setDefault`

* Update tests after promisification

* Delete unconfirmed primary when swapped

* Fixup apostrophe in translation

* `npm run extract-translations`

* Add unit tests

* Add acceptance tests

* Fix frontend tests

* Make email address bold

* Add "We removed the previous primary..." to the email

GitOrigin-RevId: c971e219e36e509f9963e1720acdd44f562a05b5
2025-02-21 09:05:44 +00:00
Jakob Ackermann
9a6aad3c04 [server-pro] fix ldap tests (#23771)
GitOrigin-RevId: 6540b7b8766eaf5fd2c7d0b3ff3c9d627382e56e
2025-02-21 09:05:40 +00:00
Jakob Ackermann
c5f410d531 [server-pro] tests: make project invite tests more reliable (#23732)
* [web] wait for sending project invite notification, send email detached

Errors from sending the notification or email are still logged only.
Wait up-to ~one second for notification to be sent (API timeout is 1s).

* [server-pro] tests: wait for invite action to complete

GitOrigin-RevId: e6998e6134b5267c91b47785d616a46e9651b996
2025-02-21 09:05:30 +00:00
Miguel Serrano
93e561dd96 Merge pull request #23652 from overleaf/msm-update-path-to-regexp
[monorepo] Update express to 4.1.2

GitOrigin-RevId: b3db75257e1edc1a25a1a657def352ecca926920
2025-02-21 09:05:26 +00:00
Miguel Serrano
003b1fb7e3 Merge pull request #23642 from overleaf/msm-update-cross-spawin
[monorepo] Updated cross-spawn to 7.0.6

GitOrigin-RevId: 42ca1ca19957a2cddd4968ceea276bc05f659071
2025-02-21 09:05:22 +00:00
Miguel Serrano
c670626e6d Merge pull request #23733 from overleaf/msm-configurable-login-title
[web] Add `OVERLEAF_LOGIN_SUPPORT_TITLE` for CE/SP

GitOrigin-RevId: 5a50d17ded67b68c72dbaeab5172fc283b5aaa01
2025-02-21 09:05:18 +00:00
Miguel Serrano
1c0c313200 Merge pull request #23680 from overleaf/msm-readonly-email-activation
[CE/SP] Fix `email` not sent on activation

GitOrigin-RevId: 3989bcc318086b3b10576138869296888be27998
2025-02-21 09:05:14 +00:00
Eric Mc Sween
ac19f994dd Merge pull request #23725 from overleaf/em-find-dangling-comments-archived-docs
Look at archived docs when looking for dangling comments

GitOrigin-RevId: fb04b9428ce83802b6e658153c5bbe70e983de65
2025-02-21 09:05:04 +00:00
Eric Mc Sween
131962f381 Merge pull request #23689 from overleaf/em-dp-mj-interstitial-join-project-bs5
Migrate interstitial join project page to Bootstrap 5

GitOrigin-RevId: 10f45eecb33e087373a9605074ef9f8562ca2b8f
2025-02-21 09:05:00 +00:00
Eric Mc Sween
92483cc2ea Merge pull request #23715 from overleaf/em-zoom-tooltips
Change copy for zoom tooltips

GitOrigin-RevId: e87d66d22bba93b9e9ee5e6938a99d003e70131a
2025-02-21 09:04:56 +00:00
roo hutton
0037940da9 Misc fixes for updated compile timeout paywall (#23741)
* hide cached files/logs and files buttons while primary paywall showing

* replace plans link with interstitial

* open checkout in new tab

* editors > collaborators, use correct collab count for student plan, refactor collab translations

* fix variable case

GitOrigin-RevId: 48f53aa385ed6d7e5c9b485fe4a045a47c448777
2025-02-21 09:04:52 +00:00
Andrew Rumble
657543290f Merge pull request #23457 from overleaf/ar-recurly-account-mapping-initial
[web] setup Recurly -> Mongo account mapping

GitOrigin-RevId: ee08cad60ee04e62100f3d5a4f76fdbcf5543917
2025-02-21 09:04:45 +00:00