wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(gameplay): move transition event composition into service
All checks were successful
CI / test-and-quality (pull_request) Successful in 3m36s
Details
CI / test-and-quality (push) Successful in 3m37s
Details

Browse Source
This commit is contained in:
DEV-bot
2026-03-17 11:58:39 +00:00
parent 9baade0105
commit 8a07433f11
3 changed files with 37 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lobby/tests.py
View File

@@ -59,19 +59,15 @@ class LobbyGameplayExtractionTests(TestCase):
self.assertIs(lobby_views._start_next_round, gameplay_services.start_next_round)
self.assertIs(lobby_views._finish_game, gameplay_services.finish_game)
self.assertIs(lobby_views._build_scoreboard_phase_event, gameplay_payloads.build_scoreboard_phase_event)
self.assertIs(lobby_views._build_start_next_round_phase_event, gameplay_payloads.build_start_next_round_phase_event)
self.assertIs(lobby_views._build_start_next_round_response, gameplay_payloads.build_start_next_round_response)
self.assertIs(lobby_views._build_finish_game_phase_event, gameplay_payloads.build_finish_game_phase_event)
self.assertIs(lobby_views._build_finish_game_response, gameplay_payloads.build_finish_game_response)
@patch("lobby.views.sync_broadcast_phase_event")
@patch("lobby.views._build_start_next_round_response", return_value={"ok": True})
@patch("lobby.views._build_start_next_round_phase_event")
@patch("lobby.views._start_next_round")
def test_start_next_round_view_delegates_transition_to_service(
self,
mock_start_next_round,
mock_build_phase_event,
mock_build_response,
mock_sync_broadcast_phase_event,
):
@@ -92,19 +88,16 @@ class LobbyGameplayExtractionTests(TestCase):
round_config=next_round_config,
round_question=round_question,
should_broadcast=True,
phase_event_name="phase.lie_started",
phase_event_payload={"round_question_id": round_question.id},
)
mock_start_next_round.return_value = transition
mock_build_phase_event.return_value = {
"name": "phase.lie_started",
"payload": {"round_question_id": round_question.id},
}
response = self.client.post(reverse("lobby:start_next_round", kwargs={"code": self.session.code}))
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"ok": True})
mock_start_next_round.assert_called_once_with(self.session)
mock_build_phase_event.assert_called_once_with(self.session, next_round_config, round_question)
mock_build_response.assert_called_once_with(self.session, next_round_config, round_question)
mock_sync_broadcast_phase_event.assert_called_once_with(
self.session.code,
@@ -114,30 +107,28 @@ class LobbyGameplayExtractionTests(TestCase):
@patch("lobby.views.sync_broadcast_phase_event")
@patch("lobby.views._build_finish_game_response", return_value={"ok": True})
@patch("lobby.views._build_finish_game_phase_event")
@patch("lobby.views._finish_game")
def test_finish_game_view_delegates_transition_to_service(
self,
mock_finish_game,
mock_build_phase_event,
mock_build_response,
mock_sync_broadcast_phase_event,
):
finished_session = GameSession.objects.get(pk=self.session.pk)
finished_session.status = GameSession.Status.FINISHED
transition = gameplay_services.FinishGameResult(session=finished_session, should_broadcast=True)
transition = gameplay_services.FinishGameResult(
session=finished_session,
should_broadcast=True,
phase_event_name="phase.game_over",
phase_event_payload={"winner": None, "leaderboard": []},
)
mock_finish_game.return_value = transition
mock_build_phase_event.return_value = {
"name": "phase.game_over",
"payload": {"winner": None, "leaderboard": []},
}
response = self.client.post(reverse("lobby:finish_game", kwargs={"code": self.session.code}))
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"ok": True})
mock_finish_game.assert_called_once_with(self.session)
mock_build_phase_event.assert_called_once_with(finished_session)
mock_build_response.assert_called_once_with(finished_session)
mock_sync_broadcast_phase_event.assert_called_once_with(
self.session.code,
@@ -147,12 +138,10 @@ class LobbyGameplayExtractionTests(TestCase):
@patch("lobby.views.sync_broadcast_phase_event")
@patch("lobby.views._build_start_next_round_response", return_value={"ok": True})
@patch("lobby.views._build_start_next_round_phase_event")
@patch("lobby.views._start_next_round")
def test_start_next_round_view_skips_broadcast_on_service_replay(
self,
mock_start_next_round,
mock_build_phase_event,
mock_build_response,
mock_sync_broadcast_phase_event,
):
@@ -184,18 +173,15 @@ class LobbyGameplayExtractionTests(TestCase):
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"ok": True})
mock_start_next_round.assert_called_once_with(self.session)
mock_build_phase_event.assert_not_called()
mock_build_response.assert_called_once_with(replay_session, replay_round_config, round_question)
mock_sync_broadcast_phase_event.assert_not_called()
@patch("lobby.views.sync_broadcast_phase_event")
@patch("lobby.views._build_finish_game_response", return_value={"ok": True})
@patch("lobby.views._build_finish_game_phase_event")
@patch("lobby.views._finish_game")
def test_finish_game_view_skips_broadcast_on_service_replay(
self,
mock_finish_game,
mock_build_phase_event,
mock_build_response,
mock_sync_broadcast_phase_event,
):
@@ -209,7 +195,6 @@ class LobbyGameplayExtractionTests(TestCase):
self.assertEqual(response.status_code, 200)
self.assertEqual(response.json(), {"ok": True})
mock_finish_game.assert_called_once_with(self.session)
mock_build_phase_event.assert_not_called()
mock_build_response.assert_called_once_with(finished_session)
mock_sync_broadcast_phase_event.assert_not_called()