wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(gameplay): keep host transition events in payload layer
All checks were successful
CI / test-and-quality (push) Successful in 3m28s
Details
CI / test-and-quality (pull_request) Successful in 3m28s
Details

Browse Source
This commit is contained in:
DEV-bot
2026-03-17 13:04:58 +00:00
parent 8a07433f11
commit d272e35a79
3 changed files with 15 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
fupogfakta/services.py
View File

@@ -1,11 +1,9 @@
import random
from dataclasses import dataclass
from typing import Any
from django.db import transaction
from .models import GameSession, Guess, LieAnswer, Player, Question, RoundConfig, RoundQuestion, ScoreEvent
from .payloads import build_finish_game_phase_event, build_start_next_round_phase_event
@dataclass(frozen=True)
@@ -14,16 +12,12 @@ class RoundTransitionResult:
round_config: RoundConfig
round_question: RoundQuestion
should_broadcast: bool
phase_event_name: str | None = None
phase_event_payload: dict[str, Any] | None = None
@dataclass(frozen=True)
class FinishGameResult:
session: GameSession
should_broadcast: bool
phase_event_name: str | None = None
phase_event_payload: dict[str, Any] | None = None
@dataclass(frozen=True)
@@ -108,9 +102,6 @@ def start_next_round(session: GameSession) -> RoundTransitionResult:
round_question = None
should_broadcast = False
phase_event_name = None
phase_event_payload = None
if locked_session.status == GameSession.Status.SCOREBOARD:
previous_round_config = RoundConfig.objects.filter(
session=locked_session,
@@ -138,9 +129,6 @@ def start_next_round(session: GameSession) -> RoundTransitionResult:
locked_session.status = GameSession.Status.LIE
locked_session.save(update_fields=["current_round", "status"])
should_broadcast = True
phase_event = build_start_next_round_phase_event(locked_session, next_round_config, round_question)
phase_event_name = phase_event["name"]
phase_event_payload = phase_event["payload"]
elif locked_session.status == GameSession.Status.LIE:
if locked_session.current_round <= 1:
raise ValueError("next_round_invalid_phase")
@@ -164,8 +152,6 @@ def start_next_round(session: GameSession) -> RoundTransitionResult:
round_config=next_round_config,
round_question=round_question,
should_broadcast=should_broadcast,
phase_event_name=phase_event_name,
phase_event_payload=phase_event_payload,
)
@@ -174,25 +160,15 @@ def finish_game(session: GameSession) -> FinishGameResult:
with transaction.atomic():
locked_session = GameSession.objects.select_for_update().get(pk=session.pk)
should_broadcast = False
phase_event_name = None
phase_event_payload = None
if locked_session.status == GameSession.Status.SCOREBOARD:
locked_session.status = GameSession.Status.FINISHED
locked_session.save(update_fields=["status"])
should_broadcast = True
phase_event = build_finish_game_phase_event(locked_session)
phase_event_name = phase_event["name"]
phase_event_payload = phase_event["payload"]
elif locked_session.status != GameSession.Status.FINISHED:
raise ValueError("finish_game_invalid_phase")
return FinishGameResult(
session=locked_session,
should_broadcast=should_broadcast,
phase_event_name=phase_event_name,
phase_event_payload=phase_event_payload,
)
return FinishGameResult(session=locked_session, should_broadcast=should_broadcast)