refactor(payloads): delegate session detail gameplay payload
Some checks failed
CI / test-and-quality (push) Failing after 11s
CI / test-and-quality (pull_request) Failing after 12s

This commit is contained in:
2026-03-18 01:33:47 +00:00
parent d2cdf16322
commit dd615796f4
4 changed files with 65 additions and 22 deletions

View File

@@ -61,8 +61,7 @@ class LobbyGameplayExtractionTests(TestCase):
self.assertIs(lobby_views._show_question, gameplay_services.show_question)
self.assertIs(lobby_views._start_next_round, gameplay_services.start_next_round)
self.assertIs(lobby_views._finish_game, gameplay_services.finish_game)
self.assertIs(lobby_views._build_phase_view_model, gameplay_payloads.build_phase_view_model)
self.assertIs(lobby_views._build_round_question_payload, gameplay_payloads.build_round_question_payload)
self.assertIs(lobby_views._build_session_detail_gameplay_payload, gameplay_payloads.build_session_detail_gameplay_payload)
self.assertIs(lobby_views._build_scoreboard_phase_event, gameplay_payloads.build_scoreboard_phase_event)
def test_start_round_view_source_stays_http_thin(self):
@@ -113,10 +112,12 @@ class LobbyGameplayExtractionTests(TestCase):
self.assertIn("session = _maybe_promote_reveal_to_scoreboard(session)", source)
self.assertIn("current_round_question = _get_current_round_question(session)", source)
self.assertIn("round_question_payload = _build_round_question_payload(current_round_question)", source)
self.assertIn("phase_view_model = _build_phase_view_model(", source)
self.assertIn('"scoreboard": _build_scoreboard_phase_event(session)["payload"]["leaderboard"]', source)
self.assertIn('"reveal": _build_reveal_payload(current_round_question)', source)
self.assertIn("gameplay_payload = _build_session_detail_gameplay_payload(", source)
self.assertIn("**gameplay_payload", source)
self.assertNotIn("build_round_question_payload", source)
self.assertNotIn("build_phase_view_model", source)
self.assertNotIn("build_reveal_payload", source)
self.assertNotIn("build_scoreboard_phase_event(session)[\"payload\"][\"leaderboard\"]", source)
self.assertNotIn("lies.select_related", source)
self.assertNotIn("guesses.select_related", source)
self.assertNotIn("Player.objects.filter(session=session)", source)