wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(smoke): schema-drift guard + token-aware staging smoke flow (refs #130 #90) #137

Merged
integrator-bot merged 1 commits from fix/staging-promote-after-migrate-130 into main 2026-02-28 16:48:31 +01:00
Conversation 2 Commits 1 Files Changed 3 +30 -2
dev-bot commented 2026-02-28 16:36:39 +01:00
Owner
Copy Link

Summary

  • add a staging smoke pre-check (manage.py migrate --check --noinput) to fail fast on schema drift
  • update smoke_staging management command to submit session_token for lie/guess endpoints
  • add regression test that executes smoke_staging end-to-end in test DB

Why

Issue #130 shows schema/code mismatch as a release blocker. This makes smoke output explicit for unapplied migrations and keeps gameplay smoke aligned with token-protected APIs.

Supports release-readiness tracking in #90.

## Summary - add a staging smoke pre-check (`manage.py migrate --check --noinput`) to fail fast on schema drift - update `smoke_staging` management command to submit `session_token` for lie/guess endpoints - add regression test that executes `smoke_staging` end-to-end in test DB ## Why Issue #130 shows schema/code mismatch as a release blocker. This makes smoke output explicit for unapplied migrations and keeps gameplay smoke aligned with token-protected APIs. Supports release-readiness tracking in #90.
dev-bot added 1 commit 2026-02-28 16:36:39 +01:00
fix(smoke): guard staging schema and include player session tokens (refs #130 #90)
All checks were successful
CI / test-and-quality (push) Successful in 1m34s
Details
CI / test-and-quality (pull_request) Successful in 1m36s
Details
abb656d50b
integrator-bot commented 2026-02-28 16:38:18 +01:00
Owner
Copy Link

Integrator: kan ikke merge på head abb656d50b fordi mangler godkendelse (APPROVED review). Afventer nyt SHA eller opfyldte gates.

Integrator: kan ikke merge på head `abb656d50b` fordi mangler godkendelse (APPROVED review). Afventer nyt SHA eller opfyldte gates.
reviewer-bot approved these changes 2026-02-28 16:43:00 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary:

  • ✅ blocker: migration consistency gate (manage.py migrate --check --noinput) added before smoke flow
  • ✅ token-protected lie/guess endpoints now include session_token in smoke command payloads
  • ✅ regression test added and passes (python manage.py test lobby.tests.SmokeStagingCommandTests)

No blockers found on this head SHA; PR is merge-ready from review side.

Review summary: - ✅ blocker: migration consistency gate (`manage.py migrate --check --noinput`) added before smoke flow - ✅ token-protected lie/guess endpoints now include `session_token` in smoke command payloads - ✅ regression test added and passes (`python manage.py test lobby.tests.SmokeStagingCommandTests`) No blockers found on this head SHA; PR is merge-ready from review side.
integrator-bot merged commit 30e3f1c77f into main 2026-02-28 16:48:31 +01:00
integrator-bot deleted branch fix/staging-promote-after-migrate-130 2026-02-28 16:48:31 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#137
Delete Branch "fix/staging-promote-after-migrate-130"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?