## Summary
- ensure `/opt/wpp-staging/releases` and `/opt/wpp-staging/app` are created with `wpp:wpp` ownership before deploy copy steps
- replace `rm -rf "${APP_DIR}"/*` with a dotfile-safe cleanup (`find ... -mindepth 1`)
- assert final app dir is writable by runtime user via `runuser -u wpp -- test -w "${APP_DIR}"`
## Why
Issue #138 observed staging deploy leaving app tree root-owned, causing sqlite/db open failures when runtime tries to write under app dir.
## Validation
- `bash -n infra/staging/deploy_staging.sh`
Refs #138
Refs #90
infra/staging/deploy_staging.sh now ensures ${RELEASES_DIR} and ${APP_DIR} exist with wpp:wpp ownership before deploy.
Candidate promotion now clears app dir via find ... -exec rm -rf -- {} +, which correctly handles dotfiles and avoids stale hidden files across releases.
Added explicit writability guard (runuser -u wpp -- test -w "${APP_DIR}") before restart.
No blockers found. CI status is green on current head SHA.
APPROVED ✅
Review summary:
- `infra/staging/deploy_staging.sh` now ensures `${RELEASES_DIR}` and `${APP_DIR}` exist with `wpp:wpp` ownership before deploy.
- Candidate promotion now clears app dir via `find ... -exec rm -rf -- {} +`, which correctly handles dotfiles and avoids stale hidden files across releases.
- Added explicit writability guard (`runuser -u wpp -- test -w "${APP_DIR}"`) before restart.
No blockers found. CI status is green on current head SHA.
Gennemgået infra/staging/deploy_staging.sh for PR-head 30c22d2f0c.
sikrer wpp:wpp ownership af releases/app dirs
dotfile-safe cleanup via find ... -mindepth 1
writeability-check som runtime-bruger før service restart
Ingen blockers fundet.
LGTM ✅
Gennemgået infra/staging/deploy_staging.sh for PR-head 30c22d2f0ce21a9c8e5f030faff979d57a8f9434.
- sikrer wpp:wpp ownership af releases/app dirs
- dotfile-safe cleanup via find ... -mindepth 1
- writeability-check som runtime-bruger før service restart
Ingen blockers fundet.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
reviewer-bot
Summary
/opt/wpp-staging/releasesand/opt/wpp-staging/appare created withwpp:wppownership before deploy copy stepsrm -rf "${APP_DIR}"/*with a dotfile-safe cleanup (find ... -mindepth 1)runuser -u wpp -- test -w "${APP_DIR}"Why
Issue #138 observed staging deploy leaving app tree root-owned, causing sqlite/db open failures when runtime tries to write under app dir.
Validation
bash -n infra/staging/deploy_staging.shRefs #138
Refs #90
APPROVED ✅
Review summary:
infra/staging/deploy_staging.shnow ensures${RELEASES_DIR}and${APP_DIR}exist withwpp:wppownership before deploy.find ... -exec rm -rf -- {} +, which correctly handles dotfiles and avoids stale hidden files across releases.runuser -u wpp -- test -w "${APP_DIR}") before restart.No blockers found. CI status is green on current head SHA.
LGTM ✅
Gennemgået infra/staging/deploy_staging.sh for PR-head
30c22d2f0c.Ingen blockers fundet.