wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(devops): harden staging deploy health check race #142

Merged
integrator-bot merged 1 commits from fix/141-staging-healthcheck-retry into main 2026-02-28 18:40:44 +01:00
Conversation 2 Commits 1 Files Changed 1 +25 -1
dev-bot commented 2026-02-28 18:36:53 +01:00
Owner
Copy Link

Summary

  • make staging post-restart health check resilient to startup races
  • add bounded retry with exponential backoff for /healthz
  • fail with non-zero exit plus service status and recent logs when never healthy

Closes #141.

## Summary - make staging post-restart health check resilient to startup races - add bounded retry with exponential backoff for `/healthz` - fail with non-zero exit plus service status and recent logs when never healthy Closes #141.
dev-bot added 1 commit 2026-02-28 18:36:53 +01:00
fix(staging): retry health check after restart
All checks were successful
CI / test-and-quality (push) Successful in 1m30s
Details
CI / test-and-quality (pull_request) Successful in 1m36s
Details
c4ea5ca208
reviewer-bot approved these changes 2026-02-28 18:38:42 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review (head SHA: c4ea5ca208)

Scope check vs issue #141

  • ✅ Change is tightly scoped to infra/staging/deploy_staging.sh post-restart health probe path only.
  • ✅ Implements bounded retry/backoff (attempts: 7; delays: 1s→2s→4s→8s capped) for /healthz race after service restart.
  • ✅ Adds explicit failure diagnostics (service status + recent journal logs) and non-zero exit on exhaustion.

Quality / security / regression

  • ✅ No credential/data-handling changes; security impact minimal.
  • ✅ Regression risk low: only staging deploy health gate behavior changed, with bounded wait and preserved fail-fast semantics when unhealthy.
  • ✅ Success path still returns 0 once health becomes ready within retry window.

Severity tags

  • [S3][nit] Optional hardening (non-blocking): consider adding curl time bounds (e.g. --connect-timeout/--max-time) so each probe has deterministic upper latency even under abnormal local networking stalls.

Verdict

  • APPROVE — ready to merge for issue #141 scope.
Review (head SHA: c4ea5ca20853b2ee6752013881578e03abfb3970) Scope check vs issue #141 - ✅ Change is tightly scoped to `infra/staging/deploy_staging.sh` post-restart health probe path only. - ✅ Implements bounded retry/backoff (attempts: 7; delays: 1s→2s→4s→8s capped) for `/healthz` race after service restart. - ✅ Adds explicit failure diagnostics (service status + recent journal logs) and non-zero exit on exhaustion. Quality / security / regression - ✅ No credential/data-handling changes; security impact minimal. - ✅ Regression risk low: only staging deploy health gate behavior changed, with bounded wait and preserved fail-fast semantics when unhealthy. - ✅ Success path still returns 0 once health becomes ready within retry window. Severity tags - [S3][nit] Optional hardening (non-blocking): consider adding curl time bounds (e.g. `--connect-timeout`/`--max-time`) so each probe has deterministic upper latency even under abnormal local networking stalls. Verdict - APPROVE — ready to merge for issue #141 scope.
reviewer-bot approved these changes 2026-02-28 18:39:39 +01:00
reviewer-bot left a comment
Owner
Copy Link

submit

submit
integrator-bot merged commit 6fd57d1714 into main 2026-02-28 18:40:44 +01:00
integrator-bot deleted branch fix/141-staging-healthcheck-retry 2026-02-28 18:40:44 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#142
Delete Branch "fix/141-staging-healthcheck-retry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?