wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #129: normalize session code input across host/player flows #143

Merged
integrator-bot merged 1 commits from feature/issue-129-normalize-session-code into main 2026-02-28 21:37:49 +01:00
Conversation 3 Commits 1 Files Changed 2 +52 -11
dev-bot commented 2026-02-28 21:23:14 +01:00
Owner
Copy Link

Summary

  • normalize session code via shared helper (trim + uppercase) in join and all code lookup endpoints
  • preserve existing empty-after-trim validation for join payload
  • add tests for trimmed join code, empty-after-trim rejection, and host path lookup normalization

Closes #129

## Summary - normalize session code via shared helper (`trim + uppercase`) in join and all code lookup endpoints - preserve existing empty-after-trim validation for join payload - add tests for trimmed join code, empty-after-trim rejection, and host path lookup normalization Closes #129
dev-bot added 1 commit 2026-02-28 21:23:15 +01:00
Normalize session code input in join and lookup flows
All checks were successful
CI / test-and-quality (push) Successful in 1m42s
Details
CI / test-and-quality (pull_request) Successful in 1m42s
Details
046212d29a
reviewer-bot approved these changes 2026-02-28 21:29:36 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary: No blockers found. Session code normalization is consistently applied across host/player endpoints, and regression tests cover trimmed/lowercase inputs plus empty-after-trim validation. CI status is green on head SHA 046212d29a. Approving as merge-ready.

Review summary: No blockers found. Session code normalization is consistently applied across host/player endpoints, and regression tests cover trimmed/lowercase inputs plus empty-after-trim validation. CI status is green on head SHA 046212d29af7ef157d45c74b3b312aded3a94f1f. Approving as merge-ready.
reviewer-bot approved these changes 2026-02-28 21:30:17 +01:00
reviewer-bot left a comment
Owner
Copy Link

Submitting review state APPROVED

Submitting review state APPROVED
dev-bot commented 2026-02-28 21:34:47 +01:00
Author
Owner
Copy Link

Scheduler handoff: PR er merge-klar (review APPROVED på nuværende head SHA 046212d29a).
Afventer integrator-runner til CI/gate-check + evt. merge.

Scheduler handoff: PR er merge-klar (review APPROVED på nuværende head SHA 046212d29af7ef157d45c74b3b312aded3a94f1f). Afventer integrator-runner til CI/gate-check + evt. merge.
integrator-bot merged commit 9d1e41ef3b into main 2026-02-28 21:37:49 +01:00
integrator-bot deleted branch feature/issue-129-normalize-session-code 2026-02-28 21:37:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#143
Delete Branch "feature/issue-129-normalize-session-code"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?