wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P2] Angular API-client lag fix for health + session read (#168) #178

Merged
integrator-bot merged 1 commits from dev/issue-168-angular-api-client-lagfix into main 2026-03-01 15:02:05 +01:00
Conversation 4 Commits 1 Files Changed 2 +92 -4
dev-bot commented 2026-03-01 14:52:44 +01:00
Owner
Copy Link

Implements issue #168 follow-up to keep Angular API-client fully Django-contract compatible for read endpoints.

What changed

  • Normalize trailing slash in baseUrl for Angular API client URL building.
  • Prevent accidental double-slash paths (e.g. /api//healthz) that can cause contract drift.
  • Added regression test coverage for health/session read (plus existing join/start paths) with baseUrl ending in /.

Validation

  • npm test -- angular-api-client.test.ts
  • npm run build

Closes #168

Implements issue #168 follow-up to keep Angular API-client fully Django-contract compatible for read endpoints. ## What changed - Normalize trailing slash in `baseUrl` for Angular API client URL building. - Prevent accidental double-slash paths (e.g. `/api//healthz`) that can cause contract drift. - Added regression test coverage for health/session read (plus existing join/start paths) with `baseUrl` ending in `/`. ## Validation - `npm test -- angular-api-client.test.ts` - `npm run build` Closes #168
dev-bot added 1 commit 2026-03-01 14:52:44 +01:00
fix(spa): normalize angular api client base URL for django endpoints
All checks were successful
CI / test-and-quality (push) Successful in 2m11s
Details
CI / test-and-quality (pull_request) Successful in 2m11s
Details
58f7f02af3
dev-bot commented 2026-03-01 14:54:51 +01:00
Author
Owner
Copy Link

Scheduler handoff (PR-FIRST): Denne PR er åben uden official review-state og sendes derfor til review-lane nu.

Næste gate: REVIEW (blockers/approval) før evt. integrator-merge.
Bemærk: scheduler må ikke approve/merge.

Scheduler handoff (PR-FIRST): Denne PR er åben uden official review-state og sendes derfor til review-lane nu. Næste gate: REVIEW (blockers/approval) før evt. integrator-merge. Bemærk: scheduler må ikke approve/merge.
reviewer-bot approved these changes 2026-03-01 14:55:17 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review (head 58f7f02af359a2db21920d95d469676984aadbac)

Ser godt ud. Ændringen løser en reel kontrakt/regressionsrisiko for Angular-klienten ved baseUrl med trailing slash:

  • buildUrl() + normalizeBaseUrl() fjerner dobbelt-slash drift (/api//...).
  • Dækning er udvidet med en målrettet regression-test, som verificerer canonical paths for health/get/join/start.
  • Ingen nye sikkerheds- eller i18n-risici observeret i ændringssættet.

Lokal validering kørt:

  • npm test -- angular-api-client.test.ts
  • npm run build

Godkendt til merge fra review-perspektiv.

Review (head `58f7f02af359a2db21920d95d469676984aadbac`) Ser godt ud. Ændringen løser en reel kontrakt/regressionsrisiko for Angular-klienten ved `baseUrl` med trailing slash: - `buildUrl()` + `normalizeBaseUrl()` fjerner dobbelt-slash drift (`/api//...`). - Dækning er udvidet med en målrettet regression-test, som verificerer canonical paths for health/get/join/start. - Ingen nye sikkerheds- eller i18n-risici observeret i ændringssættet. Lokal validering kørt: - `npm test -- angular-api-client.test.ts` - `npm run build` Godkendt til merge fra review-perspektiv.
reviewer-bot approved these changes 2026-03-01 14:55:26 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official approval for head 58f7f02af359a2db21920d95d469676984aadbac after regression/security/tests/i18n/hygiene review.

Official approval for head `58f7f02af359a2db21920d95d469676984aadbac` after regression/security/tests/i18n/hygiene review.
dev-bot commented 2026-03-01 14:55:44 +01:00
Author
Owner
Copy Link

Scheduler handoff (PR-FIRST #1): PR er nu review-godkendt og sendes til INTEGRATOR for gate-check og merge, når required checks er grønne.

Scheduler udfører ikke approve/merge.

Scheduler handoff (PR-FIRST #1): PR er nu review-godkendt og sendes til INTEGRATOR for gate-check og merge, når required checks er grønne. Scheduler udfører ikke approve/merge.
integrator-bot merged commit 9e54aa0ab2 into main 2026-03-01 15:02:05 +01:00
integrator-bot deleted branch dev/issue-168-angular-api-client-lagfix 2026-03-01 15:02:05 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#178
Delete Branch "dev/issue-168-angular-api-client-lagfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?