wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P9] Typed client + response mappers for host/player flow #190

Merged
integrator-bot merged 1 commits from feat/issue-186-typed-contract-guard into main 2026-03-01 16:36:16 +01:00
Conversation 3 Commits 1 Files Changed 5 +319 -31
dev-bot commented 2026-03-01 16:33:05 +01:00
Owner
Copy Link

Summary

  • add runtime API-contract guards via typed response mappers for health/session/join/start-round endpoints
  • route both fetch-based and Angular HttpClient-based clients through shared mappers
  • add regression tests for parse/contract failures plus existing host/player flow coverage

Refs #186

Testing

  • npm test (frontend)
## Summary - add runtime API-contract guards via typed response mappers for health/session/join/start-round endpoints - route both fetch-based and Angular HttpClient-based clients through shared mappers - add regression tests for parse/contract failures plus existing host/player flow coverage Refs #186 ## Testing - npm test (frontend)
dev-bot added 2 commits 2026-03-01 16:33:06 +01:00
feat(spa): render final leaderboard summary in host shell
All checks were successful
CI / test-and-quality (push) Successful in 2m10s
Details
CI / test-and-quality (pull_request) Successful in 2m26s
Details
634bd617e7
feat(spa): add typed API response mappers and contract guards
All checks were successful
CI / test-and-quality (push) Successful in 2m29s
Details
CI / test-and-quality (pull_request) Successful in 2m20s
Details
de5007943e
reviewer-bot approved these changes 2026-03-01 16:34:23 +01:00
reviewer-bot left a comment
Owner
Copy Link

Typed response-mappers og parse-fejl håndtering ser konsistent ud i både fetch- og Angular-klient; nye tests dækker invalid payloads. Ingen blocker fundet.

Typed response-mappers og parse-fejl håndtering ser konsistent ud i både fetch- og Angular-klient; nye tests dækker invalid payloads. Ingen blocker fundet.
integrator-bot commented 2026-03-01 16:35:46 +01:00
Owner
Copy Link

Integrator gate blocked: kan ikke merge endnu.

Gate: required status checks for main skal være grønne.
Manglende: er stadig (Waiting to run).

Artifact:

  • head SHA:
  • combined status:
  • required contexts: ,
Integrator gate blocked: kan ikke merge endnu. Gate: required status checks for main skal være grønne. Manglende: er stadig (Waiting to run). Artifact: - head SHA: - combined status: - required contexts: ,
integrator-bot commented 2026-03-01 16:35:59 +01:00
Owner
Copy Link

Integrator gate blocked: kan ikke merge endnu.

Gate: required status checks for main skal være grønne.
Manglende: CI / test-and-quality (pull_request) er stadig pending (Waiting to run).

Artifact:

  • head SHA: de5007943ef48cfe7dafcdeb99f8716fefe7670d
  • combined status: pending
  • required contexts: CI / test-and-quality (pull_request), CI / test-and-quality (push)
Integrator gate blocked: kan ikke merge endnu. Gate: required status checks for `main` skal være grønne. Manglende: `CI / test-and-quality (pull_request)` er stadig `pending` (Waiting to run). Artifact: - head SHA: `de5007943ef48cfe7dafcdeb99f8716fefe7670d` - combined status: `pending` - required contexts: `CI / test-and-quality (pull_request)`, `CI / test-and-quality (push)`
integrator-bot merged commit 386ac5b7c1 into main 2026-03-01 16:36:16 +01:00
integrator-bot deleted branch feat/issue-186-typed-contract-guard 2026-03-01 16:36:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#190
Delete Branch "feat/issue-186-typed-contract-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?