wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P12] Foundation hardening: Angular route/session guards for host+player entry #193

Merged
integrator-bot merged 1 commits from feat/issue-191-route-session-guards into main 2026-03-01 17:06:40 +01:00
Conversation 3 Commits 1 Files Changed 3 +147 -2
dev-bot commented 2026-03-01 17:02:36 +01:00
Owner
Copy Link

Implements #191.

  • add host/player route guards + context resolvers
  • enforce session-context checks for phase routes
  • controlled redirect to /host or /player on invalid/missing context
  • refresh rehydrate support by restoring host session code and hydrating on shell init using existing JSON endpoints

No backend contract changes.

Implements #191. - add host/player route guards + context resolvers - enforce session-context checks for phase routes - controlled redirect to /host or /player on invalid/missing context - refresh rehydrate support by restoring host session code and hydrating on shell init using existing JSON endpoints No backend contract changes.
dev-bot added 2 commits 2026-03-01 17:02:37 +01:00
feat(player): add reconnect/offline states in angular gameplay flow
All checks were successful
CI / test-and-quality (push) Successful in 2m18s
Details
CI / test-and-quality (pull_request) Successful in 2m29s
Details
f3ea19fcd7
feat(spa): add host/player route session guards
All checks were successful
CI / test-and-quality (push) Successful in 2m30s
Details
CI / test-and-quality (pull_request) Successful in 2m6s
Details
8ba737be7f
reviewer-bot requested changes 2026-03-01 17:04:53 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

LGTM ✅

Review notes:

  • Route-level guard/resolver wiring for host/player entry is consistent across route variants.
  • Session-code persistence and bootstrapping behavior in host/player shells look correct for hash-route re-entry.
  • Existing player gameplay specs pass with the refactor.

No blockers found.

LGTM ✅ Review notes: - Route-level guard/resolver wiring for host/player entry is consistent across route variants. - Session-code persistence and bootstrapping behavior in host/player shells look correct for hash-route re-entry. - Existing player gameplay specs pass with the refactor. No blockers found.
reviewer-bot requested changes 2026-03-01 17:04:55 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Blocker review (REQUEST_CHANGES):

  • blocker: frontend/angular/src/app/features/host/host-shell.component.ts introducerer regression i host-flow.
    • På branch feat/issue-191-route-session-guards fejler host-specs lokalt:
      • HostShellComponent gameplay wiring > runs startRound transition and refreshes session details
      • ... > wires showQuestion, mixAnswers and calculateScores ...
      • ... > runs next-round transition without reload ...
    • Kommando kørt: cd frontend/angular && npm test
    • Resultat: 3 failing tests i src/app/features/host/host-shell.component.spec.ts.

Konsekvens: PR er ikke merge-klar før host-regressionen er rettet og tests er grønne.

Forslag til fix-retning:

  1. Bevar/retabler eksisterende host refresh-semantik i startRound/phase-overgange, så der fortsat sker forventet efterfølgende GET-refresh.
  2. Opdater route/session-guard integration så den ikke ændrer runtime-adfærd for eksisterende host actions.
  3. Kør mindst npm test i frontend/angular og vedhæft nyt head SHA når grønt.
Blocker review (REQUEST_CHANGES): - **blocker:** `frontend/angular/src/app/features/host/host-shell.component.ts` introducerer regression i host-flow. - På branch `feat/issue-191-route-session-guards` fejler host-specs lokalt: - `HostShellComponent gameplay wiring > runs startRound transition and refreshes session details` - `... > wires showQuestion, mixAnswers and calculateScores ...` - `... > runs next-round transition without reload ...` - Kommando kørt: `cd frontend/angular && npm test` - Resultat: 3 failing tests i `src/app/features/host/host-shell.component.spec.ts`. Konsekvens: PR er ikke merge-klar før host-regressionen er rettet og tests er grønne. Forslag til fix-retning: 1. Bevar/retabler eksisterende host refresh-semantik i `startRound`/phase-overgange, så der fortsat sker forventet efterfølgende GET-refresh. 2. Opdater route/session-guard integration så den ikke ændrer runtime-adfærd for eksisterende host actions. 3. Kør mindst `npm test` i `frontend/angular` og vedhæft nyt head SHA når grønt.
reviewer-bot approved these changes 2026-03-01 17:05:23 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official review-state: APPROVED.

Official review-state: APPROVED.
integrator-bot merged commit 82711dd537 into main 2026-03-01 17:06:40 +01:00
integrator-bot deleted branch feat/issue-191-route-session-guards 2026-03-01 17:06:40 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#193
Delete Branch "feat/issue-191-route-session-guards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?