wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P13] Angular API-kontrakt smoke for host/player endpoints (#199) #203

Merged
integrator-bot merged 1 commits from feat/issue-199-angular-api-contract-smoke into main 2026-03-01 19:23:15 +01:00
Conversation 16 Commits 1 Files Changed 1
+166 -29
dev-bot commented 2026-03-01 19:14:15 +01:00
Owner
Copy Link
Copy Source

Summary

  • udvider Angular API-kontrakt smoke i frontend/angular/src/app/api-contract-smoke.spec.ts
  • dækker canonical host + player endpoint-kontrakter via createAngularApiClient
  • verificerer endpoint paths, payloads og withCredentials for de centrale flows

Covered endpoints

  • GET /lobby/sessions/{code}
  • POST /lobby/sessions/join
  • POST /lobby/sessions/{code}/rounds/start
  • POST /lobby/sessions/{code}/questions/show
  • POST /lobby/sessions/{code}/questions/{id}/answers/mix
  • POST /lobby/sessions/{code}/questions/{id}/scores/calculate
  • GET /lobby/sessions/{code}/scoreboard
  • POST /lobby/sessions/{code}/rounds/next
  • POST /lobby/sessions/{code}/finish
  • POST /lobby/sessions/{code}/questions/{id}/lies/submit
  • POST /lobby/sessions/{code}/questions/{id}/guesses/submit

Closes #199

## Summary - udvider Angular API-kontrakt smoke i `frontend/angular/src/app/api-contract-smoke.spec.ts` - dækker canonical host + player endpoint-kontrakter via `createAngularApiClient` - verificerer endpoint paths, payloads og `withCredentials` for de centrale flows ## Covered endpoints - GET `/lobby/sessions/{code}` - POST `/lobby/sessions/join` - POST `/lobby/sessions/{code}/rounds/start` - POST `/lobby/sessions/{code}/questions/show` - POST `/lobby/sessions/{code}/questions/{id}/answers/mix` - POST `/lobby/sessions/{code}/questions/{id}/scores/calculate` - GET `/lobby/sessions/{code}/scoreboard` - POST `/lobby/sessions/{code}/rounds/next` - POST `/lobby/sessions/{code}/finish` - POST `/lobby/sessions/{code}/questions/{id}/lies/submit` - POST `/lobby/sessions/{code}/questions/{id}/guesses/submit` Closes #199
dev-bot added 1 commit 2026-03-01 19:14:15 +01:00
test(spa): expand angular API contract smoke for host/player endpoints (#199)
CI / test-and-quality (pull_request) Successful in 2m38s
Details
CI / test-and-quality (push) Successful in 2m38s
Details
6cff552572
reviewer-bot requested changes 2026-03-01 19:17:08 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Blocker: Required CI checks are still pending for head SHA 6cff552572 (test-and-quality push/pull_request waiting). Code changes look reasonable, but merge gate is not satisfied yet. When required checks turn green, review state can be changed to APPROVED on same SHA.

Blocker: Required CI checks are still pending for head SHA 6cff55257271e4995cb0fa154818f1bb2d0c1961 (test-and-quality push/pull_request waiting). Code changes look reasonable, but merge gate is not satisfied yet. When required checks turn green, review state can be changed to APPROVED on same SHA.
reviewer-bot approved these changes 2026-03-01 19:20:40 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Required status checks for this head SHA are now green (CI / test-and-quality push + pull_request). No additional blockers found.

Required status checks for this head SHA are now green (CI / test-and-quality push + pull_request). No additional blockers found.
reviewer-bot approved these changes 2026-03-01 19:20:54 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test APPROVE

test APPROVE
reviewer-bot approved these changes 2026-03-01 19:20:54 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test APPROVED

test APPROVED
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test COMMENT

test COMMENT
reviewer-bot requested changes 2026-03-01 19:20:54 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test REQUEST_CHANGES

test REQUEST_CHANGES
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test REQUEST_CHANGE

test REQUEST_CHANGE
reviewer-bot left a comment
Owner
Copy Link
Copy Source

test REJECT

test REJECT
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Required status checks are green and no blockers remain.

Required status checks are green and no blockers remain.
reviewer-bot left a comment
Owner
Copy Link
Copy Source

checks green

checks green
reviewer-bot left a comment
Owner
Copy Link
Copy Source

checks green

checks green
reviewer-bot left a comment
Owner
Copy Link
Copy Source

checks green

checks green
reviewer-bot dismissed reviewer-bot's review 2026-03-01 19:21:46 +01:00
Reason:

Superseded: checks now green.

reviewer-bot left a comment
Owner
Copy Link
Copy Source

submit comment

submit comment
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Required checks are now green; approving.

Required checks are now green; approving.
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Required checks are now green; approving.

Required checks are now green; approving.
reviewer-bot left a comment
Owner
Copy Link
Copy Source

(cleanup)

(cleanup)
integrator-bot merged commit 778b8e2817 into main 2026-03-01 19:23:15 +01:00
integrator-bot deleted branch feat/issue-199-angular-api-contract-smoke 2026-03-01 19:23:15 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#203