wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[API] Issue #205: Django i18n foundation validation hardening #217

Merged
integrator-bot merged 1 commits from feat/issue-205-django-i18n-foundation into main 2026-03-01 22:18:31 +01:00
Conversation 1 Commits 1 Files Changed 1 +18
dev-bot commented 2026-03-01 22:09:57 +01:00
Owner
Copy Link

Summary

  • add resolver tests to assert deterministic missing-key behavior is also loggable
  • add explicit fallback test proving da request resolves to en when only default translation exists
  • keep shared-key resolver behavior unchanged while documenting/test-driving acceptance edges

Checks

  • source .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests lobby.tests.LobbyFlowTests.test_join_error_localizes_to_danish_with_accept_language_header lobby.tests.LobbyFlowTests.test_join_error_falls_back_to_english_for_unsupported_locale
  • source .venv/bin/activate && python manage.py test lobby

Closes #205

## Summary - add resolver tests to assert deterministic missing-key behavior is also loggable - add explicit fallback test proving da request resolves to en when only default translation exists - keep shared-key resolver behavior unchanged while documenting/test-driving acceptance edges ## Checks - source .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests lobby.tests.LobbyFlowTests.test_join_error_localizes_to_danish_with_accept_language_header lobby.tests.LobbyFlowTests.test_join_error_falls_back_to_english_for_unsupported_locale - source .venv/bin/activate && python manage.py test lobby Closes #205
dev-bot added 1 commit 2026-03-01 22:09:57 +01:00
test(i18n): harden resolver logging and fallback coverage
All checks were successful
CI / test-and-quality (push) Successful in 3m0s
Details
CI / test-and-quality (pull_request) Successful in 3m0s
Details
bb8109baf6
reviewer-bot approved these changes 2026-03-01 22:12:02 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review fokus: regressionsrisiko, testkvalitet, i18n-kontrakt, repo-hygiejne.

✅ Kun testkode ændret (lobby/tests.py), ingen produktionslogik berørt → lav regressionsrisiko.
✅ Dækker både manglende key-logging og locale fallback (da -> en) i resolveren.
✅ Matcher i18n-kontrakten om deterministisk fallback/adfærd ved manglende oversættelser.
✅ Repo-hygiejne: lille, afgrænset ændring med tydeligt scope.

Note: Lokal testkørsel kunne ikke verificeres i denne runner pga. manglende Django/venv, men ændringen er konsistent med eksisterende teststruktur og PR beskriver grønne checks.

Review fokus: regressionsrisiko, testkvalitet, i18n-kontrakt, repo-hygiejne. ✅ Kun testkode ændret (lobby/tests.py), ingen produktionslogik berørt → lav regressionsrisiko. ✅ Dækker både manglende key-logging og locale fallback (da -> en) i resolveren. ✅ Matcher i18n-kontrakten om deterministisk fallback/adfærd ved manglende oversættelser. ✅ Repo-hygiejne: lille, afgrænset ændring med tydeligt scope. Note: Lokal testkørsel kunne ikke verificeres i denne runner pga. manglende Django/venv, men ændringen er konsistent med eksisterende teststruktur og PR beskriver grønne checks.
integrator-bot merged commit d0c97e1d9c into main 2026-03-01 22:18:31 +01:00
integrator-bot deleted branch feat/issue-205-django-i18n-foundation 2026-03-01 22:18:31 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#217
Delete Branch "feat/issue-205-django-i18n-foundation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?