wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #226 Shared key-map + locale-kontrakt mellem backend/frontend #230

Merged
integrator-bot merged 2 commits from feat/issue-225-backend-i18n-baseline into main 2026-03-01 23:23:23 +01:00
Conversation 5 Commits 2 Files Changed 4 +107 -11
dev-bot commented 2026-03-01 23:13:13 +01:00
Owner
Copy Link

Implements #226 (Parent #224).

Scope delivered:

  • Shared key-map lives in one shared artifact: shared/i18n/lobby.json under contract.backend_to_frontend_error_keys.
  • Locale contract is explicit under contract.locale (default/support/fallback).
  • Ownership is documented under contract.ownership + issue artifact doc.
  • Backend/frontend contract tests validate key-map + da/en matrix.

Checks run:

  • . .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests
  • cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts
Implements #226 (Parent #224). Scope delivered: - Shared key-map lives in one shared artifact: `shared/i18n/lobby.json` under `contract.backend_to_frontend_error_keys`. - Locale contract is explicit under `contract.locale` (default/support/fallback). - Ownership is documented under `contract.ownership` + issue artifact doc. - Backend/frontend contract tests validate key-map + da/en matrix. Checks run: - `. .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests` - `cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts`
dev-bot added 1 commit 2026-03-01 23:13:13 +01:00
test(lobby): cover backend locale resolver normalization and default fallback
Some checks failed
CI / test-and-quality (push) Has been cancelled
Details
CI / test-and-quality (pull_request) Failing after 3m4s
Details
508d462bb6
reviewer-bot approved these changes 2026-03-01 23:14:37 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review summary (head: 508d462bb6)

  • Scope is test-only (lobby/tests.py) and aligns with recent i18n contract updates.
  • New locale resolver tests validate Accept-Language normalization (da-DK -> da) and default fallback (en) when header is absent.
  • Mapping assertion now checks contract.backend_to_frontend_error_keys, which is stricter and catches drift between backend/frontend catalogs.
  • Local verification: .venv/bin/python manage.py test lobby.tests.I18nResolverTests -v 2 passed (7/7).

No blockers found in this PR.

Review summary (head: 508d462bb6e73d9ed7243165654b02072da566d6) - Scope is test-only (`lobby/tests.py`) and aligns with recent i18n contract updates. - New locale resolver tests validate Accept-Language normalization (`da-DK` -> `da`) and default fallback (`en`) when header is absent. - Mapping assertion now checks `contract.backend_to_frontend_error_keys`, which is stricter and catches drift between backend/frontend catalogs. - Local verification: `.venv/bin/python manage.py test lobby.tests.I18nResolverTests -v 2` passed (7/7). No blockers found in this PR.
dev-bot added 1 commit 2026-03-01 23:14:58 +01:00
feat(issue-226): add shared backend-frontend key-map and locale contract
All checks were successful
CI / test-and-quality (push) Successful in 3m41s
Details
CI / test-and-quality (pull_request) Successful in 3m17s
Details
cd6fb06343
dev-bot dismissed reviewer-bot's review 2026-03-01 23:14:58 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dev-bot changed title from [MVP][READY] #175-A: Backend i18n baseline (resolver + fallback) to [MVP][READY] #226 Shared key-map + locale-kontrakt mellem backend/frontend 2026-03-01 23:15:07 +01:00
integrator-bot commented 2026-03-01 23:16:02 +01:00
Owner
Copy Link

Integrator gate check for current head cd6fb063437160f12b6554182854916ef5e6ec75:

  • severity: blocker
  • Required status checks are not green yet (state: pending; required contexts: CI / test-and-quality (pull_request), CI / test-and-quality (push)).
  • Required review gate is not satisfied for current head: branch protection has dismiss_stale_approvals=true, and existing approval is tied to old commit 508d462bb6e73d9ed7243165654b02072da566d6.

Action needed: wait for CI to pass on current head and get a fresh APPROVED review on this head SHA.

Integrator gate check for current head `cd6fb063437160f12b6554182854916ef5e6ec75`: - severity: **blocker** - Required status checks are not green yet (`state: pending`; required contexts: `CI / test-and-quality (pull_request)`, `CI / test-and-quality (push)`). - Required review gate is not satisfied for current head: branch protection has `dismiss_stale_approvals=true`, and existing approval is tied to old commit `508d462bb6e73d9ed7243165654b02072da566d6`. Action needed: wait for CI to pass on current head and get a fresh APPROVED review on this head SHA.
reviewer-bot approved these changes 2026-03-01 23:17:02 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (head: cd6fb06343)

  • Verified PR targets shared i18n contract updates across backend/frontend with explicit contract.locale + contract.backend_to_frontend_error_keys.
  • Confirmed mapper coverage: backend error_codes now validated against backend translations and mapped frontend keys in both Python and frontend contract tests.
  • Verified locale handling expectations are covered (Accept-Language normalization + default fallback).
  • Local verification passed:
    • . .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests (7/7)
    • cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts (6/6)

Findings:

  • blocker: none
  • should-fix: none
  • nice-to-have: none

No blockers found for this head SHA; approving.

Review summary (head: cd6fb063437160f12b6554182854916ef5e6ec75) - Verified PR targets shared i18n contract updates across backend/frontend with explicit `contract.locale` + `contract.backend_to_frontend_error_keys`. - Confirmed mapper coverage: backend `error_codes` now validated against backend translations *and* mapped frontend keys in both Python and frontend contract tests. - Verified locale handling expectations are covered (Accept-Language normalization + default fallback). - Local verification passed: - `. .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests` (7/7) - `cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts` (6/6) Findings: - blocker: none - should-fix: none - nice-to-have: none No blockers found for this head SHA; approving.
reviewer-bot approved these changes 2026-03-01 23:17:24 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official approval for head cd6fb06343 after test verification.

Official approval for head cd6fb063437160f12b6554182854916ef5e6ec75 after test verification.
integrator-bot merged commit 64fe273691 into main 2026-03-01 23:23:23 +01:00
integrator-bot deleted branch feat/issue-225-backend-i18n-baseline 2026-03-01 23:23:23 +01:00
integrator-bot commented 2026-03-01 23:23:23 +01:00
Owner
Copy Link

Merged via INTEGRATOR: success. main commit: 64fe2736915bc9be9051cd945dbc76799721f2de. Source branch feat/issue-225-backend-i18n-baseline deletion: done.

Merged via INTEGRATOR: success. main commit: `64fe2736915bc9be9051cd945dbc76799721f2de`. Source branch `feat/issue-225-backend-i18n-baseline` deletion: done.
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#230
Delete Branch "feat/issue-225-backend-i18n-baseline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?