Scope is test-only (lobby/tests.py) and aligns with recent i18n contract updates.
New locale resolver tests validate Accept-Language normalization (da-DK -> da) and default fallback (en) when header is absent.
Mapping assertion now checks contract.backend_to_frontend_error_keys, which is stricter and catches drift between backend/frontend catalogs.
Local verification: .venv/bin/python manage.py test lobby.tests.I18nResolverTests -v 2 passed (7/7).
No blockers found in this PR.
Review summary (head: 508d462bb6e73d9ed7243165654b02072da566d6)
- Scope is test-only (`lobby/tests.py`) and aligns with recent i18n contract updates.
- New locale resolver tests validate Accept-Language normalization (`da-DK` -> `da`) and default fallback (`en`) when header is absent.
- Mapping assertion now checks `contract.backend_to_frontend_error_keys`, which is stricter and catches drift between backend/frontend catalogs.
- Local verification: `.venv/bin/python manage.py test lobby.tests.I18nResolverTests -v 2` passed (7/7).
No blockers found in this PR.
Integrator gate check for current head cd6fb063437160f12b6554182854916ef5e6ec75:
severity: blocker
Required status checks are not green yet (state: pending; required contexts: CI / test-and-quality (pull_request), CI / test-and-quality (push)).
Required review gate is not satisfied for current head: branch protection has dismiss_stale_approvals=true, and existing approval is tied to old commit 508d462bb6e73d9ed7243165654b02072da566d6.
Action needed: wait for CI to pass on current head and get a fresh APPROVED review on this head SHA.
Integrator gate check for current head `cd6fb063437160f12b6554182854916ef5e6ec75`:
- severity: **blocker**
- Required status checks are not green yet (`state: pending`; required contexts: `CI / test-and-quality (pull_request)`, `CI / test-and-quality (push)`).
- Required review gate is not satisfied for current head: branch protection has `dismiss_stale_approvals=true`, and existing approval is tied to old commit `508d462bb6e73d9ed7243165654b02072da566d6`.
Action needed: wait for CI to pass on current head and get a fresh APPROVED review on this head SHA.
Verified PR targets shared i18n contract updates across backend/frontend with explicit contract.locale + contract.backend_to_frontend_error_keys.
Confirmed mapper coverage: backend error_codes now validated against backend translations and mapped frontend keys in both Python and frontend contract tests.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
reviewer-bot
Implements #226 (Parent #224).
Scope delivered:
shared/i18n/lobby.jsonundercontract.backend_to_frontend_error_keys.contract.locale(default/support/fallback).contract.ownership+ issue artifact doc.Checks run:
. .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTestscd frontend && npm test -- --run tests/lobby-i18n.contract.test.tsReview summary (head:
508d462bb6)lobby/tests.py) and aligns with recent i18n contract updates.da-DK->da) and default fallback (en) when header is absent.contract.backend_to_frontend_error_keys, which is stricter and catches drift between backend/frontend catalogs..venv/bin/python manage.py test lobby.tests.I18nResolverTests -v 2passed (7/7).No blockers found in this PR.
New commits pushed, approval review dismissed automatically according to repository settings
[MVP][READY] #175-A: Backend i18n baseline (resolver + fallback)to [MVP][READY] #226 Shared key-map + locale-kontrakt mellem backend/frontendIntegrator gate check for current head
cd6fb063437160f12b6554182854916ef5e6ec75:state: pending; required contexts:CI / test-and-quality (pull_request),CI / test-and-quality (push)).dismiss_stale_approvals=true, and existing approval is tied to old commit508d462bb6e73d9ed7243165654b02072da566d6.Action needed: wait for CI to pass on current head and get a fresh APPROVED review on this head SHA.
Review summary (head:
cd6fb06343)contract.locale+contract.backend_to_frontend_error_keys.error_codesnow validated against backend translations and mapped frontend keys in both Python and frontend contract tests.. .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests(7/7)cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts(6/6)Findings:
No blockers found for this head SHA; approving.
Official approval for head
cd6fb06343after test verification.Merged via INTEGRATOR: success. main commit:
64fe2736915bc9be9051cd945dbc76799721f2de. Source branchfeat/issue-225-backend-i18n-baselinedeletion: done.