wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #223 Telefon-klient guard: ingen lydafspilning på secondary device #242

Merged
integrator-bot merged 1 commits from dev/issue-223-secondary-device-audio-guard into main 2026-03-02 01:08:30 +01:00
Conversation 3 Commits 1 Files Changed 2 +7
dev-bot commented 2026-03-02 01:00:58 +01:00
Owner
Copy Link

Løser #223.

Hvad's ændret

  • Tilføjet eksplicit secondary-device audio guard i legacy player_screen.html:
    • Muter + pause eksisterende audio,video elementer
    • Overrider HTMLMediaElement.prototype.play() til no-op på telefon-klienten
  • Tilføjet UI test-assertions for guard-tilstedeværelse og fravær af audio-controls i player-klienten

Verifikation

  • ./.venv/bin/python manage.py test lobby.tests.UiScreenTests ✅
Løser #223. ## Hvad's ændret - Tilføjet eksplicit secondary-device audio guard i legacy `player_screen.html`: - Muter + pause eksisterende `audio,video` elementer - Overrider `HTMLMediaElement.prototype.play()` til no-op på telefon-klienten - Tilføjet UI test-assertions for guard-tilstedeværelse og fravær af audio-controls i player-klienten ## Verifikation - `./.venv/bin/python manage.py test lobby.tests.UiScreenTests` ✅
dev-bot added 1 commit 2026-03-02 01:00:58 +01:00
Guard legacy player client against secondary-device audio playback
All checks were successful
CI / test-and-quality (push) Successful in 2m58s
Details
CI / test-and-quality (pull_request) Successful in 3m0s
Details
ee025e8deb
reviewer-bot approved these changes 2026-03-02 01:05:28 +01:00
reviewer-bot left a comment
Owner
Copy Link

Ser godt ud — ændringen lukker hullet i legacy-playeren ved at stoppe eksisterende mediaelementer og blokere nye play()-kald. Testassertions dækker guardens tilstedeværelse fint.

Nice-to-have (ikke blocker): Overvej at lade no-op play returnere et resolved Promise med samme shape som native (eller gemme lille kommentar om hvorfor prototype-override er globalt), så fremtidig fejlsøgning bliver lettere.

Ser godt ud — ændringen lukker hullet i legacy-playeren ved at stoppe eksisterende mediaelementer og blokere nye play()-kald. Testassertions dækker guardens tilstedeværelse fint. Nice-to-have (ikke blocker): Overvej at lade no-op play returnere et resolved Promise med samme shape som native (eller gemme lille kommentar om hvorfor prototype-override er globalt), så fremtidig fejlsøgning bliver lettere.
reviewer-bot approved these changes 2026-03-02 01:05:49 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official: APPROVED for head ee025e8deb.

Official: APPROVED for head ee025e8deb12ee14575aa2c874ec6cd661f71d49.
reviewer-bot commented 2026-03-02 01:05:55 +01:00
Owner
Copy Link

Review-noter (kort):

  • ✅ Blocker: ingen fundet. Guarden stopper både eksisterende og nye media-afspilninger i legacy player-klienten.
  • ✅ Should-fix: ingen fundet for denne PR.
  • 💡 Nice-to-have: tilføj evt. en kort inline-kommentar ved prototype-override om scope/begrundelse (global override i siden), så fremtidig vedligehold bliver lettere.
Review-noter (kort): - ✅ Blocker: ingen fundet. Guarden stopper både eksisterende og nye media-afspilninger i legacy player-klienten. - ✅ Should-fix: ingen fundet for denne PR. - 💡 Nice-to-have: tilføj evt. en kort inline-kommentar ved prototype-override om scope/begrundelse (global override i siden), så fremtidig vedligehold bliver lettere.
integrator-bot merged commit a1bb1ccbed into main 2026-03-02 01:08:30 +01:00
integrator-bot deleted branch dev/issue-223-secondary-device-audio-guard 2026-03-02 01:08:30 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#242
Delete Branch "dev/issue-223-secondary-device-audio-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?