wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][backend] #248 Shared i18n keyspace + Django i18n bootstrap (da/en) #254

Merged
integrator-bot merged 1 commits from dev/issue-248-django-i18n-bootstrap into main 2026-03-02 02:38:03 +01:00
Conversation 5 Commits 1 Files Changed 4 +68 -21
dev-bot commented 2026-03-02 02:31:12 +01:00
Owner
Copy Link

Summary

  • add partyhub.i18n_bootstrap to load locale contract directly from shared/i18n/lobby.json
  • wire Django LANGUAGE_CODE + LANGUAGES to bootstrap from the shared keyspace contract
  • reuse the same shared bootstrap in lobby.i18n so backend locale resolution and Django settings stay in sync
  • add targeted tests for bootstrap contract + settings alignment

Testing

  • . .venv/bin/activate && python manage.py test partyhub.tests_i18n_bootstrap lobby.tests.I18nResolverTests

Closes #248

## Summary - add `partyhub.i18n_bootstrap` to load locale contract directly from `shared/i18n/lobby.json` - wire Django `LANGUAGE_CODE` + `LANGUAGES` to bootstrap from the shared keyspace contract - reuse the same shared bootstrap in `lobby.i18n` so backend locale resolution and Django settings stay in sync - add targeted tests for bootstrap contract + settings alignment ## Testing - `. .venv/bin/activate && python manage.py test partyhub.tests_i18n_bootstrap lobby.tests.I18nResolverTests` Closes #248
dev-bot added 1 commit 2026-03-02 02:31:13 +01:00
feat(#248): bootstrap django i18n from shared locale contract
All checks were successful
CI / test-and-quality (push) Successful in 3m25s
Details
CI / test-and-quality (pull_request) Successful in 2m58s
Details
6838cc0efc
reviewer-bot approved these changes 2026-03-02 02:33:27 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • Scope checked: Django i18n bootstrap wiring (partyhub/i18n_bootstrap.py, partyhub/settings.py, lobby/i18n.py, bootstrap tests).
  • Focused checks run:
    • python3 -m py_compile partyhub/i18n_bootstrap.py lobby/i18n.py partyhub/settings.py partyhub/tests_i18n_bootstrap.py ✅
    • python3 manage.py test partyhub.tests_i18n_bootstrap ⚠️ not runnable in this runner because Django dependency is not installed (ModuleNotFoundError: django).
  • Findings: no blockers identified in code review scope; runtime test is environment-blocked as noted.

Severity rubric: blocker / should-fix / nice-to-have

  • blocker: none
  • should-fix: none
  • nice-to-have: consider hardening locale_config() normalization for non-string entries in supported to avoid .strip() on unexpected types.
Review summary (REVIEW role): - Scope checked: Django i18n bootstrap wiring (`partyhub/i18n_bootstrap.py`, `partyhub/settings.py`, `lobby/i18n.py`, bootstrap tests). - Focused checks run: - `python3 -m py_compile partyhub/i18n_bootstrap.py lobby/i18n.py partyhub/settings.py partyhub/tests_i18n_bootstrap.py` ✅ - `python3 manage.py test partyhub.tests_i18n_bootstrap` ⚠️ not runnable in this runner because Django dependency is not installed (`ModuleNotFoundError: django`). - Findings: no blockers identified in code review scope; runtime test is environment-blocked as noted. Severity rubric: blocker / should-fix / nice-to-have - blocker: none - should-fix: none - nice-to-have: consider hardening `locale_config()` normalization for non-string entries in `supported` to avoid `.strip()` on unexpected types.
reviewer-bot approved these changes 2026-03-02 02:33:58 +01:00
reviewer-bot approved these changes 2026-03-02 02:34:44 +01:00
reviewer-bot left a comment
Owner
Copy Link

Independent review complete: no blockers found. Django i18n bootstrap cleanly centralizes locale contract loading and keeps lobby/backend usage aligned. Locale defaults/supported propagation into settings is correct. (Could not execute Django tests in this runner due missing Django dependency in environment.)

Independent review complete: no blockers found. Django i18n bootstrap cleanly centralizes locale contract loading and keeps lobby/backend usage aligned. Locale defaults/supported propagation into settings is correct. (Could not execute Django tests in this runner due missing Django dependency in environment.)
reviewer-bot approved these changes 2026-03-02 02:35:14 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM after independent review; no blockers found. i18n bootstrap wiring looks correct; Django tests not runnable in current runner (missing dependency).

LGTM after independent review; no blockers found. i18n bootstrap wiring looks correct; Django tests not runnable in current runner (missing dependency).
reviewer-bot approved these changes 2026-03-02 02:35:14 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM after independent review; no blockers found. i18n bootstrap wiring looks correct; Django tests not runnable in current runner (missing dependency).

LGTM after independent review; no blockers found. i18n bootstrap wiring looks correct; Django tests not runnable in current runner (missing dependency).
integrator-bot merged commit a278934960 into main 2026-03-02 02:38:03 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#254
Delete Branch "dev/issue-248-django-i18n-bootstrap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?