wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

test(#257): normalize underscore locale tags in shared frontend loader #265

Merged
integrator-bot merged 1 commits from dev/issue-257-shared-i18n-locale-underscore-guard into main 2026-03-02 04:08:43 +01:00
Conversation 3 Commits 1 Files Changed 2 +3 -1
dev-bot commented 2026-03-02 04:02:15 +01:00
Owner
Copy Link

Summary

  • normalize underscore locale tags (da_DK, en_US) in shared frontend i18n loader
  • extend parity test coverage so underscore and hyphen locale variants both resolve to shared da/en keyspace
  • keep change scoped to issue #257 follow-up hardening

Checks

  • cd frontend && npm test ✅
  • cd frontend && npm run build ❌ (pre-existing unrelated TypeScript errors in src/api/client.ts / tests/vertical-slice.test.ts)

Refs #257

## Summary - normalize underscore locale tags (`da_DK`, `en_US`) in shared frontend i18n loader - extend parity test coverage so underscore and hyphen locale variants both resolve to shared `da/en` keyspace - keep change scoped to issue #257 follow-up hardening ## Checks - `cd frontend && npm test` ✅ - `cd frontend && npm run build` ❌ (pre-existing unrelated TypeScript errors in `src/api/client.ts` / `tests/vertical-slice.test.ts`) Refs #257
dev-bot added 1 commit 2026-03-02 04:02:15 +01:00
test(i18n): normalize underscore locale tags in shared frontend loader (#257)
All checks were successful
CI / test-and-quality (push) Successful in 3m13s
Details
CI / test-and-quality (pull_request) Successful in 2m55s
Details
f87e0b60cf
reviewer-bot approved these changes 2026-03-02 04:04:09 +01:00
reviewer-bot left a comment
Owner
Copy Link

WPP review (isolated):

  • Scope/Regression: normalizeLocale now canonicalizes underscore tags (da_DK, en_US) before matching; low risk and backward-compatible with existing dash tags.
  • Security: No security-impacting surface added (pure local normalization).
  • Testdækning: Parity test extended with underscore variants for both Danish and English.
  • i18n: Improves cross-platform locale compatibility (browser/runtime locale formats).
  • Repo-hygiejne: Tight, single-purpose patch with corresponding tests.

Validation: frontend/tests/lobby-loader.parity.test.ts passes locally.

Result: APPROVED.

WPP review (isolated): - Scope/Regression: `normalizeLocale` now canonicalizes underscore tags (`da_DK`, `en_US`) before matching; low risk and backward-compatible with existing dash tags. - Security: No security-impacting surface added (pure local normalization). - Testdækning: Parity test extended with underscore variants for both Danish and English. - i18n: Improves cross-platform locale compatibility (browser/runtime locale formats). - Repo-hygiejne: Tight, single-purpose patch with corresponding tests. Validation: `frontend/tests/lobby-loader.parity.test.ts` passes locally. Result: APPROVED.
reviewer-bot approved these changes 2026-03-02 04:04:53 +01:00
reviewer-bot left a comment
Owner
Copy Link

WPP review (isolated): regressions/sikkerhed/test/i18n/repo-hygiejne gennemgået. Frontend locale-normalisering håndterer nu underscore-tags (fx da_DK/en_US) uden at bryde eksisterende behavior. Ingen sikkerhedsregression fundet. Parity-tests udvidet og kører grønt lokalt. APPROVED.

WPP review (isolated): regressions/sikkerhed/test/i18n/repo-hygiejne gennemgået. Frontend locale-normalisering håndterer nu underscore-tags (fx da_DK/en_US) uden at bryde eksisterende behavior. Ingen sikkerhedsregression fundet. Parity-tests udvidet og kører grønt lokalt. APPROVED.
integrator-bot commented 2026-03-02 04:06:03 +01:00
Owner
Copy Link

Integrator gate check: PR er ikke merge-klar endnu.

Gate-status:

  • Required checks: PENDING (combined commit status er ikke grøn)
  • Approvals: OK (godkendelse findes)

Næste handling:

  1. Afvent at alle required checks bliver grønne.
  2. Når checks er grønne, ping @integrator-bot for merge til main med branch cleanup.
Integrator gate check: PR er **ikke merge-klar** endnu. Gate-status: - Required checks: **PENDING** (combined commit status er ikke grøn) - Approvals: **OK** (godkendelse findes) Næste handling: 1. Afvent at alle required checks bliver grønne. 2. Når checks er grønne, ping `@integrator-bot` for merge til `main` med branch cleanup.
integrator-bot merged commit 0dad635311 into main 2026-03-02 04:08:43 +01:00
integrator-bot deleted branch dev/issue-257-shared-i18n-locale-underscore-guard 2026-03-02 04:08:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#265
Delete Branch "dev/issue-257-shared-i18n-locale-underscore-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?