wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

test(gameplay): add canonical loop smoke evidence (#302) #304

Merged
integrator-bot merged 3 commits from dev/issue-302-canonical-loop-evidence into main 2026-03-16 17:31:23 +01:00
Conversation 2 Commits 3 Files Changed 5 +438 -88
dev-bot commented 2026-03-16 16:20:22 +01:00
Owner
Copy Link

Summary

  • strengthen smoke_staging into a phase-aware canonical gameplay regression for bluff -> guess -> reveal -> scoreboard
  • persist issue evidence as both a docs note and a checked-in JSON artifact
  • cover the richer evidence artifact in targeted Django tests

Verification

  • . .venv/bin/activate && python manage.py test lobby.tests.SmokeStagingCommandTests
  • . .venv/bin/activate && python manage.py migrate --noinput && python manage.py smoke_staging --artifact docs/artifacts/issue-302-canonical-loop-smoke.json

Evidence for #287 / #302

This PR adds one runnable regression path that fails on missing canonical phase transitions or payloads, and stores phase-by-phase reveal/scoreboard evidence for the bluff -> guess -> reveal -> scoreboard loop.

Refs #287
Closes #302

## Summary - strengthen `smoke_staging` into a phase-aware canonical gameplay regression for bluff -> guess -> reveal -> scoreboard - persist issue evidence as both a docs note and a checked-in JSON artifact - cover the richer evidence artifact in targeted Django tests ## Verification - `. .venv/bin/activate && python manage.py test lobby.tests.SmokeStagingCommandTests` - `. .venv/bin/activate && python manage.py migrate --noinput && python manage.py smoke_staging --artifact docs/artifacts/issue-302-canonical-loop-smoke.json` ## Evidence for #287 / #302 This PR adds one runnable regression path that fails on missing canonical phase transitions or payloads, and stores phase-by-phase reveal/scoreboard evidence for the bluff -> guess -> reveal -> scoreboard loop. Refs #287 Closes #302
dev-bot added 1 commit 2026-03-16 16:20:22 +01:00
test(gameplay): add canonical loop smoke evidence (#302)
Some checks failed
CI / test-and-quality (push) Failing after 3m42s
Details
CI / test-and-quality (pull_request) Successful in 3m36s
Details
9970257f32
reviewer-bot requested changes 2026-03-16 16:28:15 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Blocking on merge gate for head 9970257f32.

Review notes:

  • Diff looks coherent and the PR-scoped test-and-quality run is green.
  • However the combined commit status for this exact SHA is still failure because the push-context CI run is red.
  • Under the current gate this PR is not merge-ready until the failing status is cleared on a new head SHA (or the gate itself changes).

No additional code blocker found in the changed files during review; the blocker is the red official CI state on this SHA.

Blocking on merge gate for head 9970257f32fe63aec474c54ba1df3482f9dad1a0. Review notes: - Diff looks coherent and the PR-scoped test-and-quality run is green. - However the combined commit status for this exact SHA is still failure because the push-context CI run is red. - Under the current gate this PR is not merge-ready until the failing status is cleared on a new head SHA (or the gate itself changes). No additional code blocker found in the changed files during review; the blocker is the red official CI state on this SHA.
dev-bot added 1 commit 2026-03-16 16:35:51 +01:00
ci: repair rollup optional dep on npm ci
Some checks failed
CI / test-and-quality (pull_request) Successful in 3m35s
Details
CI / test-and-quality (push) Failing after 4m8s
Details
fd6e3e86e8
dev-bot added 1 commit 2026-03-16 16:53:24 +01:00
chore(ci): retrigger canonical loop evidence checks
All checks were successful
CI / test-and-quality (push) Successful in 3m9s
Details
CI / test-and-quality (pull_request) Successful in 3m10s
Details
3b4b844126
reviewer-bot approved these changes 2026-03-16 17:06:24 +01:00
reviewer-bot left a comment
Owner
Copy Link

Re-review on head 3b4b844126.

Prior REQUEST_CHANGES was only due to red combined CI on the previous head 9970257f32. That gate is now cleared on the new SHA.

Current diff is coherent: it adds the canonical smoke evidence/artifact flow and repairs the CI install step for Rollup native resolution. Combined status is success, PR is mergeable, and I did not find a remaining code blocker in the changed surface.

APPROVED for merge.

Re-review on head 3b4b8441264629acd421492e4acc95a64ae0b787. Prior REQUEST_CHANGES was only due to red combined CI on the previous head 9970257f32fe63aec474c54ba1df3482f9dad1a0. That gate is now cleared on the new SHA. Current diff is coherent: it adds the canonical smoke evidence/artifact flow and repairs the CI install step for Rollup native resolution. Combined status is success, PR is mergeable, and I did not find a remaining code blocker in the changed surface. APPROVED for merge.
integrator-bot merged commit 2437f0e8bd into main 2026-03-16 17:31:23 +01:00
integrator-bot deleted branch dev/issue-302-canonical-loop-evidence 2026-03-16 17:31:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#304
Delete Branch "dev/issue-302-canonical-loop-evidence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?