This PR adds one runnable regression path that fails on missing canonical phase transitions or payloads, and stores phase-by-phase reveal/scoreboard evidence for the bluff -> guess -> reveal -> scoreboard loop.
Diff looks coherent and the PR-scoped test-and-quality run is green.
However the combined commit status for this exact SHA is still failure because the push-context CI run is red.
Under the current gate this PR is not merge-ready until the failing status is cleared on a new head SHA (or the gate itself changes).
No additional code blocker found in the changed files during review; the blocker is the red official CI state on this SHA.
Blocking on merge gate for head 9970257f32fe63aec474c54ba1df3482f9dad1a0.
Review notes:
- Diff looks coherent and the PR-scoped test-and-quality run is green.
- However the combined commit status for this exact SHA is still failure because the push-context CI run is red.
- Under the current gate this PR is not merge-ready until the failing status is cleared on a new head SHA (or the gate itself changes).
No additional code blocker found in the changed files during review; the blocker is the red official CI state on this SHA.
Prior REQUEST_CHANGES was only due to red combined CI on the previous head 9970257f32. That gate is now cleared on the new SHA.
Current diff is coherent: it adds the canonical smoke evidence/artifact flow and repairs the CI install step for Rollup native resolution. Combined status is success, PR is mergeable, and I did not find a remaining code blocker in the changed surface.
APPROVED for merge.
Re-review on head 3b4b8441264629acd421492e4acc95a64ae0b787.
Prior REQUEST_CHANGES was only due to red combined CI on the previous head 9970257f32fe63aec474c54ba1df3482f9dad1a0. That gate is now cleared on the new SHA.
Current diff is coherent: it adds the canonical smoke evidence/artifact flow and repairs the CI install step for Rollup native resolution. Combined status is success, PR is mergeable, and I did not find a remaining code blocker in the changed surface.
APPROVED for merge.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
reviewer-bot
Summary
smoke_staginginto a phase-aware canonical gameplay regression for bluff -> guess -> reveal -> scoreboardVerification
. .venv/bin/activate && python manage.py test lobby.tests.SmokeStagingCommandTests. .venv/bin/activate && python manage.py migrate --noinput && python manage.py smoke_staging --artifact docs/artifacts/issue-302-canonical-loop-smoke.jsonEvidence for #287 / #302
This PR adds one runnable regression path that fails on missing canonical phase transitions or payloads, and stores phase-by-phase reveal/scoreboard evidence for the bluff -> guess -> reveal -> scoreboard loop.
Refs #287
Closes #302
Blocking on merge gate for head
9970257f32.Review notes:
No additional code blocker found in the changed files during review; the blocker is the red official CI state on this SHA.
Re-review on head
3b4b844126.Prior REQUEST_CHANGES was only due to red combined CI on the previous head
9970257f32. That gate is now cleared on the new SHA.Current diff is coherent: it adds the canonical smoke evidence/artifact flow and repairs the CI install step for Rollup native resolution. Combined status is success, PR is mergeable, and I did not find a remaining code blocker in the changed surface.
APPROVED for merge.