wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

F3: Guessfase submit-endpoint med deadline-validering #8

Merged
email-manager merged 2 commits from feature/f3-guess-submit into main 2026-02-27 16:41:02 +01:00
Conversation 4 Commits 2 Files Changed 5
+244 -1
email-manager commented 2026-02-27 16:31:50 +01:00
Owner
Copy Link
Copy Source

Løser #7

Implementeret:

  • POST /lobby/sessions//questions/<round_question_id>/guesses/submit
  • Validerer guess-fase, player/session, gyldigt svar og deadline
  • Gemmer Guess med is_correct + fooled_player_id
  • Returnerer guess + guess_deadline_at
  • Tests for happy path + afvisninger (fase, ukendt svar, duplicate, deadline)

Checks:

  • ruff check lobby --fix
  • python manage.py test lobby -v 1 (22/22 grøn)
Løser #7 Implementeret: - POST /lobby/sessions/<code>/questions/<round_question_id>/guesses/submit - Validerer guess-fase, player/session, gyldigt svar og deadline - Gemmer Guess med is_correct + fooled_player_id - Returnerer guess + guess_deadline_at - Tests for happy path + afvisninger (fase, ukendt svar, duplicate, deadline) Checks: - ruff check lobby --fix - python manage.py test lobby -v 1 (22/22 grøn)
email-manager added 1 commit 2026-02-27 16:31:50 +01:00
feat(f3): add guess submission endpoint with deadline checks d66c21ecb3
email-manager scheduled this pull request to auto merge when all checks succeed 2026-02-27 16:32:30 +01:00
email-manager commented 2026-02-27 16:33:08 +01:00
Author
Owner
Copy Link
Copy Source

Integrator-blocker: PR er klar funktionelt (lokalt: ruff check lobby --fix + python manage.py test lobby -v 1 = grøn), men merge er blokeret af branch protection: "Not all required status checks successful".

Der rapporteres ingen commit-statuses via API (/commits/<sha>/statuses => tom).

Need-to-have unblock:

  1. Sikr at required check-context matcher faktisk CI-job-navn i .gitea/workflows/ci.yml
  2. Trigger/ret CI så den publicerer status på PR-head commit
  3. Når status er grøn, vil auto-merge (allerede scheduled) kunne gennemføres.
Integrator-blocker: PR er klar funktionelt (lokalt: `ruff check lobby --fix` + `python manage.py test lobby -v 1` = grøn), men merge er blokeret af branch protection: **"Not all required status checks successful"**. Der rapporteres ingen commit-statuses via API (`/commits/<sha>/statuses` => tom). Need-to-have unblock: 1) Sikr at required check-context matcher faktisk CI-job-navn i `.gitea/workflows/ci.yml` 2) Trigger/ret CI så den publicerer status på PR-head commit 3) Når status er grøn, vil auto-merge (allerede scheduled) kunne gennemføres.
agw approved these changes 2026-02-27 16:35:40 +01:00
Dismissed
agw added 1 commit 2026-02-27 16:37:08 +01:00
ci: add gitea workflow for required PR status checks
CI / test-and-quality (pull_request) Successful in 50s
Details
CI / test-and-quality (push) Successful in 50s
Details
0cb936173f
agw dismissed agw's review 2026-02-27 16:37:08 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

email-manager commented 2026-02-27 16:40:03 +01:00
Author
Owner
Copy Link
Copy Source

Fix udført for review-fund: tilføjet .gitea/workflows/ci.yml med job-navn CI / test-and-quality for både push og pull_request, så required status contexts nu publiceres på PR-head.

Verificeret:

  • CI / test-and-quality (push) = success
  • CI / test-and-quality (pull_request) = success

Blokering nu: tidligere approval blev automatisk markeret stale/dismissed efter nyt commit (dismiss_stale_approvals=true), så PR kræver ny approval før merge.

Fix udført for review-fund: tilføjet `.gitea/workflows/ci.yml` med job-navn `CI / test-and-quality` for både `push` og `pull_request`, så required status contexts nu publiceres på PR-head. Verificeret: - `CI / test-and-quality (push)` = success - `CI / test-and-quality (pull_request)` = success Blokering nu: tidligere approval blev automatisk markeret stale/dismissed efter nyt commit (`dismiss_stale_approvals=true`), så PR kræver ny approval før merge.
agw approved these changes 2026-02-27 16:41:00 +01:00
email-manager merged commit 49e9d1be41 into main 2026-02-27 16:41:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
agw
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#8