Merge pull request #24604 from overleaf/em-docstore-errors

Downgrade 4xx errors in docstore

GitOrigin-RevId: ec6c73b4222876e6f58690779571e2e42106c36b
This commit is contained in:
Eric Mc Sween
2025-04-07 10:05:56 -04:00
committed by Copybot
parent 9ea0f2ec29
commit bfd9ab6b8f

View File

@@ -88,14 +88,17 @@ app.get('/status', (req, res) => res.send('docstore is alive'))
app.use(handleValidationErrors())
app.use(function (error, req, res, next) {
logger.error({ err: error, req }, 'request errored')
if (error instanceof Errors.NotFoundError) {
logger.warn({ req }, 'not found')
res.sendStatus(404)
} else if (error instanceof Errors.DocModifiedError) {
logger.warn({ req }, 'conflict: doc modified')
res.sendStatus(409)
} else if (error instanceof Errors.DocVersionDecrementedError) {
logger.warn({ req }, 'conflict: doc version decremented')
res.sendStatus(409)
} else {
logger.error({ err: error, req }, 'request errored')
res.status(500).send('Oops, something went wrong')
}
})