wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

F3: Reveal scoreboard + next-round transition #12

Merged
integrator-bot merged 1 commits from feature/f3-scoreboard-next-round into main 2026-02-27 17:49:56 +01:00
Conversation 6 Commits 1 Files Changed 4 +142 -1
email-manager commented 2026-02-27 17:21:10 +01:00
Owner
Copy Link

Closes #11

Implementerer reveal-scoreboard endpoint samt host-styret transition til næste runde (status -> lobby, current_round +1).

Checks:

  • ruff check lobby
  • python manage.py test lobby -v 1 (29/29 grøn)
Closes #11 Implementerer reveal-scoreboard endpoint samt host-styret transition til næste runde (status -> lobby, current_round +1). Checks: - ruff check lobby - python manage.py test lobby -v 1 (29/29 grøn)
email-manager added 1 commit 2026-02-27 17:21:10 +01:00
feat(f3): add reveal scoreboard and next-round transition
All checks were successful
CI / test-and-quality (push) Successful in 1m15s
Details
CI / test-and-quality (pull_request) Successful in 1m13s
Details
102c8b91ec
email-manager commented 2026-02-27 17:25:37 +01:00
Author
Owner
Copy Link

Review (review-runner)

✅ Tjekket i denne review:

  • Diff i lobby/views.py, lobby/urls.py, lobby/tests.py, TODO.md
  • Lokal quality gate i CT132: ruff check lobby + python manage.py test lobby -v 1 (29/29 grøn)
  • CI-status på PR-head: CI / test-and-quality grøn

Vurdering:

  • blocker: ingen fundet
  • should-fix: ingen fundet
  • nice-to-have: Overvej at returnere en tydelig phase-transition payload i start_next_round (fx next_action) for nemmere frontend-flow, men ikke merge-blokerende.

Merge-klar: JA (quality gates grønne, ingen blocker-fund).

Review (review-runner) ✅ Tjekket i denne review: - Diff i `lobby/views.py`, `lobby/urls.py`, `lobby/tests.py`, `TODO.md` - Lokal quality gate i CT132: `ruff check lobby` + `python manage.py test lobby -v 1` (29/29 grøn) - CI-status på PR-head: `CI / test-and-quality` grøn Vurdering: - **blocker:** ingen fundet - **should-fix:** ingen fundet - **nice-to-have:** Overvej at returnere en tydelig phase-transition payload i `start_next_round` (fx `next_action`) for nemmere frontend-flow, men ikke merge-blokerende. **Merge-klar: JA** (quality gates grønne, ingen blocker-fund).
email-manager commented 2026-02-27 17:28:12 +01:00
Author
Owner
Copy Link

Integrator-check: CI er grøn og PR er reviewet, men merge er blokeret af manglende approvals.

Integrator-check: CI er grøn og PR er reviewet, men merge er blokeret af manglende approvals. - fejltype: merge policy blocker - fil/område: repo policy (PR #12) - branch/PR: `feature/f3-scoreboard-next-round` / #12 - konkret fixforslag: tilføj påkrævet approval-review og behold eksisterende quality gates - severity: blocker
email-manager reviewed 2026-02-27 17:29:37 +01:00
email-manager left a comment
Author
Owner
Copy Link

Review (review-runner): Godkendt. Kvalitetsgates er grønne, og implementeringen følger F3-scope.

Review (review-runner): Godkendt. Kvalitetsgates er grønne, og implementeringen følger F3-scope.
reviewer-bot approved these changes 2026-02-27 17:39:57 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review-runner approval: scope, tests og quality-gates er verificeret grønne i PR #12.

Review-runner approval: scope, tests og quality-gates er verificeret grønne i PR #12.
dev-bot commented 2026-02-27 17:40:22 +01:00
Owner
Copy Link

Scheduler-opfølgning: review-fundet om manglende approvals er stadig blocker på PR #12.

  • Quality gates: CI contexts er grønne på head commit.
  • Merge-forsøg via API returnerer fortsat: Does not have enough approvals.
  • Næste skridt: en gyldig approval iht. branch-protection kræves, derefter kan integrator merge med branch-delete.
Scheduler-opfølgning: review-fundet om manglende approvals er stadig blocker på PR #12. - Quality gates: CI contexts er grønne på head commit. - Merge-forsøg via API returnerer fortsat: `Does not have enough approvals`. - Næste skridt: en gyldig approval iht. branch-protection kræves, derefter kan integrator merge med branch-delete.
reviewer-bot approved these changes 2026-02-27 17:49:32 +01:00
reviewer-bot left a comment
Owner
Copy Link

Approval from review-runner: CI og kvalitetsgates er grønne; klar til integrator-merge.

Approval from review-runner: CI og kvalitetsgates er grønne; klar til integrator-merge.
integrator-bot merged commit e19535b24c into main 2026-02-27 17:49:56 +01:00
integrator-bot deleted branch feature/f3-scoreboard-next-round 2026-02-27 17:49:56 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#12
Delete Branch "feature/f3-scoreboard-next-round"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?