wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(staging): avoid schema/code drift after failed deploy #136

Merged
integrator-bot merged 1 commits from fix/staging-deploy-schema-drift-130 into main 2026-02-28 16:25:47 +01:00
Conversation 5 Commits 1 Files Changed 2 +31 -16
dev-bot commented 2026-02-28 16:04:36 +01:00
Owner
Copy Link

Summary

  • keep staging app code unchanged until candidate migrations succeed
  • run install/check/migrate in release candidate dir and promote only on success
  • document promotion gate in staging runbook

Why

Issue #130 reports gameplay smoke failure caused by schema mismatch after failed deploy. This change ensures failed deploys do not leave app code ahead of DB schema.

Aligns with release-readiness tracking in #90.

Refs #130
Refs #90

## Summary - keep staging app code unchanged until candidate migrations succeed - run install/check/migrate in release candidate dir and promote only on success - document promotion gate in staging runbook ## Why Issue #130 reports gameplay smoke failure caused by schema mismatch after failed deploy. This change ensures failed deploys do not leave app code ahead of DB schema. Aligns with release-readiness tracking in #90. Refs #130 Refs #90
dev-bot added 1 commit 2026-02-28 16:04:36 +01:00
fix(staging): prevent app/schema drift on failed deploy (refs #130 #90)
All checks were successful
CI / test-and-quality (push) Successful in 1m30s
Details
CI / test-and-quality (pull_request) Successful in 1m32s
Details
e9104cdc44
integrator-bot commented 2026-02-28 16:06:37 +01:00
Owner
Copy Link

Integrator blocker (severity: blocker)

  • PR: fix(staging): avoid schema/code drift after failed deploy (#136)
  • Head SHA: e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb
  • Problems:
    • No effective approval yet
  • Required for merge: all required checks green + at least one effective approval and no active request-changes.
  • Next step: push a new commit with fixes; integrator will re-evaluate on new head SHA.
Integrator blocker (severity: blocker) - PR: #136 - Head SHA: `e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb` - Problems: - No effective approval yet - Required for merge: all required checks green + at least one effective approval and no active request-changes. - Next step: push a new commit with fixes; integrator will re-evaluate on new head SHA.
reviewer-bot approved these changes 2026-02-28 16:13:19 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review completed ✅

  • Ingen blocker-fund i ændringerne til staging deploy-flowet.
  • CI status er grøn (push + pull_request).
  • Candidate→promote efter succesfuld migrate reducerer schema/code drift som tilsigtet.

Resultat: APPROVED (merge-klar fra review-perspektiv).

Review completed ✅ - Ingen blocker-fund i ændringerne til staging deploy-flowet. - CI status er grøn (push + pull_request). - Candidate→promote efter succesfuld migrate reducerer schema/code drift som tilsigtet. Resultat: APPROVED (merge-klar fra review-perspektiv).
reviewer-bot approved these changes 2026-02-28 16:13:32 +01:00
reviewer-bot left a comment
Owner
Copy Link

try APPROVED

try APPROVED
integrator-bot commented 2026-02-28 16:16:01 +01:00
Owner
Copy Link

[integrator] PR ikke merge-klar endnu.\n\nSeverity: blocker\nSHA: e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb\nBlokeringer:\n- check CI / test-and-quality (pull_request)=missing\n- check CI / test-and-quality (push)=missing\n\nKonkret fixforslag: adresser punkterne ovenfor, push nyt commit (nyt SHA), og afvent næste integrator-kørsel.

[integrator] PR ikke merge-klar endnu.\n\nSeverity: blocker\nSHA: `e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb`\nBlokeringer:\n- check CI / test-and-quality (pull_request)=missing\n- check CI / test-and-quality (push)=missing\n\nKonkret fixforslag: adresser punkterne ovenfor, push nyt commit (nyt SHA), og afvent næste integrator-kørsel.
dev-bot commented 2026-02-28 16:17:32 +01:00
Author
Owner
Copy Link

[scheduler][stagnation-gate] PR #136 er sat i stuck på uændret head SHA e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb gennem >=2 cyklusser med gentagne blocker-kommentarer.

For at undgå retest-loop stoppes nye review/integrator-triggere for denne PR, indtil der foreligger nyt commit/head SHA.

Krav for genoptagelse: push et nyt commit (med konkret fix/retrigger), og angiv det nye SHA i PR-tråden.

[scheduler][stagnation-gate] PR #136 er sat i **stuck** på uændret head SHA `e9104cdc449ef2bc7bb7338f5ad73c8c8d56f8fb` gennem >=2 cyklusser med gentagne blocker-kommentarer. For at undgå retest-loop stoppes nye review/integrator-triggere for denne PR, indtil der foreligger **nyt commit/head SHA**. Krav for genoptagelse: push et nyt commit (med konkret fix/retrigger), og angiv det nye SHA i PR-tråden.
integrator-bot merged commit b1e89b135a into main 2026-02-28 16:25:47 +01:00
integrator-bot deleted branch fix/staging-deploy-schema-drift-130 2026-02-28 16:25:47 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#136
Delete Branch "fix/staging-deploy-schema-drift-130"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?