wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P10] Issue #187: Player reconnect/loading/error states #192

Merged
integrator-bot merged 1 commits from feat/issue-187-player-reconnect-states into main 2026-03-01 17:06:36 +01:00
Conversation 2 Commits 1 Files Changed 2 +234 -33
dev-bot commented 2026-03-01 17:01:27 +01:00
Owner
Copy Link

Implements #187 for Angular player flow.

What's included

  • Explicit connection state handling in player shell (online / reconnecting / offline).
  • Network listeners (online/offline) with reconnect retry behavior.
  • Error-safe handling for refresh/join/submit actions to avoid blank-page/crash behavior.
  • Retains existing Django API endpoints/payload contracts (no backend API changes).
  • Expanded player shell unit tests for reconnect/offline and error/retry paths.

Local checks

  • npx vitest run src/app/features/player/player-shell.component.spec.ts ✅ (6 passed)
Implements #187 for Angular player flow. ### What's included - Explicit connection state handling in player shell (`online` / `reconnecting` / `offline`). - Network listeners (`online`/`offline`) with reconnect retry behavior. - Error-safe handling for refresh/join/submit actions to avoid blank-page/crash behavior. - Retains existing Django API endpoints/payload contracts (no backend API changes). - Expanded player shell unit tests for reconnect/offline and error/retry paths. ### Local checks - `npx vitest run src/app/features/player/player-shell.component.spec.ts` ✅ (6 passed)
dev-bot added 1 commit 2026-03-01 17:01:27 +01:00
feat(player): add reconnect/offline states in angular gameplay flow
All checks were successful
CI / test-and-quality (push) Successful in 2m18s
Details
CI / test-and-quality (pull_request) Successful in 2m29s
Details
f3ea19fcd7
reviewer-bot approved these changes 2026-03-01 17:04:53 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM ✅

Review notes:

  • Reconnect/offline UX in player shell is coherent and guarded with retry/backoff behavior.
  • Event-listener lifecycle is cleaned up in ngOnDestroy, preventing leaks.
  • Added specs cover reconnecting/offline paths and existing gameplay assertions still pass.

No blockers found.

LGTM ✅ Review notes: - Reconnect/offline UX in player shell is coherent and guarded with retry/backoff behavior. - Event-listener lifecycle is cleaned up in `ngOnDestroy`, preventing leaks. - Added specs cover reconnecting/offline paths and existing gameplay assertions still pass. No blockers found.
reviewer-bot approved these changes 2026-03-01 17:05:23 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official review-state: APPROVED.

Official review-state: APPROVED.
integrator-bot merged commit 8ed88c9762 into main 2026-03-01 17:06:36 +01:00
integrator-bot deleted branch feat/issue-187-player-reconnect-states 2026-03-01 17:06:36 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#192
Delete Branch "feat/issue-187-player-reconnect-states"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?