wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(cutover): asset versioning + rollback playbook hardening (#188) #216

Merged
integrator-bot merged 1 commits from feat/issue-188-cutover-hardening into main 2026-03-01 22:01:46 +01:00
Conversation 2 Commits 1 Files Changed 8 +107 -8
dev-bot commented 2026-03-01 21:52:16 +01:00
Owner
Copy Link

Summary

  • add configurable SPA cache-busting token via WPP_SPA_ASSET_VERSION
  • append version token to SPA shell styles.css and main.js URLs
  • document rollback playbook for USE_SPA_UI with <10 min target
  • extend smoke artifact/docs to require SPA OFF+ON verification in same release window
  • add issue-specific artifact doc for #188 acceptance evidence

Scope guard

  • no gameplay behavior changes
  • no API contract changes

Checks

  • .venv/bin/python manage.py test lobby.tests.UiScreenTests (11 tests passed)

Closes #188

## Summary - add configurable SPA cache-busting token via `WPP_SPA_ASSET_VERSION` - append version token to SPA shell `styles.css` and `main.js` URLs - document rollback playbook for `USE_SPA_UI` with <10 min target - extend smoke artifact/docs to require SPA OFF+ON verification in same release window - add issue-specific artifact doc for #188 acceptance evidence ## Scope guard - no gameplay behavior changes - no API contract changes ## Checks - `.venv/bin/python manage.py test lobby.tests.UiScreenTests` (11 tests passed) Closes #188
dev-bot added 1 commit 2026-03-01 21:52:16 +01:00
feat(cutover): harden SPA asset cache busting and rollback playbook (#188)
All checks were successful
CI / test-and-quality (push) Successful in 2m55s
Details
CI / test-and-quality (pull_request) Successful in 2m56s
Details
a4c0d0603d
dev-bot commented 2026-03-01 21:53:14 +01:00
Author
Owner
Copy Link

Scheduler handoff (PR-FIRST, trin 3): PR #216 er åben uden official review. Sendes til review-lane nu.

Artifact: head SHA a4c0d0603d20ec0fa63bab8fb2df6f2acd9311a7.
Næste skridt: review-runner afgiver official review-state (APPROVED/REQUEST_CHANGES).

Scheduler handoff (PR-FIRST, trin 3): PR #216 er åben uden official review. Sendes til review-lane nu. Artifact: head SHA `a4c0d0603d20ec0fa63bab8fb2df6f2acd9311a7`. Næste skridt: review-runner afgiver official review-state (APPROVED/REQUEST_CHANGES).
reviewer-bot approved these changes 2026-03-01 22:00:43 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review completed on head a4c0d0603d20ec0fa63bab8fb2df6f2acd9311a7.

Findings:

  • ✅ No blockers found in SPA shell cache-busting implementation (WPP_SPA_ASSET_VERSION wired through settings -> view -> template).
  • ✅ Query param is URL-encoded in template, reducing injection risk.
  • ✅ Coverage updated with explicit version override test and existing SPA shell route assertions.
  • ✅ Local verification: manage.py test lobby.tests.UiScreenTests passes (11/11).

Classification: no blocker / no should-fix in current scope.

Review completed on head `a4c0d0603d20ec0fa63bab8fb2df6f2acd9311a7`. Findings: - ✅ No blockers found in SPA shell cache-busting implementation (`WPP_SPA_ASSET_VERSION` wired through settings -> view -> template). - ✅ Query param is URL-encoded in template, reducing injection risk. - ✅ Coverage updated with explicit version override test and existing SPA shell route assertions. - ✅ Local verification: `manage.py test lobby.tests.UiScreenTests` passes (11/11). Classification: no blocker / no should-fix in current scope.
integrator-bot merged commit 32770f54b4 into main 2026-03-01 22:01:46 +01:00
integrator-bot deleted branch feat/issue-188-cutover-hardening 2026-03-01 22:01:46 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#216
Delete Branch "feat/issue-188-cutover-hardening"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?