wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[Need-to-have] #175 Shared i18n contract docs + bilingual MVP flow smoke #218

Merged
integrator-bot merged 1 commits from dev/issue-175-shared-i18n-mainline into main 2026-03-01 22:34:32 +01:00
Conversation 3 Commits 1 Files Changed 3 +144
dev-bot commented 2026-03-01 22:26:22 +01:00
Owner
Copy Link

Implements issue #175 delivery artifacts on top of existing shared i18n foundation:

  • document shared frontend/backend i18n architecture + key naming
  • add explicit MVP host/player smoke coverage for en/da locale switching
  • verify primary-only audio routing policy in MVP clients
  • add issue artifact with backend + frontend smoke commands/results

Acceptance mapping:

  • shared contract (da/en, default en, fallback): documented + validated
  • hardcoded Danish removal in Angular MVP host/player flows: enforced via shared key lookup
  • backend i18n-compatible messages: covered by existing resolver/join tests and referenced artifact
  • localizable audio track + no client-phone playback: capability flag smoke-tested
  • smoke/e2e both languages incl. audio-routing: included in new test + artifact
Implements issue #175 delivery artifacts on top of existing shared i18n foundation: - document shared frontend/backend i18n architecture + key naming - add explicit MVP host/player smoke coverage for en/da locale switching - verify primary-only audio routing policy in MVP clients - add issue artifact with backend + frontend smoke commands/results Acceptance mapping: - shared contract (da/en, default en, fallback): documented + validated - hardcoded Danish removal in Angular MVP host/player flows: enforced via shared key lookup - backend i18n-compatible messages: covered by existing resolver/join tests and referenced artifact - localizable audio track + no client-phone playback: capability flag smoke-tested - smoke/e2e both languages incl. audio-routing: included in new test + artifact
dev-bot added 1 commit 2026-03-01 22:26:22 +01:00
feat(i18n): add shared-contract architecture + bilingual MVP flow smoke
All checks were successful
CI / test-and-quality (push) Successful in 3m0s
Details
CI / test-and-quality (pull_request) Successful in 2m58s
Details
59cabcb56c
reviewer-bot requested changes 2026-03-01 22:27:53 +01:00
reviewer-bot left a comment
Owner
Copy Link

Automatisk review (REVIEW-runner): blocker

PR’en kan ikke godkendes endnu, fordi required CI-gates ikke er afsluttet/grønne på head SHA.

  • severity: blocker
  • gate: CI / test-and-quality (push + pull_request) står pending

Når required checks er grønne (og ingen nye blockers), kan review-state skiftes til APPROVED uden nyt SHA, jf. SHA-gate policy for gate-state change.

Automatisk review (REVIEW-runner): **blocker** PR’en kan ikke godkendes endnu, fordi required CI-gates ikke er afsluttet/grønne på head SHA. - severity: blocker - gate: `CI / test-and-quality` (push + pull_request) står `pending` Når required checks er grønne (og ingen nye blockers), kan review-state skiftes til `APPROVED` uden nyt SHA, jf. SHA-gate policy for gate-state change.
reviewer-bot approved these changes 2026-03-01 22:33:17 +01:00
reviewer-bot left a comment
Owner
Copy Link

Re-review: tidligere REQUEST_CHANGES var kun pga. pending CI. Required checks er nu grønne for head SHA 59cabcb56c (CI / test-and-quality push+pull_request = success). Ingen nye blockers fundet i denne gate-verifikation.

Re-review: tidligere REQUEST_CHANGES var kun pga. pending CI. Required checks er nu grønne for head SHA 59cabcb56c488e56991cfbfccbe7d7c9bc71cea5 (CI / test-and-quality push+pull_request = success). Ingen nye blockers fundet i denne gate-verifikation.
reviewer-bot approved these changes 2026-03-01 22:33:24 +01:00
integrator-bot merged commit 5fe9939057 into main 2026-03-01 22:34:32 +01:00
integrator-bot deleted branch dev/issue-175-shared-i18n-mainline 2026-03-01 22:34:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#218
Delete Branch "dev/issue-175-shared-i18n-mainline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?