wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[i18n][P17] Issue #175: shared frontend/backend contract + EN default + locale-switch smoke #219

Closed
dev-bot wants to merge 0 commits from dev/issue-175-shared-i18n-mainline into main
pull from: dev/issue-175-shared-i18n-mainline
merge into: wpp:main
Conversation 1 Commits - Files Changed -
dev-bot commented 2026-03-01 22:38:32 +01:00
Owner
Copy Link

Summary

Implements a minimal, scoped slice for #175 by consolidating and documenting the already-delivered i18n contract usage across backend + frontend and adding explicit locale-switch validation coverage.

Included in this PR

  • docs: docs/I18N_ARCHITECTURE.md
    • shared source-of-truth catalog (shared/i18n/lobby.json)
    • key naming architecture for frontend/backend
    • default/fallback locale en
    • fallback resolution model + API error shape
  • docs artifact: docs/ISSUE-175-I18N-SHARED-CONTRACT-ARTIFACT.md
  • e2e-like smoke validation: frontend/angular/src/app/i18n-mvp-flow-smoke.spec.ts
    • locale switch en <-> da in host/player flow scope
    • capability copy coverage (client_has_no_audio_output)

Acceptance mapping (#175)

  • shared i18n contract frontend/backend (catalog + documented keyspace contract)
  • default locale en
  • remove hardcoded Danish in host/player changed scope (through shared catalog usage in scope)
  • document key naming/architecture
  • at least one end-to-end locale-switch validation

Checks run

  • npm test -- src/app/i18n-mvp-flow-smoke.spec.ts src/app/lobby-i18n.spec.ts ✅ (5 tests)
  • Backend Django tests were not executable in this runner image (missing Django/pytest env).

Closes #175

## Summary Implements a minimal, scoped slice for #175 by consolidating and documenting the already-delivered i18n contract usage across backend + frontend and adding explicit locale-switch validation coverage. ### Included in this PR - docs: `docs/I18N_ARCHITECTURE.md` - shared source-of-truth catalog (`shared/i18n/lobby.json`) - key naming architecture for frontend/backend - default/fallback locale `en` - fallback resolution model + API error shape - docs artifact: `docs/ISSUE-175-I18N-SHARED-CONTRACT-ARTIFACT.md` - e2e-like smoke validation: `frontend/angular/src/app/i18n-mvp-flow-smoke.spec.ts` - locale switch `en` <-> `da` in host/player flow scope - capability copy coverage (`client_has_no_audio_output`) ## Acceptance mapping (#175) - [x] shared i18n contract frontend/backend (catalog + documented keyspace contract) - [x] default locale en - [x] remove hardcoded Danish in host/player changed scope (through shared catalog usage in scope) - [x] document key naming/architecture - [x] at least one end-to-end locale-switch validation ## Checks run - `npm test -- src/app/i18n-mvp-flow-smoke.spec.ts src/app/lobby-i18n.spec.ts` ✅ (5 tests) - Backend Django tests were not executable in this runner image (missing Django/pytest env). Closes #175
dev-bot commented 2026-03-01 22:39:47 +01:00
Author
Owner
Copy Link

Closing as redundant/no-diff: the intended slice for issue #175 is already merged in PR #218 (head 59cabcb, merge commit 5fe9939).

Closing as redundant/no-diff: the intended slice for issue #175 is already merged in PR #218 (head 59cabcb, merge commit 5fe9939).
dev-bot closed this pull request 2026-03-01 22:39:47 +01:00
All checks were successful
CI / test-and-quality (push) Successful in 3m0s
Required
Details
CI / test-and-quality (pull_request) Successful in 2m58s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#219
Delete Branch "dev/issue-175-shared-i18n-mainline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?