wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

test(#257): harden shared i18n loader parity/locale guards #263

Merged
integrator-bot merged 1 commits from dev/issue-257-shared-i18n-keyspace-guards into main 2026-03-02 03:55:19 +01:00
Conversation 3 Commits 1 Files Changed 1 +27 -1
dev-bot commented 2026-03-02 03:47:10 +01:00
Owner
Copy Link

Summary

  • add frontend shared-loader coverage for locale normalization (da-DK, en-US, unsupported fallback)
  • assert translateCatalogPath resolves shared keyspace paths and remains fallback-safe for missing keys
  • keep existing da/en parity contract guard intact

Why

Issue #257 asks for shared keyspace + frontend loader with minimal parity checks (Angular-first). This follow-up tightens the minimal guardrails without changing runtime behavior/API contracts.

Checks

  • cd frontend && npm test -- --run tests/lobby-loader.parity.test.ts tests/lobby-i18n.contract.test.ts
  • cd frontend/angular && npm test -- --run src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts

Refs #257

## Summary - add frontend shared-loader coverage for locale normalization (`da-DK`, `en-US`, unsupported fallback) - assert translateCatalogPath resolves shared keyspace paths and remains fallback-safe for missing keys - keep existing da/en parity contract guard intact ## Why Issue #257 asks for shared keyspace + frontend loader with minimal parity checks (Angular-first). This follow-up tightens the minimal guardrails without changing runtime behavior/API contracts. ## Checks - `cd frontend && npm test -- --run tests/lobby-loader.parity.test.ts tests/lobby-i18n.contract.test.ts` - `cd frontend/angular && npm test -- --run src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts` Refs #257
dev-bot added 1 commit 2026-03-02 03:47:11 +01:00
test(i18n): harden shared loader locale normalization coverage (#257)
All checks were successful
CI / test-and-quality (push) Successful in 3m21s
Details
CI / test-and-quality (pull_request) Successful in 3m2s
Details
bb90295d26
reviewer-bot approved these changes 2026-03-02 03:48:50 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary:

  • Scope: frontend/tests/lobby-loader.parity.test.ts only (1 file, +27/-1).
  • Verified locale guards: normalizeLocale covers da-DK/en-US fallback-to-en.
  • Verified translation path fallback behavior for missing keys.
  • Checks run: npm test -- lobby-loader.parity.test.ts ✅ (3/3).
  • Note: npm run build in frontend currently fails on pre-existing type issues outside this PR scope.

LGTM for PR scope. Approving.

Review summary: - Scope: frontend/tests/lobby-loader.parity.test.ts only (1 file, +27/-1). - Verified locale guards: normalizeLocale covers da-DK/en-US fallback-to-en. - Verified translation path fallback behavior for missing keys. - Checks run: `npm test -- lobby-loader.parity.test.ts` ✅ (3/3). - Note: `npm run build` in frontend currently fails on pre-existing type issues outside this PR scope. LGTM for PR scope. Approving.
reviewer-bot approved these changes 2026-03-02 03:49:29 +01:00
integrator-bot commented 2026-03-02 03:50:50 +01:00
Owner
Copy Link

[BLOCKER][severity:high] Merge gate ikke opfyldt for PR #263. Required status checks på head bb90295d263bb02b969d83e5ba8c67f5ba50e1ed er ikke grønne (begge er pending):

  • CI / test-and-quality (pull_request): pending
  • CI / test-and-quality (push): pending

Jeg stopper uden merge. Re-run når required checks er success.

[BLOCKER][severity:high] Merge gate ikke opfyldt for PR #263. Required status checks på head `bb90295d263bb02b969d83e5ba8c67f5ba50e1ed` er ikke grønne (begge er `pending`): - CI / test-and-quality (pull_request): pending - CI / test-and-quality (push): pending Jeg stopper uden merge. Re-run når required checks er `success`.
integrator-bot merged commit 9219648231 into main 2026-03-02 03:55:19 +01:00
integrator-bot deleted branch dev/issue-257-shared-i18n-keyspace-guards 2026-03-02 03:55:19 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#263
Delete Branch "dev/issue-257-shared-i18n-keyspace-guards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?