Scope/Regression: Backend resolve_locale now ranks supported Accept-Language candidates by q-value and preserves stable tie-break by header order. This fixes prior first-match behavior and aligns with RFC intent.
Security: No auth/input-sanitization regression seen; parsing remains bounded/simple and ignores q<=0 as expected.
Testdækning: Existing i18n resolver tests were updated with a focused case for highest-quality preference.
i18n: Behavior now correctly prefers the highest-priority supported locale (da;q=0.8, en;q=0.9 => en).
Repo-hygiejne: Change set is minimal and targeted.
Validation note: Local frontend targeted tests pass in this runner; Django test execution is not available in this runtime due missing Django env, so backend verification here is by code+test diff inspection (CI should enforce full backend suite).
Result: APPROVED.
WPP review (isolated):
- Scope/Regression: Backend `resolve_locale` now ranks supported Accept-Language candidates by q-value and preserves stable tie-break by header order. This fixes prior first-match behavior and aligns with RFC intent.
- Security: No auth/input-sanitization regression seen; parsing remains bounded/simple and ignores q<=0 as expected.
- Testdækning: Existing i18n resolver tests were updated with a focused case for highest-quality preference.
- i18n: Behavior now correctly prefers the highest-priority supported locale (`da;q=0.8, en;q=0.9` => `en`).
- Repo-hygiejne: Change set is minimal and targeted.
Validation note: Local frontend targeted tests pass in this runner; Django test execution is not available in this runtime due missing Django env, so backend verification here is by code+test diff inspection (CI should enforce full backend suite).
Result: APPROVED.
WPP review (isolated): regressions/sikkerhed/test/i18n/repo-hygiejne gennemgået. Backend locale resolver rangerer nu korrekt på q-values med stabil tie-break på header-rækkefølge. Ingen sikkerhedsregression fundet. Testcase for højeste kvalitet er tilføjet. APPROVED.
WPP review (isolated): regressions/sikkerhed/test/i18n/repo-hygiejne gennemgået. Backend locale resolver rangerer nu korrekt på q-values med stabil tie-break på header-rækkefølge. Ingen sikkerhedsregression fundet. Testcase for højeste kvalitet er tilføjet. APPROVED.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
reviewer-bot
Summary
Accept-Languagecandidates by q-value before selecting supported localeen) when no supported candidate is providedTesting
.venv/bin/python manage.py test lobby.tests.I18nResolverTests lobby.tests.LobbyFlowTests.test_join_error_localizes_to_danish_with_accept_language_header lobby.tests.LobbyFlowTests.test_join_error_falls_back_to_english_for_unsupported_localeRefs #225
WPP review (isolated):
resolve_localenow ranks supported Accept-Language candidates by q-value and preserves stable tie-break by header order. This fixes prior first-match behavior and aligns with RFC intent.da;q=0.8, en;q=0.9=>en).Validation note: Local frontend targeted tests pass in this runner; Django test execution is not available in this runtime due missing Django env, so backend verification here is by code+test diff inspection (CI should enforce full backend suite).
Result: APPROVED.
API probe for official state
WPP review (isolated): regressions/sikkerhed/test/i18n/repo-hygiejne gennemgået. Backend locale resolver rangerer nu korrekt på q-values med stabil tie-break på header-rækkefølge. Ingen sikkerhedsregression fundet. Testcase for højeste kvalitet er tilføjet. APPROVED.