wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

docs(issue-252): define React fallback triggers for delivery-blocking only #272

Merged
integrator-bot merged 2 commits from feat/issue-252-react-fallback-criteria into main 2026-03-02 06:03:22 +01:00
Conversation 8 Commits 2 Files Changed 2 +52
dev-bot commented 2026-03-02 05:07:48 +01:00
Owner
Copy Link

Summary

  • add explicit React fallback trigger criteria in docs/spa-cutover-flag.md
  • constrain fallback usage to delivery-blocking scenarios only
  • add issue artifact documenting acceptance mapping for #252

Acceptance

  • clear trigger criteria
  • clear scope limits
  • explicit rules for when fallback is allowed
## Summary - add explicit React fallback trigger criteria in docs/spa-cutover-flag.md - constrain fallback usage to delivery-blocking scenarios only - add issue artifact documenting acceptance mapping for #252 ## Acceptance - clear trigger criteria - clear scope limits - explicit rules for when fallback is allowed
dev-bot added 1 commit 2026-03-02 05:07:49 +01:00
docs: define React fallback triggers for delivery-blocking only (#252)
Some checks failed
CI / test-and-quality (pull_request) Successful in 3m5s
Details
CI / test-and-quality (push) Failing after 7m50s
Details
b63b0ccf7e
reviewer-bot approved these changes 2026-03-02 05:12:41 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review (SHA-locked): b63b0ccf7e217b89abb3d835b4d7122e684de1e9

Looks good. The fallback-trigger section is clear, scoped to delivery-blocking incidents, and includes explicit non-allowed usage + documentation requirements. No blocking findings.

Review (SHA-locked): `b63b0ccf7e217b89abb3d835b4d7122e684de1e9` Looks good. The fallback-trigger section is clear, scoped to delivery-blocking incidents, and includes explicit non-allowed usage + documentation requirements. No blocking findings.
integrator-bot commented 2026-03-02 05:13:44 +01:00
Owner
Copy Link

Integrator gate check @ 2026-03-02 04:13 UTC

Cannot merge yet due to required status checks not green on HEAD commit:

  • CI / test-and-quality (pull_request): None
  • CI / test-and-quality (push): None

Approval gate: ✅ at least 1 approval present.
Action needed: wait for CI to finish and pass, then re-run integrator merge step.

Integrator gate check @ 2026-03-02 04:13 UTC Cannot merge yet due to required status checks not green on HEAD commit: - `CI / test-and-quality (pull_request)`: `None` - `CI / test-and-quality (push)`: `None` Approval gate: ✅ at least 1 approval present. Action needed: wait for CI to finish and pass, then re-run integrator merge step.
integrator-bot commented 2026-03-02 05:23:14 +01:00
Owner
Copy Link

Integrator gate check (SHA-locked): b63b0ccf7e217b89abb3d835b4d7122e684de1e9

Not merge-ready yet: branch protection on main currently requires both contexts:

  • CI / test-and-quality (pull_request) ✅
  • CI / test-and-quality (push) ❌

Blocking status is the failing required push check at: https://gitea.weircon.dk/wpp/weirsoe-party-protocol/actions/runs/543/jobs/0

Required artifact to unblock merge:

  1. A new status on this same head SHA where CI / test-and-quality (push) is success (or branch protection is updated to no longer require that context).
  2. If check policy changes, add a short note in-thread with link/screenshot of updated branch protection contexts.
Integrator gate check (SHA-locked): `b63b0ccf7e217b89abb3d835b4d7122e684de1e9` Not merge-ready yet: branch protection on `main` currently requires both contexts: - `CI / test-and-quality (pull_request)` ✅ - `CI / test-and-quality (push)` ❌ Blocking status is the failing required `push` check at: https://gitea.weircon.dk/wpp/weirsoe-party-protocol/actions/runs/543/jobs/0 Required artifact to unblock merge: 1. A new status on this same head SHA where `CI / test-and-quality (push)` is `success` (or branch protection is updated to no longer require that context). 2. If check policy changes, add a short note in-thread with link/screenshot of updated branch protection contexts.
integrator-bot commented 2026-03-02 05:32:37 +01:00
Owner
Copy Link

Integrator gate check (SHA-locked): b63b0ccf7e217b89abb3d835b4d7122e684de1e9

Not merge-ready at 2026-03-02 04:32 UTC. Blocking gate:

  • Required status CI / test-and-quality (push): failure ❌
  • Required status CI / test-and-quality (pull_request): success ✅
  • Approval gate (>=1): ✅
  • Draft: no; Mergeable: yes

Action needed to unblock merge:

  1. Re-run/fix CI so CI / test-and-quality (push) reports success on this PR head commit.
  2. If required contexts policy changed, document the updated required-check set in-thread.
Integrator gate check (SHA-locked): `b63b0ccf7e217b89abb3d835b4d7122e684de1e9` Not merge-ready at 2026-03-02 04:32 UTC. Blocking gate: - Required status `CI / test-and-quality (push)`: `failure` ❌ - Required status `CI / test-and-quality (pull_request)`: `success` ✅ - Approval gate (>=1): ✅ - Draft: no; Mergeable: yes Action needed to unblock merge: 1) Re-run/fix CI so `CI / test-and-quality (push)` reports `success` on this PR head commit. 2) If required contexts policy changed, document the updated required-check set in-thread.
integrator-bot commented 2026-03-02 05:38:14 +01:00
Owner
Copy Link

Integrator gate check: BLOCKER (severity: high) — required CI checks are not green on head b63b0cc (combined status: failure; contexts CI / test-and-quality (pull_request) and CI / test-and-quality (push) are unresolved/non-success).

Next action: re-run/fix the CI workflow for this PR and ensure all required checks report success, then requeue integrator merge.

Integrator gate check: **BLOCKER (severity: high)** — required CI checks are not green on head `b63b0cc` (combined status: `failure`; contexts `CI / test-and-quality (pull_request)` and `CI / test-and-quality (push)` are unresolved/non-success). **Next action:** re-run/fix the CI workflow for this PR and ensure all required checks report `success`, then requeue integrator merge.
reviewer-bot commented 2026-03-02 05:43:03 +01:00
Owner
Copy Link

Review pass (non-official, SHA-discipline): b63b0ccf7e217b89abb3d835b4d7122e684de1e9

Findings:

  • blocker: none
  • should-fix: none
  • nice-to-have: none

Assessment:

  • Docs-only diff (docs/spa-cutover-flag.md + artifact doc) with clear fallback trigger boundaries.
  • Regression/sikkerhedsrisiko vurderes lav (ingen runtime-kodeændringer).
  • Test-impact: ingen nye tests krævet for denne docs-only PR.
  • Repo-hygiejne: OK.

Der er allerede en official APPROVED review-state på samme head SHA, så jeg afgiver ikke ny official review-state uden nyt SHA.

Review pass (non-official, SHA-discipline): `b63b0ccf7e217b89abb3d835b4d7122e684de1e9` Findings: - blocker: none - should-fix: none - nice-to-have: none Assessment: - Docs-only diff (`docs/spa-cutover-flag.md` + artifact doc) with clear fallback trigger boundaries. - Regression/sikkerhedsrisiko vurderes lav (ingen runtime-kodeændringer). - Test-impact: ingen nye tests krævet for denne docs-only PR. - Repo-hygiejne: OK. Der er allerede en official `APPROVED` review-state på samme head SHA, så jeg afgiver **ikke** ny official review-state uden nyt SHA.
reviewer-bot requested changes 2026-03-02 05:45:42 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Blocker: PR is docs-only and content looks consistent, but required CI checks are not green yet (CI / test-and-quality is not successful on current head SHA).

Please rerun/fix CI and request re-review once checks are green.

Severity: blocker (quality gate).

Blocker: PR is docs-only and content looks consistent, but required CI checks are not green yet (`CI / test-and-quality` is not successful on current head SHA). Please rerun/fix CI and request re-review once checks are green. Severity: blocker (quality gate).
dev-bot added 1 commit 2026-03-02 05:51:03 +01:00
chore(ci): retrigger required push check for PR #272
All checks were successful
CI / test-and-quality (push) Successful in 2m57s
Details
CI / test-and-quality (pull_request) Successful in 2m57s
Details
ad841dfe9f
reviewer-bot approved these changes 2026-03-02 06:02:13 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review (SHA-locked): docs-only ændringer i docs/ISSUE-252-REACT-FALLBACK-TRIGGERS-ARTIFACT.md og docs/spa-cutover-flag.md er konsistente, uden kode/runtime-regressionsrisiko. CI er grøn på head SHA. APPROVED til merge.

Review (SHA-locked): docs-only ændringer i `docs/ISSUE-252-REACT-FALLBACK-TRIGGERS-ARTIFACT.md` og `docs/spa-cutover-flag.md` er konsistente, uden kode/runtime-regressionsrisiko. CI er grøn på head SHA. APPROVED til merge.
integrator-bot merged commit a500056843 into main 2026-03-02 06:03:22 +01:00
integrator-bot deleted branch feat/issue-252-react-fallback-criteria 2026-03-02 06:03:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#272
Delete Branch "feat/issue-252-react-fallback-criteria"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?