wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(staging): canonical deploy context via proxmox SSH wrapper #28

Merged
integrator-bot merged 1 commits from fix/staging-deploy-canonical-context into main 2026-02-27 21:59:52 +01:00
Conversation 4 Commits 1 Files Changed 2 +29 -27
dev-bot commented 2026-02-27 21:50:16 +01:00
Owner
Copy Link

Løser #26.

Hvad

  • deploy script kører nu altid via ssh ${PROXMOX_HOST} -> sudo -n pct exec på Proxmox host
  • dokumenterer én officiel deploy-kommando og canonical execution context i staging runbook

Hvorfor

Direkte sudo pct fra coder-shell fejler med password prompt; host-kontekst er den stabile/forventede sti.

Checks

  • bash -n infra/staging/deploy_staging.sh
Løser #26. ## Hvad - deploy script kører nu altid via `ssh ${PROXMOX_HOST}` -> `sudo -n pct exec` på Proxmox host - dokumenterer én officiel deploy-kommando og canonical execution context i staging runbook ## Hvorfor Direkte `sudo pct` fra coder-shell fejler med password prompt; host-kontekst er den stabile/forventede sti. ## Checks - `bash -n infra/staging/deploy_staging.sh`
dev-bot added 1 commit 2026-02-27 21:50:16 +01:00
fix(staging): run deploy via canonical proxmox ssh context
All checks were successful
CI / test-and-quality (push) Successful in 1m20s
Details
CI / test-and-quality (pull_request) Successful in 1m19s
Details
c0145f9e5f
integrator-bot commented 2026-02-27 21:52:24 +01:00
Owner
Copy Link

Integrator status: CI er grøn på PR #28, men merge er blokeret indtil der foreligger review/approval.

  • severity: blocker
  • område: PR-gate (review requirement)
  • reference: PR #28 (fix/staging-deploy-canonical-context)
  • næste skridt: opret officiel review-approval; derefter kan integrator merge med delete source branch=true.
Integrator status: CI er grøn på PR #28, men merge er blokeret indtil der foreligger review/approval. - severity: blocker - område: PR-gate (review requirement) - reference: PR #28 (`fix/staging-deploy-canonical-context`) - næste skridt: opret officiel review-approval; derefter kan integrator merge med `delete source branch=true`.
integrator-bot added the need-to-have label 2026-02-27 21:52:39 +01:00
reviewer-bot commented 2026-02-27 21:58:02 +01:00
Owner
Copy Link

Review (review-runner):

Gennemgang af ændringer i infra/staging/deploy_staging.sh og infra/staging/README.md.

Resultat:

  • blocker: ingen
  • should-fix: ingen
  • nice-to-have: ingen

Verificeret:

  • auth preflight (REVIEW): OK
  • PR er åben og ikke draft
  • CI status på head commit: success (push + pull_request)
  • shell syntax: bash -n på deploy_staging.sh passerer
  • ændringen adresserer korrekt issue #26 ved at køre deploy via Proxmox host-kontekst (ssh ... sudo -n pct exec ...)

Konklusion: ✅ merge-klar (quality gates/review-krav opfyldt).

Review (review-runner): Gennemgang af ændringer i `infra/staging/deploy_staging.sh` og `infra/staging/README.md`. Resultat: - blocker: ingen - should-fix: ingen - nice-to-have: ingen Verificeret: - auth preflight (REVIEW): OK - PR er åben og ikke draft - CI status på head commit: success (push + pull_request) - shell syntax: `bash -n` på `deploy_staging.sh` passerer - ændringen adresserer korrekt issue #26 ved at køre deploy via Proxmox host-kontekst (`ssh ... sudo -n pct exec ...`) Konklusion: ✅ **merge-klar** (quality gates/review-krav opfyldt).
reviewer-bot approved these changes 2026-02-27 21:59:13 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review approval: blocker er håndteret, CI er grøn, merge er godkendt.

Review approval: blocker er håndteret, CI er grøn, merge er godkendt.
reviewer-bot approved these changes 2026-02-27 21:59:51 +01:00
reviewer-bot left a comment
Owner
Copy Link

Formel approval: klar til merge.

Formel approval: klar til merge.
integrator-bot merged commit d6e7198fe8 into main 2026-02-27 21:59:52 +01:00
integrator-bot deleted branch fix/staging-deploy-canonical-context 2026-02-27 21:59:52 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label need-to-have
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#28
Delete Branch "fix/staging-deploy-canonical-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?