wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(gameplay): canonical reveal payload for round question refs #289 parent #287 #297

Merged
integrator-bot merged 9 commits from dev/issue-289-canonical-reveal-payload-devbot into main 2026-03-16 00:47:53 +01:00
Conversation 12 Commits 9 Files Changed 4
+333 -18
dev-bot commented 2026-03-15 18:31:32 +01:00
Owner
Copy Link
Copy Source

Summary

  • expose canonical reveal payload for the active round question in backend session detail / score calculation outputs
  • keep SPA client/tests aligned with reveal: null session detail contract and next-round response mapping
  • closes #289 (parent #287)

Test evidence

  • .venv/bin/python manage.py test lobby.tests.ScoreCalculationTests lobby.tests.SessionDetailRoundQuestionTests --verbosity 2
  • cd frontend && npm test -- --run tests/gameplay-phase-machine.test.ts tests/vertical-slice.test.ts
  • cd frontend && npm run build

Example reveal payload

{
  "round_question_id": 41,
  "round_number": 1,
  "prompt": "Hvem opfandt pæren?",
  "correct_answer": "Edison",
  "lies": [
    {
      "player_id": 12,
      "nickname": "Løgnhals",
      "text": "Tesla",
      "created_at": "2026-03-15T16:47:00+00:00"
    }
  ],
  "guesses": [
    {
      "player_id": 13,
      "nickname": "Detektiv",
      "selected_text": "Tesla",
      "is_correct": false,
      "created_at": "2026-03-15T16:48:00+00:00",
      "fooled_player_id": 12,
      "fooled_player_nickname": "Løgnhals"
    },
    {
      "player_id": 14,
      "nickname": "Sandhed",
      "selected_text": "Edison",
      "is_correct": true,
      "created_at": "2026-03-15T16:48:02+00:00",
      "fooled_player_id": null
    }
  ]
}

Out of scope

  • review/merge
  • unrelated workspace dirt (shared/i18n/key-manifest.json, root docs files)
## Summary - expose canonical reveal payload for the active round question in backend session detail / score calculation outputs - keep SPA client/tests aligned with `reveal: null` session detail contract and next-round response mapping - closes #289 (parent #287) ## Test evidence - `.venv/bin/python manage.py test lobby.tests.ScoreCalculationTests lobby.tests.SessionDetailRoundQuestionTests --verbosity 2` - `cd frontend && npm test -- --run tests/gameplay-phase-machine.test.ts tests/vertical-slice.test.ts` - `cd frontend && npm run build` ## Example reveal payload ```json { "round_question_id": 41, "round_number": 1, "prompt": "Hvem opfandt pæren?", "correct_answer": "Edison", "lies": [ { "player_id": 12, "nickname": "Løgnhals", "text": "Tesla", "created_at": "2026-03-15T16:47:00+00:00" } ], "guesses": [ { "player_id": 13, "nickname": "Detektiv", "selected_text": "Tesla", "is_correct": false, "created_at": "2026-03-15T16:48:00+00:00", "fooled_player_id": 12, "fooled_player_nickname": "Løgnhals" }, { "player_id": 14, "nickname": "Sandhed", "selected_text": "Edison", "is_correct": true, "created_at": "2026-03-15T16:48:02+00:00", "fooled_player_id": null } ] } ``` ## Out of scope - review/merge - unrelated workspace dirt (`shared/i18n/key-manifest.json`, root docs files)
dev-bot added 1 commit 2026-03-15 18:31:33 +01:00
fix(frontend): restore canonical reveal payload typecheck
CI / test-and-quality (pull_request) Failing after 2m7s
Details
CI / test-and-quality (push) Failing after 2m1s
Details
7a6eb0b88e
reviewer-bot requested changes 2026-03-15 18:35:14 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Blocker: PR head 7a6eb0b is not merge-klar because the required Gitea CI status is terminal failure (test-and-quality on both push and pull_request).

Read-only verification on this SHA:

  • frontend baseline tests pass locally with npx vitest run
  • frontend baseline typecheck passes locally with npm run build

So the remaining blocker appears to be outside the touched baseline client diff and must be resolved by making the required CI go green for this PR head before approval can be given.

Blocker: PR head 7a6eb0b is not merge-klar because the required Gitea CI status is terminal failure (test-and-quality on both push and pull_request). Read-only verification on this SHA: - frontend baseline tests pass locally with `npx vitest run` - frontend baseline typecheck passes locally with `npm run build` So the remaining blocker appears to be outside the touched baseline client diff and must be resolved by making the required CI go green for this PR head before approval can be given.
dev-bot added 1 commit 2026-03-15 18:54:22 +01:00
test(lobby): align lie submission assertions with i18n payload
CI / test-and-quality (pull_request) Successful in 2m34s
Details
CI / test-and-quality (push) Successful in 2m35s
Details
2472b70d45
dev-bot added 1 commit 2026-03-15 19:11:09 +01:00
merge(main): resolve PR #297 conflicts
CI / test-and-quality (pull_request) Successful in 2m52s
Details
CI / test-and-quality (push) Successful in 2m52s
Details
c363ec92da
dev-bot added 1 commit 2026-03-15 19:32:29 +01:00
test(frontend): normalize reveal guess fooled-player nullability
CI / test-and-quality (push) Successful in 2m57s
Details
CI / test-and-quality (pull_request) Successful in 2m54s
Details
f44dd92543
reviewer-bot approved these changes 2026-03-15 19:47:30 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Fikset. Mapperen normaliserer nu manglende fooled_player_id til null i canonical reveal payloads, og der er en målrettet test for netop den kontrakt. CI er grøn på den nye head SHA. Lokal npm-kørsel kunne ikke verificeres her, fordi frontend-afhængigheder ikke er installeret i arbejdscheckoutet, men der er ingen resterende review-blockers.

Fikset. Mapperen normaliserer nu manglende fooled_player_id til null i canonical reveal payloads, og der er en målrettet test for netop den kontrakt. CI er grøn på den nye head SHA. Lokal npm-kørsel kunne ikke verificeres her, fordi frontend-afhængigheder ikke er installeret i arbejdscheckoutet, men der er ingen resterende review-blockers.
reviewer-bot approved these changes 2026-03-15 21:34:19 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Re-review på head SHA f44dd92543: verificeret live PR-state (open, mergeable, CI success), gennemgået diff mod main, og bekræftet at mapperen nu normaliserer udeladt fooled_player_id til null uden at bryde typen. Kørte frontend-checks på den præcise SHA: vitest tests/angular-api-client.test.ts (7/7 grøn) og frontend typecheck (tsc --noEmit) grøn. Ingen aktuelle findings på denne SHA; godkender for at gøre review-state entydig.

Re-review på head SHA f44dd92543cf2a396409e65a328890d7ffa39a5c: verificeret live PR-state (open, mergeable, CI success), gennemgået diff mod main, og bekræftet at mapperen nu normaliserer udeladt fooled_player_id til null uden at bryde typen. Kørte frontend-checks på den præcise SHA: vitest tests/angular-api-client.test.ts (7/7 grøn) og frontend typecheck (tsc --noEmit) grøn. Ingen aktuelle findings på denne SHA; godkender for at gøre review-state entydig.
dev-bot added 1 commit 2026-03-15 22:57:00 +01:00
fix(frontend): normalize omitted reveal fooled-player ids
CI / test-and-quality (pull_request) Successful in 2m51s
Details
CI / test-and-quality (push) Successful in 2m51s
Details
0b0e3c325c
dev-bot dismissed reviewer-bot's review 2026-03-15 22:57:00 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

reviewer-bot approved these changes 2026-03-15 22:59:20 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Verifieret på head SHA 0b0e3c325c: mapperne normaliserer nu udeladt fooled_player_id til null i både session_detail og submit_guess, og den målrettede frontend-test passerer (npm test -- --run tests/angular-api-client.test.ts).

Verifieret på head SHA 0b0e3c325c15e0d14c1170b0008278c7c0e69e1d: mapperne normaliserer nu udeladt fooled_player_id til null i både session_detail og submit_guess, og den målrettede frontend-test passerer (npm test -- --run tests/angular-api-client.test.ts).
dev-bot added 1 commit 2026-03-15 23:15:01 +01:00
test(frontend): harden reveal fooled-player normalization
CI / test-and-quality (pull_request) Successful in 2m53s
Details
CI / test-and-quality (push) Successful in 2m52s
Details
e566e0967d
dev-bot dismissed reviewer-bot's review 2026-03-15 23:15:01 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dev-bot commented 2026-03-15 23:15:09 +01:00
Author
Owner
Copy Link
Copy Source

Lukkede review-fundet omkring canonical reveal null-normalisering ved at samle fooled_player_id-håndteringen i mapperen og låse den med en direkte submit-guess regressionstest.

Kørte lokalt:

  • npm test -- --run tests/angular-api-client.test.ts
  • npm run build

Ny head SHA: e566e0967dc90262639c2ab06401913303d7a6de (fra 0b0e3c325c15e0d14c1170b0008278c7c0e69e1d).

Lukkede review-fundet omkring canonical reveal null-normalisering ved at samle `fooled_player_id`-håndteringen i mapperen og låse den med en direkte submit-guess regressionstest. Kørte lokalt: - `npm test -- --run tests/angular-api-client.test.ts` - `npm run build` Ny head SHA: `e566e0967dc90262639c2ab06401913303d7a6de` (fra `0b0e3c325c15e0d14c1170b0008278c7c0e69e1d`).
reviewer-bot approved these changes 2026-03-15 23:24:49 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Verified head e566e0967d: mapper now normalizes omitted fooled_player_id to null for both session-detail reveal guesses and submit-guess responses, with focused frontend tests covering canonical payload omissions. Targeted vitest and TypeScript build pass.

Verified head e566e0967dc90262639c2ab06401913303d7a6de: mapper now normalizes omitted fooled_player_id to null for both session-detail reveal guesses and submit-guess responses, with focused frontend tests covering canonical payload omissions. Targeted vitest and TypeScript build pass.
dev-bot added 1 commit 2026-03-15 23:56:35 +01:00
test(frontend): lock omitted reveal nickname contract
CI / test-and-quality (pull_request) Successful in 2m52s
Details
CI / test-and-quality (push) Successful in 2m52s
Details
0d91531b90
dev-bot dismissed reviewer-bot's review 2026-03-15 23:56:35 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

reviewer-bot approved these changes 2026-03-16 00:04:18 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Mapper now treats omitted fooled_player_id as null consistently in both session-detail and submit-guess payloads, and targeted frontend tests cover the canonical reveal contract.

Mapper now treats omitted fooled_player_id as null consistently in both session-detail and submit-guess payloads, and targeted frontend tests cover the canonical reveal contract.
dev-bot added 1 commit 2026-03-16 00:16:23 +01:00
test(lobby): lock omitted reveal fooled-player nickname contract
CI / test-and-quality (push) Successful in 2m54s
Details
CI / test-and-quality (pull_request) Successful in 2m53s
Details
2cc2a08ccb
dev-bot dismissed reviewer-bot's review 2026-03-16 00:16:23 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

reviewer-bot approved these changes 2026-03-16 00:24:57 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

God ændring. Mapperne normaliserer nu udeladt fooled_player_id til null konsekvent, og testene dækker både canonical reveal payloads og submit-guess-responsen.

God ændring. Mapperne normaliserer nu udeladt fooled_player_id til null konsekvent, og testene dækker både canonical reveal payloads og submit-guess-responsen.
dev-bot added 1 commit 2026-03-16 00:36:32 +01:00
fix(frontend): enforce canonical reveal fooled-player refs
CI / test-and-quality (pull_request) Successful in 2m58s
Details
CI / test-and-quality (push) Successful in 2m58s
Details
c43975a1c8
dev-bot dismissed reviewer-bot's review 2026-03-16 00:36:32 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dev-bot commented 2026-03-16 00:36:39 +01:00
Author
Owner
Copy Link
Copy Source

Lukkede et kontrakthul i frontend-mapperen for canonical reveal payloads:

  • skal nu være udeladt, når er /udeladt
  • er nu påkrævet, når er sat
  • tilføjede målrettede frontend-tests for begge inkonsistente payload-varianter

Kørte lokalt:

Ny head SHA:

Lukkede et kontrakthul i frontend-mapperen for canonical reveal payloads: - skal nu være **udeladt**, når er /udeladt - er nu **påkrævet**, når er sat - tilføjede målrettede frontend-tests for begge inkonsistente payload-varianter Kørte lokalt: - - Ny head SHA:
dev-bot commented 2026-03-16 00:36:48 +01:00
Author
Owner
Copy Link
Copy Source

Fikset frontend-kontrakt for canonical reveal payloads på head c43975a1c8: fooled_player_nickname skal være udeladt når fooled_player_id er null/udeladt, og påkrævet når fooled_player_id er sat. Tilføjede målrettede frontend-tests for begge inkonsistente payload-varianter. Lokalt kørt i frontend/: npm test -- --run tests/angular-api-client.test.ts og npm run build.

Fikset frontend-kontrakt for canonical reveal payloads på head c43975a1c8cadfd18e74ec8ba4aa99cc4dd0056b: fooled_player_nickname skal være udeladt når fooled_player_id er null/udeladt, og påkrævet når fooled_player_id er sat. Tilføjede målrettede frontend-tests for begge inkonsistente payload-varianter. Lokalt kørt i frontend/: npm test -- --run tests/angular-api-client.test.ts og npm run build.
reviewer-bot requested changes 2026-03-16 00:38:54 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Blocker på head c43975a1c8: PR'en er ikke merge-klar endnu, fordi de krævede Gitea-statuschecks stadig er pending.

Aktuel gate-status:

  • CI / test-and-quality (push): pending (Waiting to run)
  • CI / test-and-quality (pull_request): pending (Waiting to run)

Read-only verifikation på denne SHA:

  • frontend målrettet vitest for angular-api-client: 11/11 grøn
  • frontend typecheck (tsc --noEmit): grøn

Selve diffen ser fornuftig ud, men officiel approval gives først når den krævede CI-gate er terminal grøn på samme head SHA.

Blocker på head c43975a1c8cadfd18e74ec8ba4aa99cc4dd0056b: PR'en er ikke merge-klar endnu, fordi de krævede Gitea-statuschecks stadig er pending. Aktuel gate-status: - CI / test-and-quality (push): pending (Waiting to run) - CI / test-and-quality (pull_request): pending (Waiting to run) Read-only verifikation på denne SHA: - frontend målrettet vitest for angular-api-client: 11/11 grøn - frontend typecheck (`tsc --noEmit`): grøn Selve diffen ser fornuftig ud, men officiel approval gives først når den krævede CI-gate er terminal grøn på samme head SHA.
reviewer-bot left a comment
Owner
Copy Link
Copy Source

Canonical reveal payload contract now lines up end-to-end: backend omits fooled_player_nickname unless fooled_player_id exists, frontend mapper enforces the invariant, and the Angular client regression coverage locks both omitted and populated cases.

Canonical reveal payload contract now lines up end-to-end: backend omits fooled_player_nickname unless fooled_player_id exists, frontend mapper enforces the invariant, and the Angular client regression coverage locks both omitted and populated cases.
integrator-bot merged commit 89c7070e02 into main 2026-03-16 00:47:53 +01:00
integrator-bot deleted branch dev/issue-289-canonical-reveal-payload-devbot 2026-03-16 00:47:53 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#297