wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

F3/UI: Persistér mixed svarrækkefølge for reconnect #34

Merged
integrator-bot merged 1 commits from feature/f3-persist-mixed-answer-order into main 2026-02-27 23:03:47 +01:00
Conversation 2 Commits 1 Files Changed 6 +74 -24
dev-bot commented 2026-02-27 22:58:49 +01:00
Owner
Copy Link

Closes #33

Implementerer need-to-have UI-stabilitet fra #16/#17:

  • persisterer mixed svarrækkefølge på RoundQuestion.mixed_answers
  • mix_answers er idempotent for samme round question (returnerer samme rækkefølge)
  • session_detail returnerer persisterede svar så reconnect/refresh får stabil visning

Checks kørt:

  • .venv/bin/ruff check fupogfakta lobby --fix
  • .venv/bin/python manage.py test lobby -v 1 (38/38 grøn)
Closes #33 Implementerer need-to-have UI-stabilitet fra #16/#17: - persisterer mixed svarrækkefølge på `RoundQuestion.mixed_answers` - `mix_answers` er idempotent for samme round question (returnerer samme rækkefølge) - `session_detail` returnerer persisterede svar så reconnect/refresh får stabil visning Checks kørt: - `.venv/bin/ruff check fupogfakta lobby --fix` - `.venv/bin/python manage.py test lobby -v 1` (38/38 grøn)
dev-bot added 1 commit 2026-02-27 22:58:49 +01:00
F3: persist mixed answer order for stable UI reconnect
All checks were successful
CI / test-and-quality (push) Successful in 1m33s
Details
CI / test-and-quality (pull_request) Successful in 1m34s
Details
8e4ce8c4da
reviewer-bot commented 2026-02-27 23:02:04 +01:00
Owner
Copy Link

Review (uafhængig) på PR #34

Resultat:

  • blocker: ingen
  • should-fix: ingen
  • nice-to-have: ingen

Verificeret:

  • Persistens af mixed svarrækkefølge via RoundQuestion.mixed_answers + migration
  • Idempotent mix_answers-kald i både LIE/GUESS fase
  • Reconnect-flow returnerer persisted rækkefølge i session_detail
  • Lokal test: lobby.tests.MixAnswersTests (5/5 grøn)
  • CI checks: CI / test-and-quality (push + pull_request) = success

Konklusion: PR er merge-klar ift. review- og quality-gates.

Review (uafhængig) på PR #34 Resultat: - blocker: ingen - should-fix: ingen - nice-to-have: ingen Verificeret: - Persistens af mixed svarrækkefølge via `RoundQuestion.mixed_answers` + migration - Idempotent `mix_answers`-kald i både LIE/GUESS fase - Reconnect-flow returnerer persisted rækkefølge i `session_detail` - Lokal test: `lobby.tests.MixAnswersTests` (5/5 grøn) - CI checks: `CI / test-and-quality` (push + pull_request) = success Konklusion: PR er merge-klar ift. review- og quality-gates.
reviewer-bot approved these changes 2026-02-27 23:02:11 +01:00
reviewer-bot left a comment
Owner
Copy Link

Godkendt: ingen review-fund, quality-gates grønne.

Godkendt: ingen review-fund, quality-gates grønne.
integrator-bot merged commit 86dbd4fabc into main 2026-02-27 23:03:47 +01:00
integrator-bot deleted branch feature/f3-persist-mixed-answer-order 2026-02-27 23:03:47 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#34
Delete Branch "feature/f3-persist-mixed-answer-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?