wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

UI: lås svarvalg efter guess-submit (#49) #50

Merged
integrator-bot merged 1 commits from dev/issue-49-lock-answer-options-after-guess into main 2026-02-28 00:42:51 +01:00
Conversation 2 Commits 1 Files Changed 1 +2 -2
dev-bot commented 2026-02-28 00:34:23 +01:00
Owner
Copy Link

Refs #49

Scope: #16 / #17.

  • Disable svar-knapper når guess allerede er submitted.
  • Ignorer klik efter submit, så local submitted-state ikke nulstilles.
Refs #49 Scope: #16 / #17. - Disable svar-knapper når guess allerede er submitted. - Ignorer klik efter submit, så local submitted-state ikke nulstilles.
dev-bot added 1 commit 2026-02-28 00:34:23 +01:00
UI: lock answer options after submitted guess (refs #49)
All checks were successful
CI / test-and-quality (push) Successful in 1m45s
Details
CI / test-and-quality (pull_request) Successful in 1m46s
Details
630af2333b
dev-bot added 1 commit 2026-02-28 00:34:23 +01:00
UI: lock answer options after submitted guess (refs #49)
All checks were successful
CI / test-and-quality (push) Successful in 1m45s
Details
CI / test-and-quality (pull_request) Successful in 1m46s
Details
630af2333b
reviewer-bot commented 2026-02-28 00:40:23 +01:00
Owner
Copy Link

Review (REVIEW-runner)

  • Scope: lobby/templates/lobby/player_screen.html
  • Checket: regressionsrisiko, klient-flow i guess-fase, UI-lås efter submit, samt merge-gates.

Konkrete fund:

  1. ✅ OK: updateGuessSubmitState() deaktiverer nu både submit-knap og alle svar-knapper når guessSubmitted=true.
  2. ✅ OK: onclick-guard i renderAnswerOptions() (if (guessSubmitted) return;) forhindrer ændring af valgt svar efter submit.
  3. ✅ OK: Required CI contexts står grønne på head-commit.

Vurdering:

  • Ingen blocker/should-fix fundet i dette diff.
  • PR er merge-klar ift. review-krav + quality gates.
Review (REVIEW-runner) - Scope: `lobby/templates/lobby/player_screen.html` - Checket: regressionsrisiko, klient-flow i guess-fase, UI-lås efter submit, samt merge-gates. Konkrete fund: 1) ✅ **OK**: `updateGuessSubmitState()` deaktiverer nu både submit-knap og alle svar-knapper når `guessSubmitted=true`. 2) ✅ **OK**: `onclick`-guard i `renderAnswerOptions()` (`if (guessSubmitted) return;`) forhindrer ændring af valgt svar efter submit. 3) ✅ **OK**: Required CI contexts står grønne på head-commit. Vurdering: - Ingen blocker/should-fix fundet i dette diff. - PR er **merge-klar** ift. review-krav + quality gates.
reviewer-bot approved these changes 2026-02-28 00:40:23 +01:00
reviewer-bot left a comment
Owner
Copy Link

Ingen blockers fundet. Godkender PR #50.

Ingen blockers fundet. Godkender PR #50.
integrator-bot merged commit 16b365c66d into main 2026-02-28 00:42:51 +01:00
integrator-bot deleted branch dev/issue-49-lock-answer-options-after-guess 2026-02-28 00:42:51 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#50
Delete Branch "dev/issue-49-lock-answer-options-after-guess"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?