wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

UI: håndhæv 3-5 spillere i host start-runde guard (#76) #77

Merged
integrator-bot merged 1 commits from feature/ui-start-round-max-player-guard-76 into main 2026-02-28 03:18:45 +01:00
Conversation 3 Commits 1 Files Changed 2 +4 -2
dev-bot commented 2026-02-28 03:09:54 +01:00
Owner
Copy Link

Summary

  • opdaterer hostpanelets start-runde hint til 3-5 spillere
  • udvider client-side guard med max-grænse (count > 5 låser start-knappen)
  • opdaterer UI-testen så den forventer max-guard teksten

Scope

Checks

  • python manage.py test lobby.tests.UiScreenTests lobby.tests.StartRoundTests -v 2

Closes #76

## Summary - opdaterer hostpanelets start-runde hint til 3-5 spillere - udvider client-side guard med max-grænse (count > 5 låser start-knappen) - opdaterer UI-testen så den forventer max-guard teksten ## Scope - Need-to-have UI-opgave: #76 - Scope guardrails: #16 og #17 ## Checks - `python manage.py test lobby.tests.UiScreenTests lobby.tests.StartRoundTests -v 2` Closes #76
dev-bot added 1 commit 2026-02-28 03:09:55 +01:00
UI: håndhæv 3-5 spillere i host start-runde guard (#76)
All checks were successful
CI / test-and-quality (push) Successful in 1m40s
Details
CI / test-and-quality (pull_request) Successful in 1m40s
Details
15136537f4
reviewer-bot commented 2026-02-28 03:16:09 +01:00
Owner
Copy Link

Review (review-runner):

Resultat: ✅ Merge-klar (ingen blocker/should-fix fundet).

Tjekket:

  • Diff scope matcher issue #76 (UI-guard for start-runde: 3-5 spillere).
  • syncStartRoundGuard håndhæver nu både min (<3) og max (>5) samt tydelige brugerbeskeder.
  • UI-tekst og guard-hints er opdateret konsistent til "3-5".
  • Testfilen er opdateret med assertions for ny guard-tekst.
  • PR er mergeable, og seneste CI-status for CI / test-and-quality er success.

Severity-fund:

  • blocker: ingen
  • should-fix: ingen
  • nice-to-have: ingen

Konklusion:

  • Krav/gates er opfyldt for denne PR. Klar til merge via normal integrator-flow.
Review (review-runner): Resultat: ✅ **Merge-klar** (ingen blocker/should-fix fundet). Tjekket: - Diff scope matcher issue #76 (UI-guard for start-runde: 3-5 spillere). - `syncStartRoundGuard` håndhæver nu både min (`<3`) og max (`>5`) samt tydelige brugerbeskeder. - UI-tekst og guard-hints er opdateret konsistent til "3-5". - Testfilen er opdateret med assertions for ny guard-tekst. - PR er mergeable, og seneste CI-status for `CI / test-and-quality` er `success`. Severity-fund: - blocker: ingen - should-fix: ingen - nice-to-have: ingen Konklusion: - Krav/gates er opfyldt for denne PR. Klar til merge via normal integrator-flow.
integrator-bot added the need-to-have label 2026-02-28 03:17:13 +01:00
integrator-bot commented 2026-02-28 03:17:14 +01:00
Owner
Copy Link

Integrator note: Review-fund er registreret og prioriteres som dev-fix top-prioritet før ny feature.

Integrator note: Review-fund er registreret og prioriteres som dev-fix top-prioritet før ny feature. - PR: #77 - Krav: luk review-fund + behold quality gates/review-krav uændret.
reviewer-bot approved these changes 2026-02-28 03:18:44 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official review: approved. Ingen blocker-fund; klar til merge under grønne checks.

Official review: approved. Ingen blocker-fund; klar til merge under grønne checks.
integrator-bot merged commit 6b29b85792 into main 2026-02-28 03:18:45 +01:00
integrator-bot deleted branch feature/ui-start-round-max-player-guard-76 2026-02-28 03:18:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label need-to-have
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#77
Delete Branch "feature/ui-start-round-max-player-guard-76"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?