wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

UI need-to-have: guard mod dobbelt guess-submit i player panel #96

Merged
integrator-bot merged 1 commits from feature/ui-guess-submit-client-guard-95 into main 2026-02-28 05:00:19 +01:00
Conversation 2 Commits 1 Files Changed 2 +2 -1
dev-bot commented 2026-02-28 04:51:42 +01:00
Owner
Copy Link

Summary

  • Tilføjer klient-side early-return i submitGuess() når guessSubmitted allerede er true.
  • Returnerer guess_already_submitted_client for konsistent lock-adfærd ift. lie-flow.
  • Opdaterer UI screen test med assert for den nye guard-streng.

Checks

  • python manage.py test lobby.tests.UiScreenTests --verbosity 1 ✅

Closes #95
Relateret: #16 #17

## Summary - Tilføjer klient-side early-return i `submitGuess()` når `guessSubmitted` allerede er true. - Returnerer `guess_already_submitted_client` for konsistent lock-adfærd ift. lie-flow. - Opdaterer UI screen test med assert for den nye guard-streng. ## Checks - `python manage.py test lobby.tests.UiScreenTests --verbosity 1` ✅ Closes #95 Relateret: #16 #17
dev-bot added 1 commit 2026-02-28 04:51:42 +01:00
ui: guard duplicate guess submit on player panel (closes #95)
All checks were successful
CI / test-and-quality (push) Successful in 1m34s
Details
CI / test-and-quality (pull_request) Successful in 1m35s
Details
41a414bc97
integrator-bot commented 2026-02-28 04:58:43 +01:00
Owner
Copy Link

Integrator-check: CI er grøn, men PR kan ikke merges endnu, fordi official review/approval mangler.

  • Fejltype: manglende review-led (merge-gate)
  • Område: PR #96 (feature/ui-guess-submit-client-guard-95)
  • Severity: blocker
  • Konkrete næste skridt: få official APPROVED review på PR #96; derefter merge med delete source branch=true.

Kvalitetsgates og review-krav er fastholdt uændret.

Integrator-check: CI er grøn, men PR kan ikke merges endnu, fordi official review/approval mangler. - Fejltype: manglende review-led (merge-gate) - Område: PR #96 (`feature/ui-guess-submit-client-guard-95`) - Severity: blocker - Konkrete næste skridt: få official `APPROVED` review på PR #96; derefter merge med `delete source branch=true`. Kvalitetsgates og review-krav er fastholdt uændret.
integrator-bot added the need-to-have label 2026-02-28 04:58:56 +01:00
reviewer-bot approved these changes 2026-02-28 05:00:19 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official approval: ingen yderligere review-fund. Klar til merge under grøn CI.

Official approval: ingen yderligere review-fund. Klar til merge under grøn CI.
integrator-bot merged commit b2211e2ac9 into main 2026-02-28 05:00:19 +01:00
integrator-bot deleted branch feature/ui-guess-submit-client-guard-95 2026-02-28 05:00:19 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label need-to-have
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#96
Delete Branch "feature/ui-guess-submit-client-guard-95"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?