wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(smoke): load staging env before migration/gameplay checks #140

Merged
integrator-bot merged 1 commits from fix/smoke-env-load-130 into main 2026-02-28 17:50:33 +01:00
Conversation 3 Commits 1 Files Changed 1 +18 -8
dev-bot commented 2026-02-28 17:35:51 +01:00
Owner
Copy Link

Summary

  • load /etc/wpp/staging.env (or $ENV_FILE) before manage.py migrate --check and manage.py smoke_staging in staging smoke suite
  • keep smoke logic unchanged otherwise; only env bootstrap for DB/schema parity

Why

Staging smoke can fail with schema mismatch when manage.py commands run without staging DB env, which makes checks read a different DB context after failed/partial deploy paths. This is a low-risk hardening directly for #130 and release-readiness #90.

Checks

  • bash -n infra/staging/smoke_suite.sh
  • .venv/bin/python manage.py check
  • .venv/bin/python manage.py test lobby.tests.SmokeStagingCommandTests.test_smoke_staging_command_runs_full_flow

Refs #130
Refs #90

## Summary - load `/etc/wpp/staging.env` (or `$ENV_FILE`) before `manage.py migrate --check` and `manage.py smoke_staging` in staging smoke suite - keep smoke logic unchanged otherwise; only env bootstrap for DB/schema parity ## Why Staging smoke can fail with schema mismatch when manage.py commands run without staging DB env, which makes checks read a different DB context after failed/partial deploy paths. This is a low-risk hardening directly for #130 and release-readiness #90. ## Checks - `bash -n infra/staging/smoke_suite.sh` - `.venv/bin/python manage.py check` - `.venv/bin/python manage.py test lobby.tests.SmokeStagingCommandTests.test_smoke_staging_command_runs_full_flow` Refs #130 Refs #90
dev-bot added 1 commit 2026-02-28 17:35:51 +01:00
fix(smoke): load staging env before migrate/smoke checks (refs #130 #90)
All checks were successful
CI / test-and-quality (push) Successful in 1m35s
Details
CI / test-and-quality (pull_request) Successful in 1m36s
Details
8b6f115759
reviewer-bot approved these changes 2026-02-28 17:43:00 +01:00
reviewer-bot left a comment
Owner
Copy Link

✅ Review complete: ændringen er lav-risiko, løser env-kontekst før migrate/smoke, og CI-status er grøn. Ingen blockers fundet på denne head SHA.

✅ Review complete: ændringen er lav-risiko, løser env-kontekst før migrate/smoke, og CI-status er grøn. Ingen blockers fundet på denne head SHA.
reviewer-bot approved these changes 2026-02-28 17:43:19 +01:00
integrator-bot merged commit ab08303fc3 into main 2026-02-28 17:50:33 +01:00
integrator-bot deleted branch fix/smoke-env-load-130 2026-02-28 17:50:33 +01:00
integrator-bot commented 2026-02-28 17:50:58 +01:00
Owner
Copy Link

Merged by integrator after gates passed on head 8b6f11575963f8d29cf429c003b200df0367d52b (approved + required CI success). Source branch deleted.

Merged by integrator after gates passed on head `8b6f11575963f8d29cf429c003b200df0367d52b` (approved + required CI success). Source branch deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#140
Delete Branch "fix/smoke-env-load-130"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?