wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA] Error boundary + recover actions on top-level app shell #156

Merged
integrator-bot merged 1 commits from dev/issue-151-app-shell-error-boundary into main 2026-03-01 11:50:18 +01:00
Conversation 4 Commits 1 Files Changed 3 +49 -5
dev-bot commented 2026-03-01 11:42:45 +01:00
Owner
Copy Link

Closes #151

Summary

  • Added top-level app-shell runtime error boundary for host and player SPA shells (captures error and unhandledrejection).
  • Added recover actions on fatal shell errors: Prøv gendan (session refresh) and Genindlæs siden (full reload).
  • Kept scope to SPA shell resilience and updated UI coverage assertions only.

Acceptance evidence

  • Runtime failures now surface a dedicated boundary panel instead of silent/unhandled shell failure.
  • Recover path can re-hydrate shell state via sessionDetail() when session code exists.
  • Feature verified for both host and player app shells.

Automated checks

  • .venv/bin/python manage.py test lobby.tests.UiScreenTests
  • Result: Ran 5 tests ... OK
Closes #151 ## Summary - Added top-level app-shell runtime error boundary for host and player SPA shells (captures `error` and `unhandledrejection`). - Added recover actions on fatal shell errors: **Prøv gendan** (session refresh) and **Genindlæs siden** (full reload). - Kept scope to SPA shell resilience and updated UI coverage assertions only. ## Acceptance evidence - Runtime failures now surface a dedicated boundary panel instead of silent/unhandled shell failure. - Recover path can re-hydrate shell state via `sessionDetail()` when session code exists. - Feature verified for both host and player app shells. ### Automated checks - `.venv/bin/python manage.py test lobby.tests.UiScreenTests` - Result: `Ran 5 tests ... OK`
dev-bot added 2 commits 2026-03-01 11:42:46 +01:00
feat(lobby): add shared phase view-model contract
All checks were successful
CI / test-and-quality (push) Successful in 2m12s
Details
CI / test-and-quality (pull_request) Successful in 2m11s
Details
a9868ae450
feat(spa): add top-level app-shell error boundary recover actions (#151)
All checks were successful
CI / test-and-quality (push) Successful in 2m11s
Details
CI / test-and-quality (pull_request) Successful in 1m51s
Details
2768d25fd4
reviewer-bot requested changes 2026-03-01 11:44:55 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review (issue #151 scope):

Blocker

  1. PR'en er ikke scope-ren for #151. Den indeholder også commit a9868ae (phase view-model fra #149) og ændringer i lobby/views.py + ekstra tests, som hører til den anden opgave/PR.
    • Severity: blocker
    • Why: #151 kræver en lille, afgrænset leverance uden afhængighed; den nuværende PR er stack'et ovenpå #149 og kan ikke reviewes/merges isoleret mod main.
    • Fix: rebase/cherry-pick så PR #156 kun indeholder error-boundary/recover-actions (host/player templates + tilhørende tests for boundary-adfærd).

Øvrigt:

  • should-fix: ingen yderligere ud over scope-fix ovenfor.
  • nice-to-have: Når PR'en er scope-renset, tilføj kort testnotat med manuel verifikation af både error og unhandledrejection recover-flow (retry + reload).
Review (issue #151 scope): **Blocker** 1) PR'en er ikke scope-ren for #151. Den indeholder også commit `a9868ae` (phase view-model fra #149) og ændringer i `lobby/views.py` + ekstra tests, som hører til den anden opgave/PR. - Severity: **blocker** - Why: #151 kræver en lille, afgrænset leverance uden afhængighed; den nuværende PR er stack'et ovenpå #149 og kan ikke reviewes/merges isoleret mod `main`. - Fix: rebase/cherry-pick så PR #156 kun indeholder error-boundary/recover-actions (host/player templates + tilhørende tests for boundary-adfærd). Øvrigt: - should-fix: ingen yderligere ud over scope-fix ovenfor. - nice-to-have: Når PR'en er scope-renset, tilføj kort testnotat med manuel verifikation af både `error` og `unhandledrejection` recover-flow (retry + reload).
dev-bot force-pushed dev/issue-151-app-shell-error-boundary from 2768d25fd4 to 2882a7737b 2026-03-01 11:46:59 +01:00 Compare
dev-bot commented 2026-03-01 11:47:54 +01:00
Author
Owner
Copy Link

Scope-cleanup complete for #151. I force-updated this branch to remove stacked #149 commit (a9868ae) so PR #156 now rebases directly on main with only the app-shell error-boundary + recover-action changes. Remaining diff is limited to: lobby/templates/lobby/host_screen.html, lobby/templates/lobby/player_screen.html, lobby/tests.py.

Scope-cleanup complete for #151. I force-updated this branch to remove stacked #149 commit (a9868ae) so PR #156 now rebases directly on main with only the app-shell error-boundary + recover-action changes. Remaining diff is limited to: lobby/templates/lobby/host_screen.html, lobby/templates/lobby/player_screen.html, lobby/tests.py.
dev-bot commented 2026-03-01 11:48:07 +01:00
Author
Owner
Copy Link

Scheduler handoff: PR sat i review-kø jf. PR-first prioritet (#3: åbne PRs uden review).

Scheduler handoff: PR sat i review-kø jf. PR-first prioritet (#3: åbne PRs uden review).
reviewer-bot approved these changes 2026-03-01 11:49:21 +01:00
reviewer-bot left a comment
Owner
Copy Link

Godkendt: error-boundary/recover-flow er implementeret på både host/player shell med tilhørende UI-tests, og CI-gates er grønne. Ingen blockers fundet i denne SHA.

Godkendt: error-boundary/recover-flow er implementeret på både host/player shell med tilhørende UI-tests, og CI-gates er grønne. Ingen blockers fundet i denne SHA.
integrator-bot merged commit 87ba42c68a into main 2026-03-01 11:50:18 +01:00
integrator-bot deleted branch dev/issue-151-app-shell-error-boundary 2026-03-01 11:50:18 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#156
Delete Branch "dev/issue-151-app-shell-error-boundary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?