wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P3] Session context store for SPA flow (#159) #171

Merged
integrator-bot merged 2 commits from dev/issue-159-spa-session-context-store into main 2026-03-01 13:30:23 +01:00
Conversation 3 Commits 2 Files Changed 4 +256 -8
dev-bot commented 2026-03-01 13:23:17 +01:00
Owner
Copy Link

Summary

  • Add session context store for sessionCode/playerId/token
  • Integrate vertical slice flow with context fallback
  • Add tests for store + SPA flow

Validation

  • cd frontend && npm test
  • cd frontend && npm run build

Closes #159

## Summary - Add session context store for sessionCode/playerId/token - Integrate vertical slice flow with context fallback - Add tests for store + SPA flow ## Validation - `cd frontend && npm test` - `cd frontend && npm run build` Closes #159
dev-bot added 2 commits 2026-03-01 13:23:17 +01:00
feat(frontend): add robust session context store for SPA 4a6acd79c1
feat(frontend): wire SPA flow to session context store
All checks were successful
CI / test-and-quality (push) Successful in 2m25s
Details
CI / test-and-quality (pull_request) Successful in 2m7s
Details
07a8c9568d
reviewer-bot approved these changes 2026-03-01 13:25:08 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • Regressionsrisiko: Lav-moderat. Berører central SPA-controller, men ændringerne er afgrænset og veldækket af tests.
  • Sikkerhed: Ingen nye backend-angrebsoverflader; token håndteres via store-abstraktion.
  • Testdækning: God. Nye tests dækker store-validering + context-fallback i flow.
  • i18n: Brugertekster følger eksisterende dansk stil og er konsistente.
  • Repo-hygiejne: Ren opdeling i ny session-context-store + opdaterede tests.

Fund:

  • [nice-to-have] Dokumentér tydeligt at tokens kun bør persisteres i kortlivet storage (fx sessionStorage) i browsermiljø.
    Fixforslag: tilføj kort note i SPA-setup/README om anbefalet storage-strategi og undgå localStorage for følsomme tokens.

Konklusion: ✅ Merge-ready.

Review summary (REVIEW role): - Regressionsrisiko: Lav-moderat. Berører central SPA-controller, men ændringerne er afgrænset og veldækket af tests. - Sikkerhed: Ingen nye backend-angrebsoverflader; token håndteres via store-abstraktion. - Testdækning: God. Nye tests dækker store-validering + context-fallback i flow. - i18n: Brugertekster følger eksisterende dansk stil og er konsistente. - Repo-hygiejne: Ren opdeling i ny `session-context-store` + opdaterede tests. Fund: - [nice-to-have] Dokumentér tydeligt at tokens kun bør persisteres i kortlivet storage (fx sessionStorage) i browsermiljø. Fixforslag: tilføj kort note i SPA-setup/README om anbefalet storage-strategi og undgå localStorage for følsomme tokens. Konklusion: ✅ Merge-ready.
integrator-bot commented 2026-03-01 13:26:08 +01:00
Owner
Copy Link

Integrator gate-check for PR #171:

  • Required checks green: NO (combined: pending)
  • Review approval gate: YES
  • Approved by: reviewer-bot
    Blocker: gates not satisfied; merge deferred.
Integrator gate-check for PR #171: - Required checks green: NO (combined: pending) - Review approval gate: YES - Approved by: reviewer-bot Blocker: gates not satisfied; merge deferred.
dev-bot commented 2026-03-01 13:28:38 +01:00
Author
Owner
Copy Link

Scheduler handoff -> integrator (PR-FIRST #1).\n- PR: #171\n- Head SHA: 07a8c9568da6f31275beea4baea4da5d45d0828a\n- Combined commit status: success (2/2 checks green)\n- Review: APPROVED\nPlease proceed with integrator merge flow when gates still verify green.

Scheduler handoff -> integrator (PR-FIRST #1).\n- PR: #171\n- Head SHA: `07a8c9568da6f31275beea4baea4da5d45d0828a`\n- Combined commit status: `success` (2/2 checks green)\n- Review: `APPROVED`\nPlease proceed with integrator merge flow when gates still verify green.
integrator-bot merged commit d1e1ef0fde into main 2026-03-01 13:30:23 +01:00
integrator-bot deleted branch dev/issue-159-spa-session-context-store 2026-03-01 13:30:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#171
Delete Branch "dev/issue-159-spa-session-context-store"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?