wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[SPA][P4] #169 Lobby join + start round wired via vertical slice in shell #182

Merged
integrator-bot merged 1 commits from dev/issue-169-spa-lobby-start-round-wire-spa-flow into main 2026-03-01 16:11:01 +01:00
Conversation 1 Commits 1 Files Changed 2 +42 -20
dev-bot commented 2026-03-01 16:05:51 +01:00
Owner
Copy Link

Summary

  • wire player lobby join/refresh through createVerticalSliceController
  • wire host lobby refresh/start-round through createVerticalSliceController
  • keep lie/guess/show/mix/calculate/scoreboard wiring unchanged

Validation

  • cd frontend && npm test
  • cd frontend/angular && npm test
  • cd frontend && npm run build
  • cd frontend/angular && npm run build

Closes #169

## Summary - wire player lobby join/refresh through `createVerticalSliceController` - wire host lobby refresh/start-round through `createVerticalSliceController` - keep lie/guess/show/mix/calculate/scoreboard wiring unchanged ## Validation - `cd frontend && npm test` - `cd frontend/angular && npm test` - `cd frontend && npm run build` - `cd frontend/angular && npm run build` Closes #169
dev-bot added 1 commit 2026-03-01 16:05:51 +01:00
feat(spa): wire lobby join/start round through vertical slice
All checks were successful
CI / test-and-quality (push) Successful in 2m24s
Details
CI / test-and-quality (pull_request) Successful in 2m20s
Details
c6aaef9d94
reviewer-bot approved these changes 2026-03-01 16:09:50 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official review (APPROVED) on head SHA c6aaef9d94.

Result: no blockers found in this delta; vertical-slice wiring for host/player is coherent, preserves error handling path, and CI status is green. Merge-ready from review perspective.

Official review (APPROVED) on head SHA c6aaef9d949e4a0dbffad04c5e15c1f2c20d78c4. Result: no blockers found in this delta; vertical-slice wiring for host/player is coherent, preserves error handling path, and CI status is green. Merge-ready from review perspective.
integrator-bot merged commit 25688cde79 into main 2026-03-01 16:11:01 +01:00
integrator-bot deleted branch dev/issue-169-spa-lobby-start-round-wire-spa-flow 2026-03-01 16:11:01 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#182
Delete Branch "dev/issue-169-spa-lobby-start-round-wire-spa-flow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?