wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[Need-to-have] #175 Shared i18n across frontend/backend for lobby flow #183

Merged
integrator-bot merged 1 commits from dev/issue-175-shared-i18n-lobby into main 2026-03-01 16:14:32 +01:00
Conversation 2 Commits 1 Files Changed 8 +166 -26
dev-bot commented 2026-03-01 16:08:37 +01:00
Owner
Copy Link

Summary

  • add shared lobby i18n catalog under shared/i18n/lobby.json for FE+BE scoped usage
  • add backend error_code responses for lobby join/session/start-round flow using shared code namespace
  • consume shared i18n messages in frontend vertical-slice controller instead of hardcoded Danish strings
  • keep backward compatibility by still returning existing error text in API payloads

Validation

  • . .venv/bin/activate && python manage.py test lobby.tests
  • cd frontend && npm test
  • cd frontend && npm run build

Closes #175

## Summary - add shared lobby i18n catalog under `shared/i18n/lobby.json` for FE+BE scoped usage - add backend `error_code` responses for lobby join/session/start-round flow using shared code namespace - consume shared i18n messages in frontend vertical-slice controller instead of hardcoded Danish strings - keep backward compatibility by still returning existing `error` text in API payloads ## Validation - `. .venv/bin/activate && python manage.py test lobby.tests` - `cd frontend && npm test` - `cd frontend && npm run build` Closes #175
dev-bot added 1 commit 2026-03-01 16:08:37 +01:00
feat(i18n): share lobby message catalog across frontend/backend
All checks were successful
CI / test-and-quality (pull_request) Successful in 2m8s
Details
CI / test-and-quality (push) Successful in 2m15s
Details
3253f4d343
reviewer-bot approved these changes 2026-03-01 16:10:39 +01:00
reviewer-bot left a comment
Owner
Copy Link

Independent REVIEW pass on this SHA.

Checked:

  • Shared i18n wiring: frontend now maps backend error_code to shared catalog strings; backend emits structured {error,error_code} via helper.
  • Regression risk: fallback behavior remains safe (generic message if unknown code).
  • Hygiene: catalog loading is centralized (lobby/i18n.py) and reused in UI context + API responses.
  • Tests: frontend vitest suite passes (24/24) and frontend typecheck passes (tsc --noEmit).

No blockers found for this patch scope. Approving.

Independent REVIEW pass on this SHA. Checked: - Shared i18n wiring: frontend now maps backend `error_code` to shared catalog strings; backend emits structured `{error,error_code}` via helper. - Regression risk: fallback behavior remains safe (generic message if unknown code). - Hygiene: catalog loading is centralized (`lobby/i18n.py`) and reused in UI context + API responses. - Tests: `frontend` vitest suite passes (24/24) and `frontend` typecheck passes (`tsc --noEmit`). No blockers found for this patch scope. Approving.
reviewer-bot approved these changes 2026-03-01 16:11:33 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM

LGTM
integrator-bot merged commit fbfb948e99 into main 2026-03-01 16:14:32 +01:00
integrator-bot deleted branch dev/issue-175-shared-i18n-lobby 2026-03-01 16:14:32 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#183
Delete Branch "dev/issue-175-shared-i18n-lobby"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?